Re: [f2fs-dev] [PATCH] f2fs: preserve i_mode if __f2fs_set_acl() fails

2017-07-28 Thread Chao Yu
On 2017/7/24 9:32, Ernesto A. Fernández wrote: > When changing a file's acl mask, __f2fs_set_acl() will first set the > group bits of i_mode to the value of the mask, and only then set the > actual extended attribute representing the new acl. > > If the second part fails (due to lack of space,

Re: [f2fs-dev] [RFC PATCH] f2fs: obsolete FI_ACL_MODE

2017-07-28 Thread Chao Yu
Hi Jaegeuk, Could you take time to have a look at this? Is this change reasonable? Thanks, On 2017/7/26 22:33, Chao Yu wrote: > From: Chao Yu > > Previously, in order to avoid losing important inode metadata after > checkpoint & sudden power-off, f2fs uses synchronous

Re: [f2fs-dev] [PATCH 1/2 v3] f2fs: expose /sys/fs/f2fs/features

2017-07-28 Thread Chao Yu
On 2017/7/29 3:41, Jaegeuk Kim wrote: > Change log from v2: > - add missing new features > - fix print out features > > Change log from v1: > - add /sys/fs/f2fs/dev/features > >>From cf512bfeed89d760138ade12014f17fc5779ca04 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim

Re: [f2fs-dev] [PATCH v2] f2fs: provide f2fs_balance_fs to __write_node_page

2017-07-28 Thread Chao Yu
Hi Yunlong, On 2017/7/27 20:13, Yunlong Song wrote: > v1->v2, fix some dead lock problems under some heavy load test > > On 2017/7/27 20:11, Yunlong Song wrote: >> Let node writeback also do f2fs_balance_fs to ensure there are always enough >> free >> segments. Could we cover __write_data_page

Re: [f2fs-dev] [PATCH 1/2 v3] f2fs: expose /sys/fs/f2fs/features

2017-07-28 Thread Jaegeuk Kim
Change log from v2: - add missing new features - fix print out features Change log from v1: - add /sys/fs/f2fs/dev/features >From cf512bfeed89d760138ade12014f17fc5779ca04 Mon Sep 17 00:00:00 2001 From: Jaegeuk Kim Date: Fri, 21 Jul 2017 17:14:09 -0700 Subject:

[f2fs-dev] [PATCH] f2fs: don't need to wait for node writes for atomic write

2017-07-28 Thread Jaegeuk Kim
We have a node chain to serialize node block writes, so if any IOs for node block writes are reordered, we'll get broken node chain. IOWs, roll-forward recovery will see all or none node blocks given fsync mark. E.g., Node chain consists of: N1 -> N2 -> N3 -> NFSYNC -> N1' -> N2' -> N'FSYNC

[f2fs-dev] [PATCH RESEND] f2fs: support journelled quota

2017-07-28 Thread Chao Yu
From: Chao Yu This patch supports to enable f2fs to accept quota information through mount option: - {usr,grp,prj}jquota= - jqfmt= Then, in ->mount flow, we can recover quota file during log replaying, by this, journelled quota can be supported. Signed-off-by: Chao Yu

[f2fs-dev] [PATCH RESEND 5/6] f2fs: support F2FS_IOC_FS{GET, SET}XATTR

2017-07-28 Thread Chao Yu
From: Chao Yu This patch adds FS_IOC_FSSETXATTR/FS_IOC_FSGETXATTR ioctl interface support for f2fs. The interface is kept consistent with the one of ext4/xfs. Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h | 3 + fs/f2fs/file.c | 264

[f2fs-dev] [PATCH RESEND 6/6] f2fs: introduce f2fs_statfs_project

2017-07-28 Thread Chao Yu
From: Chao Yu This patch introduces f2fs_statfs_project, it enables to show usage status of directory tree which is limited with project quota. Signed-off-by: Chao Yu --- fs/f2fs/super.c | 48 1 file

Re: [f2fs-dev] [PATCH v2] f2fs: provide f2fs_balance_fs to __write_node_page

2017-07-28 Thread Jaegeuk Kim
Hi Yunlong, On 07/27, Yunlong Song wrote: > v1->v2, fix some dead lock problems under some heavy load test So, does this patch resolve the previous GC problem? Thanks, > > On 2017/7/27 20:11, Yunlong Song wrote: > > Let node writeback also do f2fs_balance_fs to ensure there are always > >

[f2fs-dev] [PATCH] f2fs: introduce discard_granularity sysfs entry

2017-07-28 Thread Chao Yu
From: Chao Yu Commit d618ebaf0aa8 ("f2fs: enable small discard by default") enables f2fs to issue 4K size discard in real-time discard mode. However, issuing smaller discard may cost more flash lifetime but release less free space in storage. Since f2fs has ability of

[f2fs-dev] [PATCH] fs: convert a pile of fsync routines to errseq_t based reporting

2017-07-28 Thread Jeff Layton
From: Jeff Layton This patch converts most of the in-kernel filesystems that do writeback out of the pagecache to report errors using the errseq_t-based infrastructure that was recently added. This allows them to report errors once for each open file description. Most

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: expose /sys/fs/f2fs/features

2017-07-28 Thread Chao Yu
Hi Jaegeuk, On 2017/7/27 5:44, Jaegeuk Kim wrote: > Change log from v1: > - add /sys/fs/f2fs/dev/features > > This patch exposes what features are supported by current f2fs build to sysfs > entry via: > > /sys/fs/f2fs/features/> /sys/fs/f2fs/dev/features > > Signed-off-by: Jaegeuk Kim