Re: [f2fs-dev] [PATCH] f2fs: don't put dentry page in pagecache into highmem

2018-03-18 Thread Yunlong Song
OK, got it. On 2018/3/19 14:23, Jaegeuk Kim wrote: On 03/19, Yunlong Song wrote: Hi, Jaegeuk, I find this patch is removed from current branch of dev-test recently, why? Any bugs? Moved into the beginning of the tree for cherry-picking into f2fs-stable. Thanks, On 2018/2/28 20:31, Yunl

Re: [f2fs-dev] [PATCH] f2fs: don't put dentry page in pagecache into highmem

2018-03-18 Thread Jaegeuk Kim
On 03/19, Yunlong Song wrote: > Hi, Jaegeuk, > I find this patch is removed from current branch of dev-test > recently, why? Any bugs? Moved into the beginning of the tree for cherry-picking into f2fs-stable. Thanks, > > On 2018/2/28 20:31, Yunlong Song wrote: > > Previous dentry page uses

Re: [f2fs-dev] [PATCH 1/4] mkfs.f2fs: update extension lists

2018-03-18 Thread Ju Hyung Park
Hi Chao, > Do you run this script in android environment to get the cold type? Yes, both on Ubuntu and Android(on /data with root permission). > Actually, I doubt that '+1M' condition can't indicate that the file is cold or > not, and after run this script in my cell phone, Would it make sense to

Re: [f2fs-dev] [PATCH 1/4] mkfs.f2fs: update extension lists

2018-03-18 Thread Chao Yu
Hi Park, On 2018/3/17 23:02, Park Ju Hyung wrote: > Those formats are large in size and rarely updated. > > Formats such as tar and zip were intentionally excluded as > those are capable of random updates. > > (Added from vlc, p7zip and running > 'find . -type f -size +1M | > while read FILE

Re: [f2fs-dev] [PATCH 1/2] f2fs-tools: improve loggings

2018-03-18 Thread Ju Hyung Park
Hi Sheng, > Shall we handle the last '\n' in different print functions the same way? Some MSG() calls didn't have '\n' at the end with a very good reason. For consistencies between MSG, INFO_MSG and ERR_MSG, I left "\n" to the caller. > And what is the purpose of TRACE_ERR_MSG() TRACE_ERR_MSG() w

Re: [f2fs-dev] [PATCH] f2fs: don't put dentry page in pagecache into highmem

2018-03-18 Thread Yunlong Song
Hi, Jaegeuk, I find this patch is removed from current branch of dev-test recently, why? Any bugs? On 2018/2/28 20:31, Yunlong Song wrote: Previous dentry page uses highmem, which will cause panic in platforms using highmem (such as arm), since the address space of dentry pages from highmem

Re: [f2fs-dev] [PATCH 1/2] f2fs-tools: improve loggings

2018-03-18 Thread Sheng Yong
Hi, Ju Hyung and list, On 2018/3/17 23:04, Park Ju Hyung wrote: - Print errors and warnings to stderr - Print errors and warnings regardless of debugging level - Make info/error/warning logs consistent - Print POSIX errors when possible - Use more consistent terms and grammar Shall w

Re: [f2fs-dev] [PATCH 2/2] tools: sg_write_buffer: add sg_write_buffer for FFU

2018-03-18 Thread Chao Yu
On 2018/3/17 12:59, Jaegeuk Kim wrote: > On 03/16, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2018/3/14 8:08, Jaegeuk Kim wrote: >>> From: Hyojun Kim >>> >>> sg_write_buffer sources are added for FFU. >> >> Could you please explain more details about why we need to add those source >> codes? ;) > > W

Re: [f2fs-dev] [PATCH] f2fs: Set GF_NOFS in read_cache_page_gfp while doing f2fs_quota_read

2018-03-18 Thread Chao Yu
On 2018/3/16 21:23, Ritesh Harjani wrote: > Quota code itself is serializing the operations by taking mutex_lock. > It seems a below deadlock can happen if GF_NOFS is not used in > f2fs_quota_read > > __switch_to+0x88 > __schedule+0x5b0 > schedule+0x78 > schedule_preempt_disabled+0x20 > __mutex_lo

Re: [f2fs-dev] [PATCH v3] f2fs: introduce a method to make nat journal more fresh

2018-03-18 Thread Chao Yu
On 2018/3/16 17:52, heyunlei wrote: > > >> -Original Message- >> From: Yuchao (T) >> Sent: Friday, March 16, 2018 5:47 PM >> To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >> Cc: Wangbintian; Zhangdianfang (Euler) >> Subject: Re: [f2fs-dev][PATCH v3] f2fs: introd

Re: [f2fs-dev] [PATCH v3] f2fs: check blkaddr more accuratly before issue a bio

2018-03-18 Thread heyunlei
ping >-Original Message- >From: Yuchao (T) >Sent: Thursday, March 08, 2018 5:12 PM >To: heyunlei; jaeg...@kernel.org; linux-f2fs-devel@lists.sourceforge.net >Cc: Wangbintian >Subject: Re: [f2fs-dev][PATCH v3] f2fs: check blkaddr more accuratly before >issue a bio > >On 2018/3/8 16:29, Yun