[f2fs-dev] [PATCH v3] mkfs.f2fs: support multiple features with one "-O"

2018-04-07 Thread Junling Zheng
Now one "-O" option can support multiple features separated by a comma or blank, such as: feature1,feature2,... or "feature1 feature2 ..." Signed-off-by: Junling Zheng Reviewed-by: Chao Yu --- Changes from v1: - free buf to fix memory leak. Changes

[f2fs-dev] [PATCH] f2fs: fix to show missing bits in FS_IOC_GETFLAGS

2018-04-07 Thread Chao Yu
This patch fixes to show missing encrypt/inline_data flag in FS_IOC_GETFLAGS like ext4 does. Signed-off-by: Chao Yu --- fs/f2fs/file.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index

[f2fs-dev] [PATCH v2] f2fs: remove nested usage of plug list

2018-04-07 Thread Yunlei He
-f2fs_file_write_iter -blk_start_plug -__generic_file_write_iter ... -do_blockdev_direct_IO -blk_start_plug ... -blk_finish_plug ... -blk_finish_plug which may conduct performance decrease in our platform Signed-off-by:

[f2fs-dev] [PATCH] f2fs: remove nested usage of plug list

2018-04-07 Thread Yunlei He
-f2fs_file_write_iter -blk_start_plug -__generic_file_write_iter ... -do_blockdev_direct_IO -blk_start_plug ... -blk_finish_plug ... -blk_finish_plug which may conduct performance decrease in our platform Signed-off-by:

[f2fs-dev] [PATCH] mkfs.f2fs: introduce new option V to show version

2018-04-07 Thread Sheng Yong
This patch introduces a new option -V to show the version of mkfs.f2fs and exit after that. Signed-off-by: Sheng Yong --- mkfs/f2fs_format_main.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c

[f2fs-dev] [PATCH] resize.f2fs: clear CP_COMPACT_SUM_FLAG when rebuilding checkpoint

2018-04-07 Thread Sheng Yong
Resize rebuilds checkpoint with 6 summary blocks, so if CP_COMPACT_SUM_FLAG is set in the old checkpoint, clear it. Signed-off-by: Sheng Yong --- fsck/resize.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fsck/resize.c b/fsck/resize.c index 7643511..019da71

Re: [f2fs-dev] [RESEND PATCH] f2fs: no need to take the address of the array of sb->s_uuid

2018-04-07 Thread Chao Yu
On 2018/4/5 11:58, Gao Xiang wrote: > Keep in line with the common case since it is some weird > to take the address of an array again. > > Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: enlarge block plug coverage

2018-04-07 Thread Chao Yu
On 2018/4/5 11:51, Jaegeuk Kim wrote: > On 04/04, Chao Yu wrote: >> This patch enlarges block plug coverage in __issue_discard_cmd, in >> order to collect more pending bios before issuing them, to avoid >> being disturbed by previous discard I/O in IO aware discard mode. > > Hmm, then we need to

Re: [f2fs-dev] [PATCH] mkfs.f2fs: fix incorrect cold data location

2018-04-07 Thread Chao Yu
On 2018/4/5 11:47, Jaegeuk Kim wrote: > On 04/04, Chao Yu wrote: >> If last_zone((total_zones >> 2)) is equal or less than >> next_zone(CURSEG_COLD_NODE), cold data area will be located in the >> same position with hot data, fixes it. > > verify_cur_segs() will rearrage this? Yes, finally,

Re: [f2fs-dev] [PATCH] f2fs: fix to show encrypt flag in FS_IOC_GETFLAGS

2018-04-07 Thread Chao Yu
On 2018/4/5 11:46, Jaegeuk Kim wrote: > On 04/03, Chao Yu wrote: >> On 2018/4/3 4:21, Jaegeuk Kim wrote: >>> On 04/02, Chao Yu wrote: This patch fixes to show encrypt flag in FS_IOC_GETFLAGS like ext4 does. >>> >>> Actually, we have to show internal flags owned by f2fs, not generic ones. >>>

Re: [f2fs-dev] [PATCH] common/config: support f2fs-tools v1.9 and later

2018-04-07 Thread Eryu Guan
On Thu, Apr 05, 2018 at 03:19:01PM -0700, Eric Biggers wrote: > Pass the -f option to mkfs.f2fs when it appears to support it. This is > required by f2fs-tools v1.9 and later in order to format the filesystem > even when an existing filesystem is detected. But earlier versions did > not accept