[f2fs-dev] Bug in f2fs-tools-1.12.0

2018-11-24 Thread Perfect Gentleman
Hi f2fs-team, there is bug: fsck.f2fs cannot check read-only filesystem. But 1.11.0 can do that. fsck  |Info: Fix the reported corruption. fsck  |Info: Mounted device! fsck  |Info: Check FS only due to RO fsck  |Error: Failed to open the device!

[f2fs-dev] [PATCH] f2fs: fix to update new block address correctly for OPU

2018-11-24 Thread Jia Zhu
Previously, we allocated a new block address for OPU mode in direct_IO. But the new address couldn't be assigned to @map->m_pblk correctly. This patch fix it. Signed-off-by: Jia Zhu --- fs/f2fs/data.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2

Re: [f2fs-dev] [PATCH] f2fs: make "f2fs_fault_name[]" const char *

2018-11-24 Thread Chao Yu
On 2018/11/24 17:06, Alexey Dobriyan wrote: > Those strings are immutable. > > Signed-off-by: Alexey Dobriyan Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://lists.sourceforge.net/lists

Re: [f2fs-dev] [PATCH] f2fs: fix to allow node segment for GC by ioctl path

2018-11-24 Thread Chao Yu
On 2018/11/23 13:12, Sahitya Tummala wrote: > Allow node type segments also to be GC'd via f2fs ioctls > F2FS_IOC_GARBAGE_COLLECT and F2FS_IOC_GARBAGE_COLLECT_RANGE. IIRC, only F2FS_IOC_GARBAGE_COLLECT_RANGE pass a valid segment number via @result parameter in get_victim_by_default(), so in commit

Re: [f2fs-dev] [PATCH] f2fs: check memory boundary by insane namelen

2018-11-24 Thread Chao Yu
Hi Sheng, On 2018/11/23 20:11, Sheng Yong wrote: > Hi, Jaegeuk and Chao, > > On 2018/11/15 15:50, Jaegeuk Kim wrote: >> If namelen is corrupted to have very long value, fill_dentries can copy >> wrong memory area. >> > Is there any scenario that could hit this corruption? Or this is triggered I

Re: [f2fs-dev] [PATCH 1/2] f2fs: remove stale inode entry before eviction from gdirty_list

2018-11-24 Thread Chao Yu
Hi Ritesh, On 2018/11/23 19:07, Ritesh Harjani wrote: > Hi Chao, > > On 11/21/2018 9:00 AM, Chao Yu wrote: >> Hi Ritesh, >> >> On 2018/11/20 18:33, Ritesh Harjani wrote: >>> On 11/20/2018 2:33 AM, Jaegeuk Kim wrote: On 11/19, Ritesh Harjani wrote: > Hi Chao, > > On 11/19/2018 12:

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix sbi->extent_list corruption issue

2018-11-24 Thread Chao Yu
On 2018/11/23 18:19, Sahitya Tummala wrote: > On Fri, Nov 23, 2018 at 05:52:16PM +0800, Chao Yu wrote: >> On 2018/11/23 11:42, Sahitya Tummala wrote: >>> On Thu, Nov 22, 2018 at 04:11:07AM -0800, Jaegeuk Kim wrote: On 11/22, Chao Yu wrote: > On 2018/11/22 18:59, Sahitya Tummala wrote:

[f2fs-dev] [PATCH] f2fs: make "f2fs_fault_name[]" const char *

2018-11-24 Thread Alexey Dobriyan
Those strings are immutable. Signed-off-by: Alexey Dobriyan --- fs/f2fs/f2fs.h |2 +- fs/f2fs/super.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -67,7 +67,7 @@ struct f2fs_fault_info { unsigned int inject_type; }; -e