On Wednesday, December 12, 2018 8:18:12 AM IST Eric Biggers wrote:
> On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote:
> > Hi,
> >
> > On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote:
> > > In order to have a common code base for fscrypt "post read" processing
> > >
On Tuesday, December 11, 2018 11:11:17 PM IST Eric Biggers wrote:
> On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Bisect from today's next pointed me to:
> > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> > Author: Chandan Rajendra
> > Date: Sat Dec 8
In order to have a common code base for fscrypt "post read" processing
for all filesystems which support encryption, this commit removes
filesystem specific build config option (e.g. CONFIG_EXT4_FS_ENCRYPTION)
and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose
value affects all
This commit removes the ext4 specific ext4_verity_inode() and makes
use of the generic IS_ENCRYPTED() macro or ext4_test_inode_flag() to
check for the encryption status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/ext4/ext4.h | 9 -
fs/ext4/file.c
In order to have a common code base for fsverity "post read" processing
for all filesystems which support fsverity, this commit removes
filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY)
and replaces it with a build option (i.e. CONFIG_FS_VERITY) whose
value affects all the
Instead of conditionally checking for verity status of an inode before
invoking fsverity_prepare_setattr(), this commit moves the check inside the
definition of fsverity_prepare_setattr().
Signed-off-by: Chandan Rajendra
---
fs/ext4/inode.c | 8 +++-
fs/f2fs/file.c | 8
This commit removes the f2fs specific f2fs_verity_file() and makes use
of the generic IS_VERITY() macro or file_is_verity() to check for the
verity status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/f2fs/f2fs.h | 7 +--
fs/f2fs/file.c | 6 +++---
Instead of conditionally checking for verity status of an inode before
invoking fsverity_file_open(), this commit moves the check inside the
definition of fsverity_file_open().
Signed-off-by: Chandan Rajendra
---
fs/ext4/file.c | 8 +++-
fs/f2fs/file.c | 8 +++-
This commit removes the f2fs specific f2fs_encrypted_inode() and makes
use of the generic IS_ENCRYPTED() macro to check for the encryption
status of an inode.
Acked-by: Chao Yu
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/f2fs/data.c | 4 ++--
fs/f2fs/dir.c | 10
Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds
S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity
information associated with it.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
include/linux/fs.h | 2 ++
1 file changed, 2 insertions(+)
diff --git
This commit removes the ext4 specific ext4_encrypted_inode() and makes
use of the generic IS_ENCRYPTED() macro to check for the encryption
status of an inode.
Reviewed-by: Eric Biggers
Signed-off-by: Chandan Rajendra
---
fs/ext4/dir.c | 8
fs/ext4/ext4.h| 5 -
In order to have a common code base for fscrypt & fsverity "post read"
processing across filesystems which implement fscrypt/fsverity, this
commit removes filesystem specific build config option
(CONFIG_EXT4_FS_ENCRYPTION, CONFIG_EXT4_FS_VERITY,
CONFIG_F2FS_FS_ENCRYPTION, CONFIG_F2FS_FS_VERITY and
On Tue, Dec 11, 2018 at 06:42:22PM -0800, Eric Biggers wrote:
>
> Either works, but I slightly prefer my version since it minimizes the overhead
> on non-verity files when the kconfig option is enabled: it's just an i_flags
> check, rather than a function call plus an i_flags check. The same
v1->v2: delete comments in f2fs.h: "/* bio ordering for NODE/DATA */"
Signed-off-by: Yunlong Song
Reviewed-by: Chao Yu
Signed-off-by: Jaegeuk Kim
---
fs/f2fs/f2fs.h | 2 --
fs/f2fs/super.c | 5 +
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/fs/f2fs/f2fs.h
On 2018/12/12 11:17, Sahitya Tummala wrote:
> On Fri, Dec 07, 2018 at 05:47:31PM +0800, Chao Yu wrote:
>> On 2018/12/1 4:33, Jaegeuk Kim wrote:
>>> On 11/29, Sahitya Tummala wrote:
On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote:
> On 2018/11/27 8:30, Jaegeuk Kim wrote:
On Fri, Dec 07, 2018 at 05:47:31PM +0800, Chao Yu wrote:
> On 2018/12/1 4:33, Jaegeuk Kim wrote:
> > On 11/29, Sahitya Tummala wrote:
> >>
> >> On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote:
> >>> On 2018/11/27 8:30, Jaegeuk Kim wrote:
> On 11/26, Sahitya Tummala wrote:
> > When
On 12/11/18 6:48 PM, Eric Biggers wrote:
On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote:
Hi,
On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote:
In order to have a common code base for fscrypt "post read" processing
for all filesystems which support encryption,
On 12/11/2018 06:12 PM, Chao Yu wrote:
Hi all,
The commit only clean up codes which are unused currently, so why we can
improve performance with it? could you retest to make sure?
Hi Chao,
the improvement is exist in 0day environment.
➜ job cat
The fscrypt.git tree has been updated with for the problem. Apologies
for not testing the !CONFIG_FS_VERITY case.
- Ted
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote:
> Hi,
>
> On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote:
> > In order to have a common code base for fscrypt "post read" processing
> > for all filesystems which support encryption, this commit removes
> >
9: recipe for target 'allnoconfig' failed
Reverting the patch fixes the problem.
Guenter
---
bisect log:
# bad: [60bec71b5acb0b469d07e73a348f6610236ae7fa] Add linux-next specific files
for 20181211
# good: [40e020c129cfc991e8ab4736d2665351ffd1468d] Linux 4.20-rc6
On Tue, Dec 11, 2018 at 05:27:21PM -0500, Theodore Y. Ts'o wrote:
> On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> > Hi,
> >
> > Bisect from today's next pointed me to:
> > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> > Author: Chandan Rajendra
> > Date: Sat Dec 8
On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
>
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra
> Date: Sat Dec 8 12:21:43 2018 +0530
> fsverity: Move verity status check to
On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
>
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra
> Date: Sat Dec 8 12:21:43 2018 +0530
> fsverity: Move verity status check to
Hi,
Bisect from today's next pointed me to:
commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
Author: Chandan Rajendra
Date: Sat Dec 8 12:21:43 2018 +0530
fsverity: Move verity status check to fsverity_file_open
as a reason of "Operation not supported" when reading any file from
mounted
Hi all,
The commit only clean up codes which are unused currently, so why we can
improve performance with it? could you retest to make sure?
Thanks,
On 2018/12/11 17:59, kernel test robot wrote:
> Greeting,
>
> FYI, we noticed a 15.4% improvement of aim7.jobs-per-min due to commit:
>
>
>
26 matches
Mail list logo
