Re: [f2fs-dev] [PATCH V2 3/7] fscrypt: remove filesystem specific build config option

2018-12-11 Thread Chandan Rajendra
On Wednesday, December 12, 2018 8:18:12 AM IST Eric Biggers wrote: > On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote: > > Hi, > > > > On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote: > > > In order to have a common code base for fscrypt "post read" processing > > >

Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Chandan Rajendra
On Tuesday, December 11, 2018 11:11:17 PM IST Eric Biggers wrote: > On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote: > > Hi, > > > > Bisect from today's next pointed me to: > > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0 > > Author: Chandan Rajendra > > Date: Sat Dec 8

[f2fs-dev] [PATCH V4 3/9] fscrypt: remove filesystem specific build config option

2018-12-11 Thread Chandan Rajendra
In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption, this commit removes filesystem specific build config option (e.g. CONFIG_EXT4_FS_ENCRYPTION) and replaces it with a build option (i.e. CONFIG_FS_ENCRYPTION) whose value affects all

[f2fs-dev] [PATCH V4 5/9] ext4: use IS_VERITY() to check inode's fsverity status

2018-12-11 Thread Chandan Rajendra
This commit removes the ext4 specific ext4_verity_inode() and makes use of the generic IS_ENCRYPTED() macro or ext4_test_inode_flag() to check for the encryption status of an inode. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/ext4/ext4.h | 9 - fs/ext4/file.c

[f2fs-dev] [PATCH V4 7/9] fsverity: Remove filesystem specific build config option

2018-12-11 Thread Chandan Rajendra
In order to have a common code base for fsverity "post read" processing for all filesystems which support fsverity, this commit removes filesystem specific build config option (e.g. CONFIG_EXT4_FS_VERITY) and replaces it with a build option (i.e. CONFIG_FS_VERITY) whose value affects all the

[f2fs-dev] [PATCH V4 9/9] fsverity: Move verity status check to fsverity_prepare_setattr

2018-12-11 Thread Chandan Rajendra
Instead of conditionally checking for verity status of an inode before invoking fsverity_prepare_setattr(), this commit moves the check inside the definition of fsverity_prepare_setattr(). Signed-off-by: Chandan Rajendra --- fs/ext4/inode.c | 8 +++- fs/f2fs/file.c | 8

[f2fs-dev] [PATCH V4 6/9] f2fs: use IS_VERITY() to check inode's fsverity status

2018-12-11 Thread Chandan Rajendra
This commit removes the f2fs specific f2fs_verity_file() and makes use of the generic IS_VERITY() macro or file_is_verity() to check for the verity status of an inode. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/f2fs/f2fs.h | 7 +-- fs/f2fs/file.c | 6 +++---

[f2fs-dev] [PATCH V4 8/9] fsverity: Move verity status check to fsverity_file_open

2018-12-11 Thread Chandan Rajendra
Instead of conditionally checking for verity status of an inode before invoking fsverity_file_open(), this commit moves the check inside the definition of fsverity_file_open(). Signed-off-by: Chandan Rajendra --- fs/ext4/file.c | 8 +++- fs/f2fs/file.c | 8 +++-

[f2fs-dev] [PATCH V4 2/9] f2fs: use IS_ENCRYPTED() to check encryption status

2018-12-11 Thread Chandan Rajendra
This commit removes the f2fs specific f2fs_encrypted_inode() and makes use of the generic IS_ENCRYPTED() macro to check for the encryption status of an inode. Acked-by: Chao Yu Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/f2fs/data.c | 4 ++-- fs/f2fs/dir.c | 10

[f2fs-dev] [PATCH V4 4/9] Add S_VERITY and IS_VERITY()

2018-12-11 Thread Chandan Rajendra
Similar to S_ENCRYPTED/IS_ENCRYPTED(), this commit adds S_VERITY/IS_VERITY() to be able to check if a VFS inode has verity information associated with it. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- include/linux/fs.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[f2fs-dev] [PATCH V4 1/9] ext4: use IS_ENCRYPTED() to check encryption status

2018-12-11 Thread Chandan Rajendra
This commit removes the ext4 specific ext4_encrypted_inode() and makes use of the generic IS_ENCRYPTED() macro to check for the encryption status of an inode. Reviewed-by: Eric Biggers Signed-off-by: Chandan Rajendra --- fs/ext4/dir.c | 8 fs/ext4/ext4.h| 5 -

[f2fs-dev] [PATCH V4 0/9] Remove fs specific fscrypt and fsverity build config options

2018-12-11 Thread Chandan Rajendra
In order to have a common code base for fscrypt & fsverity "post read" processing across filesystems which implement fscrypt/fsverity, this commit removes filesystem specific build config option (CONFIG_EXT4_FS_ENCRYPTION, CONFIG_EXT4_FS_VERITY, CONFIG_F2FS_FS_ENCRYPTION, CONFIG_F2FS_FS_VERITY and

Re: [f2fs-dev] [PATCH 0/2] fs-verity: fix !CONFIG_FS_VERITY case

2018-12-11 Thread Theodore Y. Ts'o
On Tue, Dec 11, 2018 at 06:42:22PM -0800, Eric Biggers wrote: > > Either works, but I slightly prefer my version since it minimizes the overhead > on non-verity files when the kconfig option is enabled: it's just an i_flags > check, rather than a function call plus an i_flags check. The same

[f2fs-dev] [PATCH v2] f2fs: remove codes of unused wio_mutex

2018-12-11 Thread Yunlong Song
v1->v2: delete comments in f2fs.h: "/* bio ordering for NODE/DATA */" Signed-off-by: Yunlong Song Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim --- fs/f2fs/f2fs.h | 2 -- fs/f2fs/super.c | 5 + 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/f2fs/f2fs.h

Re: [f2fs-dev] [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2018-12-11 Thread Chao Yu
On 2018/12/12 11:17, Sahitya Tummala wrote: > On Fri, Dec 07, 2018 at 05:47:31PM +0800, Chao Yu wrote: >> On 2018/12/1 4:33, Jaegeuk Kim wrote: >>> On 11/29, Sahitya Tummala wrote: On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote: > On 2018/11/27 8:30, Jaegeuk Kim wrote:

Re: [f2fs-dev] [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2018-12-11 Thread Sahitya Tummala
On Fri, Dec 07, 2018 at 05:47:31PM +0800, Chao Yu wrote: > On 2018/12/1 4:33, Jaegeuk Kim wrote: > > On 11/29, Sahitya Tummala wrote: > >> > >> On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote: > >>> On 2018/11/27 8:30, Jaegeuk Kim wrote: > On 11/26, Sahitya Tummala wrote: > > When

Re: [f2fs-dev] [PATCH V2 3/7] fscrypt: remove filesystem specific build config option

2018-12-11 Thread Guenter Roeck
On 12/11/18 6:48 PM, Eric Biggers wrote: On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote: Hi, On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote: In order to have a common code base for fscrypt "post read" processing for all filesystems which support encryption,

Re: [f2fs-dev] [LKP] [f2fs] 089842de57: aim7.jobs-per-min 15.4% improvement

2018-12-11 Thread Rong Chen
On 12/11/2018 06:12 PM, Chao Yu wrote: Hi all, The commit only clean up codes which are unused currently, so why we can improve performance with it? could you retest to make sure? Hi Chao, the improvement is exist in 0day environment. ➜  job cat

Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Theodore Y. Ts'o
The fscrypt.git tree has been updated with for the problem. Apologies for not testing the !CONFIG_FS_VERITY case. - Ted ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH V2 3/7] fscrypt: remove filesystem specific build config option

2018-12-11 Thread Eric Biggers
On Tue, Dec 11, 2018 at 05:52:11PM -0800, Guenter Roeck wrote: > Hi, > > On Tue, Dec 04, 2018 at 03:26:46PM +0530, Chandan Rajendra wrote: > > In order to have a common code base for fscrypt "post read" processing > > for all filesystems which support encryption, this commit removes > >

Re: [f2fs-dev] [PATCH V2 3/7] fscrypt: remove filesystem specific build config option

2018-12-11 Thread Guenter Roeck
9: recipe for target 'allnoconfig' failed Reverting the patch fixes the problem. Guenter --- bisect log: # bad: [60bec71b5acb0b469d07e73a348f6610236ae7fa] Add linux-next specific files for 20181211 # good: [40e020c129cfc991e8ab4736d2665351ffd1468d] Linux 4.20-rc6

Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Eric Biggers
On Tue, Dec 11, 2018 at 05:27:21PM -0500, Theodore Y. Ts'o wrote: > On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote: > > Hi, > > > > Bisect from today's next pointed me to: > > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0 > > Author: Chandan Rajendra > > Date: Sat Dec 8

Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Theodore Y. Ts'o
On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote: > Hi, > > Bisect from today's next pointed me to: > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0 > Author: Chandan Rajendra > Date: Sat Dec 8 12:21:43 2018 +0530 > fsverity: Move verity status check to

Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Eric Biggers
On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote: > Hi, > > Bisect from today's next pointed me to: > commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0 > Author: Chandan Rajendra > Date: Sat Dec 8 12:21:43 2018 +0530 > fsverity: Move verity status check to

[f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"

2018-12-11 Thread Krzysztof Kozlowski
Hi, Bisect from today's next pointed me to: commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0 Author: Chandan Rajendra Date: Sat Dec 8 12:21:43 2018 +0530 fsverity: Move verity status check to fsverity_file_open as a reason of "Operation not supported" when reading any file from mounted

Re: [f2fs-dev] [LKP] [f2fs] 089842de57: aim7.jobs-per-min 15.4% improvement

2018-12-11 Thread Chao Yu
Hi all, The commit only clean up codes which are unused currently, so why we can improve performance with it? could you retest to make sure? Thanks, On 2018/12/11 17:59, kernel test robot wrote: > Greeting, > > FYI, we noticed a 15.4% improvement of aim7.jobs-per-min due to commit: > > >