[f2fs-dev] [PATCH v2] f2fs: check if file namelen exceeds max value

2019-01-06 Thread Sheng Yong
Dentry bitmap is not enough to detect incorrect dentries. So this patch also checks the namelen value of a dentry. Signed-off-by: Gong Chen Signed-off-by: Sheng Yong --- v2->v1: Sorry, my bad. Fix incorrect brackets. --- fs/f2fs/dir.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

Re: [f2fs-dev] fsck.f2fs segmentation fault

2019-01-06 Thread Aravind R S
Here's the backtrace where it segfaults. I don't have it compiled with the debug symbols, but if you can point me to some instructions I'm happy to try that. (gdb) backtrace #0 0x77f97894 in f2fs_set_bit () from /usr/lib/libf2fs.so.6 #1 0x55565206 in ?? () #2 0x55568214

Re: [f2fs-dev] fsck.f2fs segmentation fault

2019-01-06 Thread Aravind R S
Thanks! Here's the output of dump.f2fs: # dump.f2fs -d 1 /dev/sda2 :( Info: Debug level = 1 Info: [/dev/sda2] Disk Model: Samsung SSD 840 Info: Segments per section = 1 Info: Sections per zone = 1 Info: sector size = 512 Info: total sectors = 234041344

Re: [f2fs-dev] fsck.f2fs segmentation fault

2019-01-06 Thread Chao Yu
Hi Aravind, On 2019/1/6 1:04, Aravind R S wrote: > I use Arch Linux and the versions of the kernel and f2fs-tools > provided by that distro. I have an F2FS filesystem that seems to have > become corrupt and cannot be mounted, and running fsck.f2fs on it > results in a segmentation fault: > > # fs

Re: [f2fs-dev] [PATCH v3 1/2] f2fs-dev: support multi-device direct IO

2019-01-06 Thread Chao Yu
On 2019/1/7 10:19, sunqiuyang wrote: > From: Qiuyang Sun > > Changelog v1 ==> v2: > 1. Modify the definition of update_device_state(), >and call it in direct write; > 2. Move some local variables into branches where they are used. > > Changelog v2 ==> v3: > Rename update_device_state() to f2

Re: [f2fs-dev] [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2019-01-06 Thread Chao Yu
On 2019/1/5 4:33, Jaegeuk Kim wrote: > On 01/04, Sahitya Tummala wrote: >> On Mon, Nov 26, 2018 at 10:17:20AM +0530, Sahitya Tummala wrote: >>> When there is a failure in f2fs_fill_super() after/during >>> the recovery of fsync'd nodes, it frees the current sbi and >>> retries again. This time the

[f2fs-dev] [PATCH v3 1/2] f2fs-dev: support multi-device direct IO

2019-01-06 Thread sunqiuyang
From: Qiuyang Sun Changelog v1 ==> v2: 1. Modify the definition of update_device_state(), and call it in direct write; 2. Move some local variables into branches where they are used. Changelog v2 ==> v3: Rename update_device_state() to f2fs_update_device_state() like other exported function n

Re: [f2fs-dev] [PATCH v2] f2fs: export FS_NOCOW_FL flag to user

2019-01-06 Thread Chao Yu
On 2019/1/5 4:44, Jaegeuk Kim wrote: > This exports pin_file status to user. > > Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/l

Re: [f2fs-dev] [PATCH] f2fs: no need to check return value of debugfs_create functions

2019-01-06 Thread Chao Yu
On 2019/1/4 21:26, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jaegeuk Kim > Cc: Chao Yu > Cc: linux-f2fs-devel@lists.

Re: [f2fs-dev] [PATCH] f2fs: check if file namelen exceeds max value

2019-01-06 Thread Chao Yu
On 2019/1/4 19:53, Sheng Yong wrote: > Dentry bitmap is not enough to detect incorrect dentries. So this patch > also checks the namelen value of a dentry. > > Signed-off-by: Gong Chen > Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, ___

Re: [f2fs-dev] [PATCH v2 1/2] f2fs-dev: support multi-device direct IO

2019-01-06 Thread Chao Yu
On 2019/1/4 19:24, sunqiuyang wrote: > From: Qiuyang Sun > > Changelog v1 ==> v2: > 1. Modify the definition of update_device_state(), >and call it in direct write; > 2. Move some local variables into branches where they are used. > > Signed-off-by: Qiuyang Sun > --- > fs/f2fs/data.c|