Re: [f2fs-dev] [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-20 Thread Eric Biggers
Hi Richard, On Thu, Feb 21, 2019 at 12:52:38AM +0100, Richard Weinberger wrote: > On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote: > > +#define FSCRYPT_FS_KEYRING_DESCRIPTION_SIZE\ > > + (CONST_STRLEN("fscrypt-") + FIELD_SIZEOF(struct super_block, s_id)) > > + > > +#define FSCRYPT_MK

[f2fs-dev] [RFC PATCH 1/1] f2fs-dev: ioctl for removing a range from F2FS

2019-02-20 Thread sunqiuyang
From: Qiuyang Sun This ioctl shrinks a given length (aligned to sections) from end of the main area. Any cursegs and valid blocks will be moved out before invalidating the range. This feature can be used for adjusting partition sizes online. Signed-off-by: Qiuyang Sun --- fs/f2fs/f2fs.h|

[f2fs-dev] [PATCH] f2fs: no need to take page lock in readdir

2019-02-20 Thread Gao Xiang
VFS will take inode_lock for readdir, therefore no need to take page lock in readdir at all just as the majority of other generic filesystems. This patch improves concurrency since .iterate_shared was introduced to VFS years ago. Signed-off-by: Gao Xiang --- personally tend to use read_mapping

[f2fs-dev] [Bug 202637] New: Chmod'ed directory permission is not persisted with fsync

2019-02-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=202637 Bug ID: 202637 Summary: Chmod'ed directory permission is not persisted with fsync Product: File System Version: 2.5 Kernel Version: v5.0.0-rc7 (latest) Hardware: All

Re: [f2fs-dev] WARNING: ODEBUG bug in f2fs_fill_super

2019-02-20 Thread Sheng Yong
Hi, Dmitry, On 2019/2/20 23:12, Dmitry Vyukov wrote: On Mon, Aug 27, 2018 at 11:04 PM syzbot wrote: Hello, syzbot found the following crash on: HEAD commit:e27bc174c9c6 Add linux-next specific files for 20180824 git tree: linux-next console output: https://syzkaller.appspot.com/x/

Re: [f2fs-dev] [RFC PATCH v3 07/18] fscrypt: add FS_IOC_ADD_ENCRYPTION_KEY ioctl

2019-02-20 Thread Richard Weinberger
On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote: > +#define FSCRYPT_FS_KEYRING_DESCRIPTION_SIZE\ > + (CONST_STRLEN("fscrypt-") + FIELD_SIZEOF(struct super_block, s_id)) > + > +#define FSCRYPT_MK_DESCRIPTION_SIZE(2 * FSCRYPT_KEY_DESCRIPTOR_SIZE + 1) > + > +static void format_fs_key

Re: [f2fs-dev] [RFC PATCH v3 04/18] fs: add ->s_master_keys to struct super_block

2019-02-20 Thread Richard Weinberger
On Wed, Feb 20, 2019 at 7:55 AM Eric Biggers wrote: > > From: Eric Biggers > > Add an ->s_master_keys keyring to 'struct super_block'. New fscrypt > ioctls will allow adding and removing encryption keys from this keyring. > This will enable solving multiple interrelated problems with how fscrypt

Re: [f2fs-dev] [RFC PATCH v3 00/18] fscrypt: key management improvements

2019-02-20 Thread Eric Biggers
Hi David, On Wed, Feb 20, 2019 at 06:07:22PM +, David Howells wrote: > I have a couple of patches that add ACLs to keyrings, that you can find at the > top of the branch here: > > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-acl > > I have other

Re: [f2fs-dev] [RFC PATCH v3 00/18] fscrypt: key management improvements

2019-02-20 Thread David Howells
I have a couple of patches that add ACLs to keyrings, that you can find at the top of the branch here: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=keys-acl I have other patches that allow tags to be used as subjects in the ACL, with a container supplying

[f2fs-dev] [PATCH 3/4] f2fs_io: add fiemap

2019-02-20 Thread Jaegeuk Kim
From: Jaegeuk Kim f2fs_io fiemap [offset in 4kb] [count] [file_path] Change-Id: Iee9e8b742ada6a12a9f761b3a6de8d82a60e1b59 Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 61 + 1 file changed, 61 insertions(+) diff --git a/tools/f2fs_io/f2fs_io.

[f2fs-dev] [PATCH 4/4] f2fs_io: add gc_urgent

2019-02-20 Thread Jaegeuk Kim
e.g., f2fs_io gc_urgent dm-4 [start/end/run] [time in sec] This controls sysfs/gc_urgent to run f2fs_gc urgently. Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_

[f2fs-dev] [PATCH 1/4] f2fs_io: add write

2019-02-20 Thread Jaegeuk Kim
From: Jaegeuk Kim f2fs_io write [chunk_size in 4kb] [offset in chunk_size] [count] [pattern] [IO] [file_path] Write given patten data in file_path pattern can be zero : zeros inc_num : incrementing numbers rand : random numbers IO can be buffered : buffered IO dio : dire

[f2fs-dev] [PATCH 2/4] f2fs_io: add read

2019-02-20 Thread Jaegeuk Kim
From: Jaegeuk Kim f2fs_io read [chunk_size in 4kb] [offset in chunk_size] [count] [IO] [print_nbytes] [file_path] Read data in file_path and print nbytes IO can be buffered : buffered IO dio : direct IO Change-Id: I912adc4f443c3656ad067d29a1e2f581b79d28e6 Signed-off-by: Jaegeuk Kim -

Re: [f2fs-dev] WARNING: ODEBUG bug in f2fs_fill_super

2019-02-20 Thread Dmitry Vyukov via Linux-f2fs-devel
On Mon, Aug 27, 2018 at 11:04 PM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:e27bc174c9c6 Add linux-next specific files for 20180824 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=11c0034a40 > kernel config: h