[f2fs-dev] [PATCH] fsck.f2fs: check only max extra_isize

2019-08-16 Thread Jaegeuk Kim
If we use later kernel having larger extra_isize, old fsck will delete entire old files. Signed-off-by: Jaegeuk Kim --- fsck/fsck.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 1708abe..b4e53db 100644 --- a/fsck/fsck.c +++ b/fsck/fsck.c @@

[f2fs-dev] Tinder for Adults: The 5 Best Senior Dating Sites

2019-08-16 Thread Digytag
Votre message : Sexy girls for the night in your town: http://pizchimapa.gq/k32sx?=sNyKlxnzuSVj -- Ceci est la copie de votre message, envoyé via le formulaire de contact de Digytag (http://www.digytag.eu) Nous vous en remercions d'avance et nous reviendrons vers vous très rapidement. Equipe

Re: [f2fs-dev] f2fs: dirty memory increasing during gc_urgent

2019-08-16 Thread Ju Hyung Park
Hi Chao, On Thu, Aug 15, 2019 at 3:49 PM Chao Yu wrote: > I doubt that before triggering urgent GC, system has dirty datas in memory, > then > when you trigger `sync`, GCed data and dirty data were flushed to devices > together, if we write dirty data with out-place-update model, it may make >

Re: [f2fs-dev] [PATCH] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-16 Thread Mark Salyzyn via Linux-f2fs-devel
On 8/15/19 3:27 PM, James Morris wrote: On Thu, 15 Aug 2019, Mark Salyzyn wrote: Good Idea, but using the same argument structure for set and get I would be concerned about the loss of compiler protection for the buffer argument; Agreed, I missed that. Sadly, the pattern of struct

Re: [f2fs-dev] [PATCH v4] Add flags option to get xattr method paired to __vfs_getxattr

2019-08-16 Thread Jan Kara
On Thu 15-08-19 08:49:58, Mark Salyzyn wrote: > Add a flag option to get xattr method that could have a bit flag of > XATTR_NOSECURITY passed to it. XATTR_NOSECURITY is generally then > set in the __vfs_getxattr path. > > This handles the case of a union filesystem driver that is being >

Re: [f2fs-dev] kernel BUG at fs/f2fs/segment.c:2391 during xfstest generic/204

2019-08-16 Thread Chao Yu
Hi Eric, Sorry for late reply... I only hit ENOSPC error: QA output created by 204 line 82: echo: write error: No space left on device What is your mkfs/mount option? On 2019/7/30 1:41, Eric Biggers wrote: > On xfstest generic/204 on f2fs, I'm getting a kernel BUG. > > It bisects to: > >

Re: [f2fs-dev] [PATCH 2/3] f2fs: fix copying too many bytes in FS_IOC_SETFSLABEL

2019-08-16 Thread Chao Yu
On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > Userspace provides a null-terminated string, so don't assume that the > full FSLABEL_MAX bytes can always be copied.> > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") It may only copy redundant zero bytes, and will

Re: [f2fs-dev] [PATCH 3/3] f2fs: add missing authorization check in FS_IOC_SETFSLABEL

2019-08-16 Thread Chao Yu
On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > FS_IOC_SETFSLABEL modifies the filesystem superblock, so it shouldn't be > allowed to regular users. Require CAP_SYS_ADMIN, like xfs and btrfs do. > > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") > Signed-off-by:

[f2fs-dev] [PATCH V4 0/8] Consolidate FS read I/O callbacks code

2019-08-16 Thread Chandan Rajendra
This patchset moves the "FS read I/O callbacks" code into a file of its own (i.e. fs/read_callbacks.c) and modifies the generic do_mpage_readpge() to make use of the functionality provided. "FS read I/O callbacks" code implements the state machine that needs to be executed after reading data from

Re: [f2fs-dev] [PATCH 0/3] f2fs: fixes for FS_IOC_{GET,SET}FSLABEL

2019-08-16 Thread Chao Yu
Eric, thanks for all the fixes. Thanks, On 2019/8/16 13:55, Eric Biggers wrote: > Fix some bugs in the f2fs implementation of the FS_IOC_GETFSLABEL and > FS_IOC_SETFSLABEL ioctls. > > Eric Biggers (3): > f2fs: fix buffer overruns in FS_IOC_{GET,SET}FSLABEL > f2fs: fix copying too many bytes

Re: [f2fs-dev] [PATCH 1/3] f2fs: fix buffer overruns in FS_IOC_{GET, SET}FSLABEL

2019-08-16 Thread Chao Yu
On 2019/8/16 13:55, Eric Biggers wrote: > From: Eric Biggers > > utf16s_to_utf8s() and utf8s_to_utf16s() take the number of characters, > not the number of bytes. > > Fixes: 61a3da4d5ef8 ("f2fs: support FS_IOC_{GET,SET}FSLABEL") > Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks,

[f2fs-dev] [PATCH V4 4/8] fs/buffer.c: add decryption support via read_callbacks

2019-08-16 Thread Chandan Rajendra
This commit sets up read_callbacks context for buffer heads whose contents need to be decrypted on endio. Signed-off-by: Chandan Rajendra --- fs/buffer.c | 33 ++--- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/fs/buffer.c b/fs/buffer.c index

[f2fs-dev] [PATCH V4 6/8] ext4: Wire up ext4_readpage[s] to use mpage_readpage[s]

2019-08-16 Thread Chandan Rajendra
Now that do_mpage_readpage() is "post read process" aware, this commit gets ext4_readpage[s] to use mpage_readpage[s] and deletes ext4's readpage.c since the associated functionality is not required anymore. --- fs/ext4/Makefile | 2 +- fs/ext4/inode.c| 5 +- fs/ext4/readpage.c | 295

[f2fs-dev] [PATCH V4 2/8] FS: Introduce read callbacks

2019-08-16 Thread Chandan Rajendra
Read callbacks implements a state machine to be executed after a buffered read I/O is completed. They help in further processing the file data read from the backing store. Currently, decryption is the only post processing step to be supported. The execution of the state machine is to be initiated

[f2fs-dev] [PATCH V4 7/8] ext4: Enable encryption for subpage-sized blocks

2019-08-16 Thread Chandan Rajendra
Now that we have the code to support encryption for subpage-sized blocks, this commit removes the conditional check in filesystem mount code. The commit also changes the support statement in Documentation/filesystems/fscrypt.rst to reflect the fact that encryption of filesystems with blocksize

[f2fs-dev] [PATCH V4 3/8] fs/mpage.c: Integrate read callbacks

2019-08-16 Thread Chandan Rajendra
This commit adds code to make do_mpage_readpage() to be "read callbacks" aware i.e. for files requiring decryption, do_mpage_readpage() now sets up the read callbacks state machine when allocating a bio and later starts execution of the state machine after file data is read from the underlying

[f2fs-dev] [PATCH V4 5/8] f2fs: Use read_callbacks for decrypting file data

2019-08-16 Thread Chandan Rajendra
F2FS has a copy of "post read processing" code using which encrypted file data is decrypted. This commit replaces it to make use of the generic read_callbacks facility. Signed-off-by: Chandan Rajendra --- fs/f2fs/data.c | 109 fs/f2fs/f2fs.h |

[f2fs-dev] [PATCH V4 8/8] fscrypt: remove struct fscrypt_ctx

2019-08-16 Thread Chandan Rajendra
Commit "fscrypt: remove the 'write' part of struct fscrypt_ctx" reduced "struct fscrypt_ctx" to be used only for decryption. With "read callbacks" being integrated into Ext4 and F2FS, we don't use "struct fscrypt_ctx" anymore. Hence this commit removes the structure and the associated code. While

[f2fs-dev] [PATCH V4 1/8] buffer_head: Introduce BH_Read_Cb flag

2019-08-16 Thread Chandan Rajendra
Decryption of file content encrypted using fscrypt relies on bio->bi_private holding a pointer to an encryption context i.e. Decryption operation is not performed for bios having a NULL value at bio->bi_private. The same logic cannot be used on buffer heads because, 1. In Btrfs,