Re: [f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink

2020-06-19 Thread Chao Yu
On 2020/6/20 10:12, Lihong Kou wrote: > In the f2fs_unlink we do not add trace end for some > error paths, just add. > > Signed-off-by: Lihong Kou Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected]

[f2fs-dev] [PATCH] f2fs: make trace enter and end in pairs for unlink

2020-06-19 Thread Lihong Kou
In the f2fs_unlink we do not add trace end for some error paths, just add. Signed-off-by: Lihong Kou --- fs/f2fs/namei.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index e94e02c6580a..a15a2831d43b 100644 --- a/fs/f2fs/namei.c

Re: [f2fs-dev] [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-19 Thread Chao Yu
On 2020/6/20 6:47, Jaegeuk Kim wrote: > On 06/19, Chao Yu wrote: >> On 2020/6/19 13:49, Jaegeuk Kim wrote: >>> On 06/19, Chao Yu wrote: Hi Jaegeuk, On 2020/6/19 7:59, Jaegeuk Kim wrote: > Hi Chao, > > On 06/18, Chao Yu wrote: >> to make page content stable for special

Re: [f2fs-dev] [PATCH 1/5] f2fs: fix to wait page writeback before update

2020-06-19 Thread Jaegeuk Kim
On 06/19, Chao Yu wrote: > On 2020/6/19 13:49, Jaegeuk Kim wrote: > > On 06/19, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2020/6/19 7:59, Jaegeuk Kim wrote: > >>> Hi Chao, > >>> > >>> On 06/18, Chao Yu wrote: > to make page content stable for special device like raid. > >>> > >>> Could you

[f2fs-dev] [PATCH] fsck.f2fs: Fix slow fsck in auto-fix mode

2020-06-19 Thread Jaegeuk Kim
From: Robin Hsu Split f2fs_init_nid_bitmap() into two disjoint parts: f2fs_early_init_nid_bitmap(), and f2fs_late_init_nid_bitmap(), where f2fs_late_init_nid_bitmap() won't be called in auto-fix mode, when no errors were found. f2fs_late_init_nid_bitmap() contains the loop to cre

Re: [f2fs-dev] [PATCH 2/2] gfs2: Rework read and page fault locking

2020-06-19 Thread Matthew Wilcox
On Fri, Jun 19, 2020 at 11:39:16AM +0200, Andreas Gruenbacher wrote: > static int gfs2_readpage(struct file *file, struct page *page) > { > - struct address_space *mapping = page->mapping; > - struct gfs2_inode *ip = GFS2_I(mapping->host); > - struct gfs2_holder gh; > int error;

[f2fs-dev] [PATCH 2/2] gfs2: Rework read and page fault locking

2020-06-19 Thread Andreas Gruenbacher
The cache consistency model of filesystems like gfs2 is such that if data is found in the page cache, the data is up to date and can be used without taking any filesystem locks. If a page is not cached, filesystem locks must be taken before populating the page cache. Thus far, gfs2 has taken the

[f2fs-dev] [PATCH 1/2] fs: Add IOCB_CACHED flag for generic_file_read_iter

2020-06-19 Thread Andreas Gruenbacher
Add an IOCB_CACHED flag which indicates to generic_file_read_iter that it should only regard the page cache, without triggering any filesystem I/O for the actual request or for readahead. With this flag, -EAGAIN is returned when regular I/O would be triggered similar to the IOCB_NOWAIT flag, and -

[f2fs-dev] [RFC PATCH 0/2] gfs2 readahead regression in v5.8-rc1

2020-06-19 Thread Andreas Gruenbacher
Hello, can the two patches in this set still be considered for v5.8? Commit d4388340ae0b ("fs: convert mpage_readpages to mpage_readahead") which converts gfs2 and other filesystems to use the new ->readahead address space operation is leading to deadlocks between the inode glocks and page locks:

[f2fs-dev] [PATCH v4] f2fs-tools: introduce set_node_footer to initialize node footer

2020-06-19 Thread zhaowuyun--- via Linux-f2fs-devel
From: Wuyun Zhao the filesystem will use the cold flag, so deal with it to avoid potential issue of inconsistency Signed-off-by: Wuyun Zhao Reviewed-by: Chao Yu --- fsck/dir.c | 7 ++- fsck/node.c| 12 +--- include/f2fs_fs.h | 23 +++ mkfs/f2f

Re: [f2fs-dev] [PATCH v3] f2fs-tools: introduce set_node_footer to initialize node footer

2020-06-19 Thread Chao Yu
On 2020/6/19 16:45, [email protected] wrote: > From: Wuyun Zhao > > the filesystem will use the cold flag, so deal with it to avoid > potential issue of inconsistency > > Signed-off-by: Wuyun Zhao Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-

[f2fs-dev] [PATCH] f2fs: fix to check page dirty status before writeback

2020-06-19 Thread Chao Yu
In f2fs_write_raw_pages(), we need to check page dirty status before writeback, because there could be a racer (e.g. reclaimer) helps writebacking the dirty page. Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/fs/f2fs/compress.c b/fs/f2fs/

[f2fs-dev] 回复: [PATCH v2] f2fs-tools: introduce set_node_footer to initialize node footer

2020-06-19 Thread Zac via Linux-f2fs-devel
> On 2020/6/19 14:37, [email protected] wrote: > > From: Wuyun Zhao > > > > the filesystem will use the cold flag, so deal with it to avoid > > potential issue of inconsistency > > > > Signed-off-by: Wuyun Zhao > > --- > > fsck/dir.c | 6 +- > > fsck/node.c| 9 +---

[f2fs-dev] [PATCH v3] f2fs-tools: introduce set_node_footer to initialize node footer

2020-06-19 Thread zhaowuyun--- via Linux-f2fs-devel
From: Wuyun Zhao the filesystem will use the cold flag, so deal with it to avoid potential issue of inconsistency Signed-off-by: Wuyun Zhao --- fsck/dir.c | 7 ++- fsck/node.c| 12 +--- include/f2fs_fs.h | 23 +++ mkfs/f2fs_format.c | 34 ++

Re: [f2fs-dev] [PATCH v2] f2fs-tools: introduce set_node_footer to initialize node footer

2020-06-19 Thread Chao Yu
On 2020/6/19 14:37, [email protected] wrote: > From: Wuyun Zhao > > the filesystem will use the cold flag, so deal with it to avoid > potential issue of inconsistency > > Signed-off-by: Wuyun Zhao > --- > fsck/dir.c | 6 +- > fsck/node.c| 9 + > include/f2fs_