[f2fs-dev] [PATCH] fscrypt: fix inline encryption not used on new files

2020-11-10 Thread Eric Biggers
From: Eric Biggers The new helper function fscrypt_prepare_new_inode() runs before S_ENCRYPTED has been set on the new inode. This accidentally made fscrypt_select_encryption_impl() never enable inline encryption on newly created files, due to its use of fscrypt_needs_contents_encryption() which

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 10, 2020, at 10:39 AM, Christoph Hellwig wrote: > > On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: >> You do consistently ask for a shim layer, but you haven???t explained what >> we gain by diverging from the documented and tested API of the upstream zstd >> project. It

Re: [f2fs-dev] [PATCH v5 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE

2020-11-10 Thread Eric Biggers
On Tue, Nov 10, 2020 at 09:24:37AM +0800, Chao Yu wrote: > Eric reported a ioctl bug in below link: > > https://lore.kernel.org/linux-f2fs-devel/[email protected]/ > > That said, on some 32-bit architectures, u64 has only 32-bit alignment, > notably i386 and x86_32, so that si

Re: [f2fs-dev] [PATCH v5 1/2] f2fs: avoid unneeded data copy in f2fs_ioc_move_range()

2020-11-10 Thread Eric Biggers
On Tue, Nov 10, 2020 at 09:24:36AM +0800, Chao Yu wrote: > Fields in struct f2fs_move_range won't change in f2fs_ioc_move_range(), > let's avoid copying this structure's data to userspace. > > Signed-off-by: Chao Yu > --- Reviewed-by: Eric Biggers _

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Nick Terrell via Linux-f2fs-devel
> On Nov 10, 2020, at 7:25 AM, David Sterba wrote: > > On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: >> On 6 Nov 2020, at 13:38, Christoph Hellwig wrote: >>> You just keep resedning this crap, don't you? Haven't you been told >>> multiple times to provide a proper kernel API by no

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Chris Mason via Linux-f2fs-devel
On 10 Nov 2020, at 13:39, Christoph Hellwig wrote: On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: You do consistently ask for a shim layer, but you haven???t explained what we gain by diverging from the documented and tested API of the upstream zstd project. It???s an important

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread Christoph Hellwig
On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: > You do consistently ask for a shim layer, but you haven???t explained what > we gain by diverging from the documented and tested API of the upstream zstd > project. It???s an important discussion given that we hope to regularly > updat

Re: [f2fs-dev] [PATCH v5 1/9] lib: zstd: Add zstd compatibility wrapper

2020-11-10 Thread David Sterba
On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote: > On 6 Nov 2020, at 13:38, Christoph Hellwig wrote: > > You just keep resedning this crap, don't you? Haven't you been told > > multiple times to provide a proper kernel API by now? > > You do consistently ask for a shim layer, but you

Re: [f2fs-dev] [PATCH] f2fs: compress: support chksum

2020-11-10 Thread David Laight
From: Chao Yu > Sent: 10 November 2020 06:28 ... > Actually, I think the both results are the same, inode chksum doesn't match > inode > metadata, like current case that cluster chksum doesn't match cluster data, it > doesn't matter how it becomes mismatched. > > And also, in those inode corrupte

Re: [f2fs-dev] [PATCH RFC PKS/PMEM 05/58] kmap: Introduce k[un]map_thread

2020-11-10 Thread Thomas Gleixner
On Mon, Nov 09 2020 at 20:59, Ira Weiny wrote: > On Tue, Nov 10, 2020 at 02:13:56AM +0100, Thomas Gleixner wrote: > Also, we can convert the new memcpy_*_page() calls to kmap_local() as well. > [For now my patch just uses kmap_atomic().] > > I've not looked at all of the patches in your latest vers

[f2fs-dev] [PATCH] f2fs-tools: skipped to end on error syntax error

2020-11-10 Thread Robin Hsu via Linux-f2fs-devel
When error were found, we won't need to do any initialization but just quit. Signed-off-by: Robin Hsu --- fsck/main.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/fsck/main.c b/fsck/main.c index 32559f1..e70048b 100644 --- a/fsck/main.c +++ b/fsc