[f2fs-dev] [PATCH] f2fs: compress: remove unneeded read when rewrite whole cluster

2021-06-09 Thread Fengnan Chang via Linux-f2fs-devel
For now, when overwrite compressed file, we need read old data to page cache first and update pages. But when we need overwrite whole cluster, we don't need old data anymore. So, remove read data process in this case, I have made some simple changes to test, tests have shown that this can lead to s

Re: [f2fs-dev] Multiple fsck runs required to fix quota

2021-06-09 Thread Juhyung Park
Hi Chao, No worries, this wasn't critical at all :) I wasn't able to get a dump of the userdata partition then as it was running on my real daily driver phone, but I'll try it if I notice the issue again. Thanks! On Wed, Jun 9, 2021 at 10:28 PM Chao Yu wrote: > > Hi Ju Hyung, > > Sorry for the

Re: [f2fs-dev] [PATCH 2/2] f2fs: introduce FI_COMPRESS_RELEASED instead of using IMMUTABLE bit

2021-06-09 Thread Jaegeuk Kim
On 06/08, Chao Yu wrote: > On 2021/6/8 0:56, Jaegeuk Kim wrote: > > On 06/06, Chao Yu wrote: > > > On 2021/5/26 4:49, Jaegeuk Kim wrote: > > > > Once we release compressed blocks, we used to set IMMUTABLE bit. But it > > > > turned > > > > out it disallows every fs operations which we don't need f

Re: [f2fs-dev] [PATCH] sload.f2fs: use F2FS_COMPRESS_RELEASED instead of IMMUTABLE bit

2021-06-09 Thread Jaegeuk Kim
On 06/08, Chao Yu wrote: > On 2021/6/8 0:52, Jaegeuk Kim wrote: > > On 06/06, Chao Yu wrote: > > > On 2021/5/26 4:51, Jaegeuk Kim wrote: > > > > Let's use F2FS_COMPRESS_RELEASED to disallow writes only. > > > > > > > > Signed-off-by: Jaegeuk Kim > > > > > > Reviewed-by: Chao Yu > > > > Too lat

Re: [f2fs-dev] Multiple fsck runs required to fix quota

2021-06-09 Thread Chao Yu
Hi Ju Hyung, Sorry for the delay. On 2021/5/25 16:03, Ju Hyung Park wrote: Hi. I'm reporting a possible issue with fsck requiring multiple runs to fix quota. The fsck version is the latest master branch, statically compiled under arm64 flavor of Ubuntu and was executed under recovery mode. F