Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-26 Thread Chao Yu
On 2021/7/27 10:00, Jaegeuk Kim wrote: On 07/25, Eric Biggers wrote: On Sun, Jul 25, 2021 at 06:50:51PM +0800, Chao Yu wrote: On 2021/7/16 22:39, Eric Biggers wrote: From: Eric Biggers f2fs_write_begin() assumes that all blocks were preallocated by default unless FI_NO_PREALLOC is

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-26 Thread Jaegeuk Kim
On 07/25, Eric Biggers wrote: > On Sun, Jul 25, 2021 at 06:50:51PM +0800, Chao Yu wrote: > > On 2021/7/16 22:39, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > f2fs_write_begin() assumes that all blocks were preallocated by > > > default unless FI_NO_PREALLOC is explicitly set. This

Re: [f2fs-dev] [PATCH 3/9] f2fs: rework write preallocations

2021-07-26 Thread Jaegeuk Kim
On 07/25, Eric Biggers wrote: > On Sun, Jul 25, 2021 at 08:47:51AM -0700, Jaegeuk Kim wrote: > > On 07/25, Jaegeuk Kim wrote: > > > Note that, this patch is failing generic/250. > > > > correction: it's failing in 4.14 and 4.19 after simple cherry-pick, but > > giving no failure on 5.4, 5.10, and

[f2fs-dev] [PATCH] f2fs: do not submit NEW_ADDR to read node block

2021-07-26 Thread Jaegeuk Kim
After the below patch, give cp is errored, we drop dirty node pages. This can give NEW_ADDR to read node pages. Don't do WARN_ON() which gives generic/475 failure. Fixes: 28607bf3aa6f ("f2fs: drop dirty node pages when cp is in error status") Signed-off-by: Jaegeuk Kim --- fs/f2fs/node.c | 3

Re: [f2fs-dev] [syzbot] BUG: unable to handle kernel NULL pointer dereference in f2fs_update_meta_page

2021-07-26 Thread Hillf Danton
On Sun, 25 Jul 2021 23:00:19 -0700 > syzbot found the following issue on: > > HEAD commit:6498f6151825 Merge tag 'riscv-for-linus-5.14-rc3' of git:/.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=14bbce4630 > kernel config:

[f2fs-dev] [syzbot] BUG: unable to handle kernel NULL pointer dereference in f2fs_update_meta_page

2021-07-26 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:6498f6151825 Merge tag 'riscv-for-linus-5.14-rc3' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14bbce4630 kernel config: https://syzkaller.appspot.com/x/.config?x=5dc0e3202ae2f574