Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Tim Murray via Linux-f2fs-devel
On Mon, Jan 10, 2022 at 8:15 PM Waiman Long wrote: > That is not how rwsem works. A reader which fails to get the lock > because it is write-locked will remove its reader count before going to > sleep. So the reader count will be zero eventually. Of course, there is > a short period of time where

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Waiman Long
On 1/10/22 14:41, Tim Murray wrote: On Mon, Jan 10, 2022 at 7:02 AM Peter Zijlstra wrote: Can we start by describing the actual problem? Of course. Sorry, I didn't realize Jaegeuk was going to move so quickly with this patch :) We have a few thousand traces from internal Android devices whe

[f2fs-dev] [Bug 215235] page fault in f2fs_setxattr() when mount and operate on corrupted image

2022-01-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215235 --- Comment #5 from Chao Yu ([email protected]) --- This patch was merged in dev branch, and will be pushed to mainline in 5.17-rc1. https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=645a3c40ca3d40cc32b4b5972bf2

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Tim Murray via Linux-f2fs-devel
On Mon, Jan 10, 2022 at 7:02 AM Peter Zijlstra wrote: > Can we start by describing the actual problem? Of course. Sorry, I didn't realize Jaegeuk was going to move so quickly with this patch :) We have a few thousand traces from internal Android devices where large numbers of threads throughout

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Waiman Long
On 1/10/22 13:45, Peter Zijlstra wrote: On Mon, Jan 10, 2022 at 11:18:27AM -0500, Waiman Long wrote: On 1/10/22 03:05, Christoph Hellwig wrote: Adding the locking primitive maintainers to this patch adding open coded locking primitives.. On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Peter Zijlstra
On Mon, Jan 10, 2022 at 11:18:27AM -0500, Waiman Long wrote: > > On 1/10/22 03:05, Christoph Hellwig wrote: > > Adding the locking primitive maintainers to this patch adding open coded > > locking primitives.. > > > > On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim wrote: > > > From: Tim Mu

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Waiman Long
On 1/10/22 03:05, Christoph Hellwig wrote: Adding the locking primitive maintainers to this patch adding open coded locking primitives.. On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim wrote: From: Tim Murray f2fs rw_semaphores work better if writers can starve readers, especially for

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Peter Zijlstra
On Mon, Jan 10, 2022 at 12:05:26AM -0800, Christoph Hellwig wrote: > Adding the locking primitive maintainers to this patch adding open coded > locking primitives.. > > On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim wrote: > > From: Tim Murray > > > > f2fs rw_semaphores work better if wri

[f2fs-dev] [Bug 215235] page fault in f2fs_setxattr() when mount and operate on corrupted image

2022-01-10 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=215235 David Disseldorp ([email protected]) changed: What|Removed |Added CC||[email protected]

Re: [f2fs-dev] [PATCH] f2fs: do not allow partial truncation on pinned file

2022-01-10 Thread Chao Yu
On 2022/1/9 0:45, Jaegeuk Kim wrote: If the pinned file has a hole by partial truncation, application that has the block map will be broken. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks ___ Linux-f2fs-devel mailing list Linux-f2fs-dev

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-01-10 Thread Christoph Hellwig
Adding the locking primitive maintainers to this patch adding open coded locking primitives.. On Sat, Jan 08, 2022 at 08:46:17AM -0800, Jaegeuk Kim wrote: > From: Tim Murray > > f2fs rw_semaphores work better if writers can starve readers, > especially for the checkpoint thread, because writers