[f2fs-dev] [PATCH 9/9] Remove congestion tracking framework.

2022-01-26 Thread NeilBrown
This framework is no longer used - so discard it. Signed-off-by: NeilBrown --- include/linux/backing-dev-defs.h |8 - include/linux/backing-dev.h |2 - include/trace/events/writeback.h | 28 --- mm/backing-dev.c | 57 --

[f2fs-dev] [PATCH 8/9] block/bfq-iosched.c: use "false" rather than "BLK_RW_ASYNC"

2022-01-26 Thread NeilBrown
bfq_get_queue() expects a "bool" for the third arg, so pass "false" rather than "BLK_RW_ASYNC" which will soon be removed. Signed-off-by: NeilBrown --- block/bfq-iosched.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 0c612

[f2fs-dev] [PATCH 7/9] NFS: remove congestion control.

2022-01-26 Thread NeilBrown
Linux no longer uses the bdi congestion tracking framework. So remove code from bdi which tries to support it. Also remove the "nfs_congestion_kb" sysctl. This is a user-visible change, but unlikely to be a problematic one. Signed-off-by: NeilBrown --- fs/nfs/sysctl.c |7 --

[f2fs-dev] [PATCH 6/9] fuse: don't set/clear bdi_congested

2022-01-26 Thread NeilBrown
The bid congestion framework is no longer used to manage writeout etc, so drop updating it in fuse. Signed-off-by: NeilBrown --- fs/fuse/control.c | 17 - fs/fuse/dev.c |8 2 files changed, 25 deletions(-) diff --git a/fs/fuse/control.c b/fs/fuse/control.c ind

[f2fs-dev] [PATCH 5/9] cephfs: don't set/clear bdi_congestion

2022-01-26 Thread NeilBrown
The bdi congestion framework is no-longer used - writeback uses other mechanisms to manage throughput. So remove calls to set_bdi_congested() and clear_bdi_congested(), and remove the writeback_count which is used only to guide the setting and clearing. The congestion_kb mount option is no longer

[f2fs-dev] [PATCH 4/9] f2f2: replace some congestion_wait() calls with io_schedule_timeout()

2022-01-26 Thread NeilBrown
As congestion is no longer tracked, contestion_wait() is effectively equivalent to io_schedule_timeout(). It isn't clear to me what these contestion_wait() calls are waiting for, so I cannot change them to wait for some particular event. So simply change them to io_schedule_timeout(), which will ha

[f2fs-dev] [PATCH 3/9] f2fs: change retry waiting for f2fs_write_single_data_page()

2022-01-26 Thread NeilBrown
f2fs_write_single_data_page() can return -EAGAIN if it cannot get the cp_rwsem lock - it holds a page lock and so cannot wait for it. Some code which calls f2fs_write_single_data_page() use congestion_wait() and then tries again. congestion_wait() doesn't do anything useful as congestion is no lo

[f2fs-dev] [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions

2022-01-26 Thread NeilBrown
These functions are no longer useful as the only bdis that report congestion are in ceph, fuse, and nfs. None of those bdis can be the target of the calls in drbd, ext2, nilfs2, or xfs. Removing the test on bdi_write_contested() in current_may_throttle() could cause a small change in behaviour, b

[f2fs-dev] [PATCH 0/9] Remove remaining parts of congestions tracking code.

2022-01-26 Thread NeilBrown
Congestion hasn't been reliably tracked for quite some time. Most MM uses of it for guiding writeback decisions were removed in 5.16. Some other uses were removed in 17-rc1. This series removes the remaining places that test for congestion, and the few places which still set it. The second patch

[f2fs-dev] [PATCH 1/9] Remove inode_congested()

2022-01-26 Thread NeilBrown
inode_congested() reports if the backing-device for the inode is congested. Few bdi report congestion any more, only ceph, fuse, and nfs. Having support just for those is unlikely to be useful. The places which test inode_congested() or it variants like inode_write_congested(), avoid initiating