Re: [f2fs-dev] [PATCH] f2fs: quota: fix loop condition at f2fs_quota_sync()

2022-02-24 Thread Chao Yu via Linux-f2fs-devel
On 2022/2/15 16:27, Juhyung Park wrote: cnt should be passed to sb_has_quota_active() instead of type to check active quota properly. Moreover, when the type is -1, the compiler with enough inline knowledge can discard sb_has_quota_active() check altogether, causing a NULL pointer dereference

Re: [f2fs-dev] [PATCH v2] mkfs.f2fs: set project quota by default for -g android

2022-02-24 Thread Chao Yu
On 2022/2/9 7:39, Jaegeuk Kim wrote: With this patch, "-g android" enables usr/grp/proj quota by default. 1) -O quota : enables usr/grp 2) -O project_quota -O extra_attr : enabled prj 3) -O quota -O project_quota -O extra_attr : enables usr/grp/proj 4) -g android : enables usr/grp/proj 5) -g

Re: [f2fs-dev] [PATCH] f2fs: avoid sb_start_intwrite during eviction

2022-02-24 Thread Chao Yu
On 2022/2/16 6:00, Jaegeuk Kim wrote: 1. this thread is stuck in f2fs_evict_inode by #2: [210757.653718] __schedule+0x2e3/0x740 [210757.654811] schedule+0x42/0xb0 [210757.655829] rwsem_down_read_slowpath+0x16c/0x4a0 Who has held sb->s_writers.rw_sem? Thanks, [210757.657161]

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid potential deadlock

2022-02-24 Thread Chao Yu
On 2022/2/3 22:57, Chao Yu wrote: On 2022/2/3 9:51, Jaegeuk Kim wrote: On 01/29, Chao Yu wrote: On 2022/1/29 8:37, Jaegeuk Kim wrote: On 01/28, Chao Yu wrote: On 2022/1/28 5:59, Jaegeuk Kim wrote: On 01/27, Chao Yu wrote: Quoted from Jing Xia's report, there is a potential deadlock may

Re: [f2fs-dev] [PATCH 2/2 v2] f2fs: avoid an infinite loop in f2fs_sync_dirty_inodes

2022-02-24 Thread Chao Yu
On 2022/2/15 7:27, Jaegeuk Kim wrote: If one read IO is always failing, we can fall into an infinite loop in f2fs_sync_dirty_inodes. This happens during xfstests/generic/475. [ 142.803335] Buffer I/O error on dev dm-1, logical block 8388592, async page read ... [ 382.887210]

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-24 Thread Hillf Danton
On Thu, 24 Feb 2022 16:47:30 +0800 Hillf Danton wrote: > On Sat, 8 Jan 2022 08:46:17 -0800 > > From: Tim Murray > > > > f2fs rw_semaphores work better if writers can starve readers, > > especially for the checkpoint thread, because writers are strictly > > more important than reader threads.

Re: [f2fs-dev] [PATCH] common/attr: adbjust acl_max of f2fs

2022-02-24 Thread Chao Yu via Linux-f2fs-devel
On 2022/2/8 15:16, Sun Ke via Linux-f2fs-devel wrote: f2fs has set inline_xattr as a default option, and introduced a new option named 'noinline_xattr' for disabling default inline_xattr option. So in _acl_get_max we need to check 'noinline_xattr' string in fs option, otherwise we may select the

Re: [f2fs-dev] [PATCH 02/11] MM: document and polish read-ahead code.

2022-02-24 Thread Jan Kara
On Fri 11-02-22 10:35:17, NeilBrown wrote: > On Thu, 10 Feb 2022, Jan Kara wrote: > > Hi Neil! > > > > On Thu 10-02-22 16:37:52, NeilBrown wrote: > > > Add some "big-picture" documentation for read-ahead and polish the code > > > to make it fit this documentation. > > > > > > The meaning of

Re: [f2fs-dev] [PATCH 08/11] Remove bdi_congested() and wb_congested() and related functions

2022-02-24 Thread Ryusuke Konishi
On Thu, Feb 10, 2022 at 2:41 PM NeilBrown wrote: > > These functions are no longer useful as no BDIs report congestions any > more. > > Removing the test on bdi_write_contested() in current_may_throttle() > could cause a small change in behaviour, but only when PF_LOCAL_THROTTLE > is set. > > So

Re: [f2fs-dev] [PATCH 06/11] ceph: remove reliance on bdi congestion

2022-02-24 Thread Jeff Layton
On Thu, 2022-02-24 at 16:41 +1100, NeilBrown wrote: > On Thu, 24 Feb 2022, Jeff Layton wrote: > > On Tue, 2022-02-22 at 14:17 +1100, NeilBrown wrote: > > > The bdi congestion tracking in not widely used and will be removed. > > > > > > CEPHfs is one of a small number of filesystems that uses it,

[f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-24 Thread Hillf Danton
On Sat, 8 Jan 2022 08:46:17 -0800 > From: Tim Murray > > f2fs rw_semaphores work better if writers can starve readers, > especially for the checkpoint thread, because writers are strictly > more important than reader threads. This prevents significant priority > inversion between low-priority

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix missing free nid in f2fs_handle_failed_inode

2022-02-24 Thread Chao Yu
On 2022/2/12 22:20, Jaegeuk Kim wrote: This patch fixes xfstests/generic/475 failure. [ 293.680694] F2FS-fs (dm-1): May loss orphan inode, run fsck to fix. [ 293.685358] Buffer I/O error on dev dm-1, logical block 8388592, async page read [ 293.691527] Buffer I/O error on dev dm-1, logical