Re: [f2fs-dev] [PATCH 02/11] MM: document and polish read-ahead code.

2022-02-27 Thread NeilBrown
On Mon, 28 Feb 2022, Andrew Morton wrote: > On Mon, 28 Feb 2022 15:28:39 +1100 "NeilBrown" wrote: > > > When writing documentation the intent of the author is of some interest, > > but the behaviour of the code is paramount. > > uh, er, ah, no. The code describes the behaviour of the code.

Re: [f2fs-dev] [PATCH 02/11] MM: document and polish read-ahead code.

2022-02-27 Thread Andrew Morton
On Mon, 28 Feb 2022 15:28:39 +1100 "NeilBrown" wrote: > When writing documentation the intent of the author is of some interest, > but the behaviour of the code is paramount. uh, er, ah, no. The code describes the behaviour of the code. The comments are there to describe things other than the

Re: [f2fs-dev] [PATCH 02/11] MM: document and polish read-ahead code.

2022-02-27 Thread NeilBrown
On Fri, 25 Feb 2022, Jan Kara wrote: > On Fri 11-02-22 10:35:17, NeilBrown wrote: > > On Thu, 10 Feb 2022, Jan Kara wrote: > > > Hi Neil! > > > > > > On Thu 10-02-22 16:37:52, NeilBrown wrote: > > > > Add some "big-picture" documentation for read-ahead and polish the code > > > > to make it fit

[f2fs-dev] [PATCH] generic/066: attr1 is still there after log replay on f2fs

2022-02-27 Thread Sun Ke via Linux-f2fs-devel
The test fail on f2fs: xattr names and values after second fsync log replay: # file: SCRATCH_MNT/foobar +user.attr1="val1" user.attr3="val3" attr1 is still there after log replay. I guess it is f2fs's special feature to improve the performance. Signed-off-by: Sun Ke --- Is

Re: [f2fs-dev] [PATCH] f2fs: move f2fs to use reader-unfair rwsems

2022-02-27 Thread Hillf Danton
On Fri, 25 Feb 2022 16:32:39 +0800 Hillf Danton wrote: > On Fri, 25 Feb 2022 09:47:16 +0800 Hillf Danton wrote: > > On Thu, 24 Feb 2022 16:47:30 +0800 Hillf Danton wrote: > > > On Sat, 8 Jan 2022 08:46:17 -0800 > > > > From: Tim Murray > > > > > > > > f2fs rw_semaphores work better if writers