Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: don't get FREEZE lock in f2fs_evict_inode in frozen fs

2022-03-10 Thread Chao Yu
On 2022/3/11 13:22, Jaegeuk Kim wrote: Let's purge inode cache in order to avoid the below deadlock. [freeze test] shrinkder freeze_super - pwercpu_down_write(SB_FREEZE_FS) - super_cache_scan

Re: [f2fs-dev] [PATCH] generic/066: attr1 is still there after log replay on f2fs

2022-03-10 Thread Sun Ke via Linux-f2fs-devel
在 2022/3/10 15:33, Chao Yu 写道: On 2022/3/10 9:41, Dave Chinner wrote: On Wed, Mar 09, 2022 at 03:34:27PM +0800, Chao Yu wrote: On 2022/3/9 14:22, Dave Chinner wrote: On Wed, Mar 09, 2022 at 12:31:17PM +0800, Chao Yu wrote: On 2022/2/28 11:57, Sun Ke via Linux-f2fs-devel wrote: The test fai

Re: [f2fs-dev] [EXT] Re: [PATCH 2/2] block: remove the per-bio/request write hint.

2022-03-10 Thread Eric Biggers
On Thu, Mar 10, 2022 at 02:18:19PM -0800, Bart Van Assche wrote: > On 3/10/22 13:52, Bean Huo (beanhuo) wrote: > > Yes, in upstream linux and upstream android, there is no such code. But as > > we know, > > mobile customers have used bio->bi_write_hint in their products for years. > > And the > >

Re: [f2fs-dev] [PATCH 1/2] f2fs: evict inode cache for frozen fs

2022-03-10 Thread Jaegeuk Kim
On 03/11, Chao Yu wrote: > Jaegeuk, > > Could you please send v2 patch to mailing list? as I saw the revised > one has been merged in dev branch. Oops, it seems I sent a wrong patch as v2. I sent it again. > > Otherwise, I've no idea where I should reply "Reviewed-by" tag to... > > Thanks, >

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: don't get FREEZE lock in f2fs_evict_inode in frozen fs

2022-03-10 Thread Jaegeuk Kim
Let's purge inode cache in order to avoid the below deadlock. [freeze test] shrinkder freeze_super - pwercpu_down_write(SB_FREEZE_FS) - super_cache_scan - down_read(&sb->s_umount)

Re: [f2fs-dev] [PATCH 1/2] f2fs: evict inode cache for frozen fs

2022-03-10 Thread Chao Yu
Jaegeuk, Could you please send v2 patch to mailing list? as I saw the revised one has been merged in dev branch. Otherwise, I've no idea where I should reply "Reviewed-by" tag to... Thanks, On 2022/3/10 9:53, Chao Yu wrote: On 2022/3/10 5:48, Jaegeuk Kim wrote: Let's purge inode cache in ord

[f2fs-dev] [PATCH] f2fs: fix to override bi_write_hint in fs-based whint_mode

2022-03-10 Thread Chao Yu
If whint_mode=fs-based, for direct write IO, it needs to override bio.bi_write_hint with the hint provided by filesystem. Fixes: 0cdd31953967 ("f2fs: support passing down write hints given by users to block layer") Cc: Hyunchul Lee Signed-off-by: Chao Yu --- fs/f2fs/f2fs.h| 1 + fs/f2fs/f

Re: [f2fs-dev] [PATCH v3] f2fs: fix compressed file start atomic write may cause data corruption

2022-03-10 Thread Chao Yu
On 2022/3/10 19:05, Fengnan Chang wrote: When compressed file has blocks, f2fs_ioc_start_atomic_write will succeed, but compressed flag will be remained in inode. If write partial compreseed cluster and commit atomic write will cause data corruption. This is the reproduction process: Step 1: cre

[f2fs-dev] [PATCH v3] f2fs: fix compressed file start atomic write may cause data corruption

2022-03-10 Thread Fengnan Chang via Linux-f2fs-devel
When compressed file has blocks, f2fs_ioc_start_atomic_write will succeed, but compressed flag will be remained in inode. If write partial compreseed cluster and commit atomic write will cause data corruption. This is the reproduction process: Step 1: create a compressed file ,write 64K data , cal

Re: [f2fs-dev] [PATCH v2] f2fs: fix compressed file start atomic write may cause data corruption

2022-03-10 Thread Chao Yu
On 2022/3/10 15:33, Fengnan Chang wrote: When compressed file has blocks, f2fs_ioc_start_atomic_write will succeed, but compressed flag will be remained in inode. If write partial compreseed cluster and commit atomic write will cause data corruption. This is the reproduction process: Step 1: cre