Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Jaegeuk Kim
On 03/23, Waiman Long wrote: > On 3/23/22 12:48, Jaegeuk Kim wrote: > > On 03/23, Christoph Hellwig wrote: > > > On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > > > > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > > In this cycle, f2fs has some performance improvement

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Jaegeuk Kim
On 03/23, Linus Torvalds wrote: > On Wed, Mar 23, 2022 at 9:26 AM Jaegeuk Kim wrote: > > > > OTOH, I was suspecting the major contetion would be > > f2fs_lock_op -> f2fs_down_read(&sbi->cp_rwsem); > > , which was used for most of filesystem operations. > > Very possible, I was just lookin

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Waiman Long
On 3/23/22 12:48, Jaegeuk Kim wrote: On 03/23, Christoph Hellwig wrote: On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: In this cycle, f2fs has some performance improvements for Android workloads such as using read-unfair rwse

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Linus Torvalds
On Wed, Mar 23, 2022 at 9:26 AM Jaegeuk Kim wrote: > > OTOH, I was suspecting the major contetion would be > f2fs_lock_op -> f2fs_down_read(&sbi->cp_rwsem); > , which was used for most of filesystem operations. Very possible, I was just looking at a random one in f2fs/file.c obviously wit

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Jaegeuk Kim
On 03/23, Christoph Hellwig wrote: > On Wed, Mar 23, 2022 at 09:48:17AM -0700, Jaegeuk Kim wrote: > > Christoph, I proposed, > > > > "I've been waiting for a generic solution as suggested here. Until then, > > I'd like > > to keep this in f2fs *only* in order to ship the fix in products. Once >

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Christoph Hellwig
On Wed, Mar 23, 2022 at 09:48:17AM -0700, Jaegeuk Kim wrote: > Christoph, I proposed, > > "I've been waiting for a generic solution as suggested here. Until then, I'd > like > to keep this in f2fs *only* in order to ship the fix in products. Once there's > a right fix, let me drop or revise this

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Jaegeuk Kim
On 03/23, Christoph Hellwig wrote: > On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > > > In this cycle, f2fs has some performance improvements for Android > > > workloads such > > > as using read-unfair rwsems [...] >

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Jaegeuk Kim
On 03/22, Linus Torvalds wrote: > On Tue, Mar 22, 2022 at 5:34 PM Tim Murray wrote: > > > > AFAICT, what's happening is that rwsem_down_read_slowpath > > modifies sem->count to indicate that there's a pending reader while > > f2fs_ckpt holds the write lock, and when f2fs_ckpt releases the write >

[f2fs-dev] [PATCH v3] generic/066: attr1 is still there after log replay on f2fs

2022-03-23 Thread Sun Ke via Linux-f2fs-devel
The test fail on f2fs: xattr names and values after second fsync log replay: # file: SCRATCH_MNT/foobar +user.attr1="val1" user.attr3="val3" attr1 is still there after log replay. f2fs doesn't support fs-op level transaction functionality. so it have no way to persist all metada

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-03-23 Thread Christoph Hellwig
On Tue, Mar 22, 2022 at 10:22:50AM -0700, Linus Torvalds wrote: > On Mon, Mar 21, 2022 at 1:39 PM Jaegeuk Kim wrote: > > > > In this cycle, f2fs has some performance improvements for Android workloads > > such > > as using read-unfair rwsems [...] > > I've pulled this, but that read-unfair rwsem