Since pvec have 15 pages, it not a multiple of 4, when write compressed
pages, write in 64K as a unit, it will call pagevec_lookup_range_tag
agagin, sometimes this will take a lot of time.
Use onstack pages instead of pvec to mitigate this problem.
Signed-off-by: Fengnan Chang
---
fs/f2fs/compre
https://bugzilla.kernel.org/show_bug.cgi?id=215916
Bug ID: 215916
Summary: kernel BUG at fs/f2fs/segment.c:2560!
Product: File System
Version: 2.5
Kernel Version: 5.17
Hardware: All
OS: Linux
Tree: Mainline
Hi Gabriel,
I love your patch! Yet something to improve:
[auto build test ERROR on tytso-ext4/dev]
[also build test ERROR on jaegeuk-f2fs/dev-test linus/master v5.18-rc4
next-20220428]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest
Matching case-insensitive names is a generic operation and can be shared
with f2fs. Move it next to the rest of the shared casefold fs code.
Signed-off-by: Gabriel Krisman Bertazi
---
fs/ext4/namei.c| 62 +-
fs/libfs.c | 60 +++
ext4_ci_compare originally follows utf8_*_strcmp, which means return
zero on match. This means that every usage of that in ext4 negates
the return.
Turn it into a predicate function, let it follow the kernel convention
and return true on match, which means it's now the same as its f2fs
counterpar
If the volume is in strict mode, ext4_ci_compare can report a broken
encoding name. This will not trigger on a bad lookup, which is caught
earlier, only if the actual disk name is bad.
Signed-off-by: Gabriel Krisman Bertazi
---
Changes since v1:
- reword error message "file in directory" ->
Now that ci_match is part of libfs, make f2fs reuse it instead of having
a different implementation.
Signed-off-by: Gabriel Krisman Bertazi
---
fs/f2fs/dir.c | 58 ---
1 file changed, 4 insertions(+), 54 deletions(-)
diff --git a/fs/f2fs/dir.c b/f
Keeping it as qstr avoids the unnecessary conversion in ext4_match
Signed-off-by: Gabriel Krisman Bertazi
--
Changes since v1:
- Simplify hunk (eric)
---
fs/ext4/ext4.h | 2 +-
fs/ext4/namei.c | 22 +++---
2 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/fs/e
The existence of fname->cf_name.name requires s_encoding & IS_CASEFOLDED,
therefore this can be simplified.
Signed-off-by: Gabriel Krisman Bertazi
---
fs/ext4/namei.c | 18 ++
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
index 5
This is the v2 of this series. it applies Eric's comments and extend
the series to complete the merge of generic_ci_match for ext4 and f2fs.
The case-insensitive implementations in f2fs and ext4 have quite a bit
of duplicated code. This series simplifies the ext4 version, with the
goal of extrac
By using a new type here, we can hide most of the caching casefold logic
from ext4. The condition in ext4_match is now quite redundant, but this
is addressed in the next patch.
This doesn't use ext4_filename to keep it generic, since the function
will be moved to libfs to be shared with f2fs.
Si
On Fri, Apr 29, 2022 at 06:43:58AM +0900, Damien Le Moal wrote:
> On 4/29/22 02:34, Luis Chamberlain wrote:
> > One step at a time.
>
> Yes, in general, I agree. But in this case, that will create kernel
> versions that end up having partial support for zoned drives. Not ideal to
> say the least.
On 4/29/22 02:34, Luis Chamberlain wrote:
> On Thu, Apr 28, 2022 at 08:42:41AM +0900, Damien Le Moal wrote:
>> On 4/28/22 01:02, Pankaj Raghav wrote:
>>> From: Luis Chamberlain
>>>
>>> Today dm-zoned relies on the assumption that you have a zone size
>>> with a power of 2. Even though the block la
From: Daeho Jeong
Current atomic write has three major issues like below.
- keeps the updates in non-reclaimable memory space and they are even
hard to be migrated, which is not good for contiguous memory
allocation.
- disk spaces used for atomic files cannot be garbage collected, so
t
On Thu, Apr 28, 2022 at 08:42:41AM +0900, Damien Le Moal wrote:
> On 4/28/22 01:02, Pankaj Raghav wrote:
> > From: Luis Chamberlain
> >
> > Today dm-zoned relies on the assumption that you have a zone size
> > with a power of 2. Even though the block layer today enforces this
> > requirement, the
On Thu, Apr 28, 2022 at 08:37:27AM +0900, Damien Le Moal wrote:
> Also, the entire premise of this patch series is that it is hard for
> people to support the unusable sectors between zone capacity and zone end
> for drives with a zone capacity smaller than the zone size.
>
> Yet, here you do not
https://bugzilla.kernel.org/show_bug.cgi?id=215914
Bug ID: 215914
Summary: kernel hangs after mounting the image
Product: File System
Version: 2.5
Kernel Version: 5.17
Hardware: All
OS: Linux
Tree: Mainline
https://bugzilla.kernel.org/show_bug.cgi?id=215897
Chao Yu ([email protected]) changed:
What|Removed |Added
Status|NEW |RESOLVED
CC|
https://bugzilla.kernel.org/show_bug.cgi?id=215895
Chao Yu ([email protected]) changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
https://bugzilla.kernel.org/show_bug.cgi?id=215657
Chao Yu ([email protected]) changed:
What|Removed |Added
Status|ASSIGNED|RESOLVED
Resolution|-
https://bugzilla.kernel.org/show_bug.cgi?id=215894
Chao Yu ([email protected]) changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|-
https://bugzilla.kernel.org/show_bug.cgi?id=215894
Chao Yu ([email protected]) changed:
What|Removed |Added
CC||[email protected]
--- Comment #
22 matches
Mail list logo
