Re: [f2fs-dev] [PATCH v3] dump.f2fs: add -I nid to dump inode by scan full disk

2022-06-14 Thread Yufen Yu via Linux-f2fs-devel
gentry ping... On 2022/6/7 11:40, Yufen Yu wrote: Usage: dump.f2fs -I [inode nid] /dev/sda This feature can be useful for some bugs caused by system crash. We not only need dump current valid node page, but alse the history data in disk, which can give some clues for status change of

[f2fs-dev] [PATCH 1/3] Fix the struct f2fs_dentry_block size check

2022-06-14 Thread Bart Van Assche
Fix the f2fs-tools build on systems for which PAGE_SIZE != 4096. Cc: Peter Collingbourne Reported-by: Peter Collingbourne Signed-off-by: Bart Van Assche --- include/f2fs_fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/f2fs_fs.h b/include/f2fs_fs.h index

[f2fs-dev] [PATCH 0/3] Three f2fs patches

2022-06-14 Thread Bart Van Assche
Hi Jaegeuk, This patch series fixes one issue reported by Peter Collingbourne and two issues I discovered by reading the zoned block device source code. Please consider these patches for inclusion in the official f2fs-tools repository. Thanks, Bart. Bart Van Assche (3): Fix the struct

[f2fs-dev] [PATCH 2/3] Fix f2fs_report_zone()

2022-06-14 Thread Bart Van Assche
The definition of struct blk_zone_report is as follows: struct blk_zone_report { __u64 sector; __u32 nr_zones; __u32 flags; struct blk_zone zones[0]; }; Since f2fs_report_zone()

[f2fs-dev] [PATCH 3/3] Improve compile-time type checking for f2fs_report_zone()

2022-06-14 Thread Bart Van Assche
Change the type of the third argument of f2fs_report_zone() from void * into struct blk_zone * to enable type checking. Signed-off-by: Bart Van Assche --- include/f2fs_fs.h | 4 +++- lib/libf2fs_zoned.c | 22 +- 2 files changed, 16 insertions(+), 10 deletions(-) diff

[f2fs-dev] [linux-next:master] BUILD REGRESSION 35d872b9ea5b3ad784d7479ea728dcb688df2db7

2022-06-14 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 35d872b9ea5b3ad784d7479ea728dcb688df2db7 Add linux-next specific files for 20220614 Error/Warning: (recently discovered and may have been fixed) drivers/gpu/drm/amd/amdgpu/../display/include

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Gao Xiang
On Tue, Jun 14, 2022 at 10:49:37AM -0700, Daeho Jeong wrote: > > Yeah, I heard that you folks are really suffered from the scheduling > > issues. But for my own previous experience, extra memory footprints are > > really critical in Android low memory scenarios (no matter low-ended > > devices or

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Daeho Jeong
> Yeah, I heard that you folks are really suffered from the scheduling > issues. But for my own previous experience, extra memory footprints are > really critical in Android low memory scenarios (no matter low-ended > devices or artificial workloads), it tossed me a lot. So I finally > ntroduced

[f2fs-dev] [PATCH] f2fs: fix stubs when F2FS_FS_COMPRESSION is not enabled

2022-06-14 Thread Randy Dunlap
Fix build errors when F2FS_FS_COMPRESSION is not set: ../fs/f2fs/data.c: In function ‘f2fs_finish_read_bio’: ../fs/f2fs/data.c:136:5: error: too many arguments to function ‘f2fs_end_read_compressed_page’ f2fs_end_read_compressed_page(page, true, 0, ^ In file

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Gao Xiang
Hi Daeho, On Tue, Jun 14, 2022 at 09:46:50AM -0700, Daeho Jeong wrote: > > > > Some my own previous thoughts about this strategy: > > > > - If we allocate all memory and map these before I/Os, all inflight I/Os > >will keep such temporary pages all the time until decompression is > >

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Daeho Jeong
> > Some my own previous thoughts about this strategy: > > - If we allocate all memory and map these before I/Os, all inflight I/Os >will keep such temporary pages all the time until decompression is >finished. In contrast, if we allocate or reuse such pages just before >

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Daeho Jeong
> One question: is this (the bio endio callback) actually guaranteed to be > executed from a softirq? If you look at dm-crypt's support for workqueue-less > decryption, for example, it explicitly checks 'in_hardirq() || > irqs_disabled()' > and schedules a tasklet if either of those is the case.

[f2fs-dev] [PATCH 1/2] resize.f2fs: add option to manually specify new overprovision

2022-06-14 Thread qixiaoyu1
From: liuchao12 Make.f2fs supports manually specifying overprovision, and we expect resize.f2fs to support it as well. This change add a new '-o' option to manually specify overprovision. Signed-off-by: liuchao12 --- fsck/main.c | 8 ++-- fsck/resize.c | 12 ++-- 2 files

[f2fs-dev] [PATCH 2/2] f2fs-tools: fix to check free space before grow

2022-06-14 Thread qixiaoyu1
Otherwise, after grow, kernel may report below error message when we mount the image if -o parameter is specified during resize: F2FS-fs (loop0): invalid crc_offset: 0 F2FS-fs (loop0): Wrong valid_user_blocks: 16404, user_block_count: 13312 F2FS-fs (loop0): Failed to get valid F2FS checkpoint

Re: [f2fs-dev] [PATCH] f2fs: handle decompress only post processing in softirq

2022-06-14 Thread Gao Xiang
Hi all, On Mon, Jun 13, 2022 at 10:38:25PM -0700, Eric Biggers wrote: > [+Cc Nathan Huckleberry who is looking into a similar problem in dm-verity] > > On Mon, Jun 13, 2022 at 08:56:12AM -0700, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Now decompression is being handled in workqueue and