Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-06-15 Thread Christoph Hellwig
On Wed, Jun 15, 2022 at 11:19:32PM -0700, Eric Biggers wrote: > Yes I know that. The issue is that the inode that statx() is operating on is > the device node, so *all* the other statx fields come from that inode. Size, > nlink, uid, gid, mode, timestamps (including btime if the filesystem suppor

Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-06-15 Thread Eric Biggers
On Wed, Jun 15, 2022 at 11:07:17PM -0700, Christoph Hellwig wrote: > On Wed, Jun 15, 2022 at 05:04:57PM -0700, Eric Biggers wrote: > > One more thing. I'm trying to add support for STATX_DIOALIGN on block > > devices. > > Unfortunately I don't think it is going to work, at all, since the inode is

Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-06-15 Thread Christoph Hellwig
On Wed, Jun 15, 2022 at 05:04:57PM -0700, Eric Biggers wrote: > One more thing. I'm trying to add support for STATX_DIOALIGN on block > devices. > Unfortunately I don't think it is going to work, at all, since the inode is > for > the device node and not the block device itself. This is true ev

[f2fs-dev] [PATCH] Fix file too large causing overflow

2022-06-15 Thread Dylan Chang
fibmap: Fix file too large causing file_pos overflow fibmap show file_pos with incorrectly value when passing a large file. Before: file info--- /data/media/0/data1 : dev [254:18] ino [0x4db1 : 19889] mo

Re: [f2fs-dev] [PATCH v3] dump.f2fs: add -I nid to dump inode by scan full disk

2022-06-15 Thread Chao Yu
On 2022/6/7 11:40, Yufen Yu wrote: Usage: dump.f2fs -I [inode nid] /dev/sda This feature can be useful for some bugs caused by system crash. We not only need dump current valid node page, but alse the history data in disk, which can give some clues for status change of the inode. Signed

Re: [f2fs-dev] [PATCH] f2fs: fix iostat related lock protection

2022-06-15 Thread Chao Yu
On 2022/6/16 0:54, Jaegeuk Kim wrote: On 06/15, Chao Yu wrote: On 2022/6/11 2:32, Daeho Jeong wrote: From: Daeho Jeong Made iostat related locks safe to be called from irq context again. Will be better to add a 'Fixes' line? Added some tags. Thanks, https://git.kernel.org/pub/scm/linux/

Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-06-15 Thread Eric Biggers
On Wed, Jun 15, 2022 at 06:12:04AM -0700, Christoph Hellwig wrote: > On Mon, Jun 13, 2022 at 10:25:12PM -0700, Eric Biggers wrote: > > While working on the man-pages update, I'm having second thoughts about the > > stx_offset_align_optimal field. Does any filesystem other than XFS actually > > wan

Re: [f2fs-dev] [GIT PULL] f2fs for 5.18

2022-06-15 Thread Pavel Machek
Hi! > > > AFAICS, the read-unfair rwsem code is created to resolve a potential > > > lock starvation problem that they found on linux-5.10.y stable tree. I > > > believe I have fixed that in the v5.11 kernel, see commit 2f06f702925 > > > ("locking/rwsem: Prevent potential lock starvation"). > > >

Re: [f2fs-dev] [PATCH 0/3] Three f2fs patches

2022-06-15 Thread Jaegeuk Kim
Thanks, merged. On 06/14, Bart Van Assche wrote: > Hi Jaegeuk, > > This patch series fixes one issue reported by Peter Collingbourne and two > issues I discovered by reading the zoned block device source code. Please > consider these patches for inclusion in the official f2fs-tools repository. >

Re: [f2fs-dev] [PATCH v3] dump.f2fs: add -I nid to dump inode by scan full disk

2022-06-15 Thread Jaegeuk Kim
On 06/15, Yufen Yu via Linux-f2fs-devel wrote: > gentry ping... Thanks, merged. > > On 2022/6/7 11:40, Yufen Yu wrote: > > Usage: > > dump.f2fs -I [inode nid] /dev/sda > > > > This feature can be useful for some bugs caused by system crash. > > We not only need dump current valid node page,

[f2fs-dev] [PATCH 1/2] android_config: add time headers

2022-06-15 Thread Jaegeuk Kim
This allows f2fs_io report latency. Signed-off-by: Jaegeuk Kim --- include/android_config.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/android_config.h b/include/android_config.h index 21eed28669e1..67e5d5871bf8 100644 --- a/include/android_config.h +++ b/include/android_confi

[f2fs-dev] [PATCH 2/2] f2fs_io: add dsync option for write

2022-06-15 Thread Jaegeuk Kim
Signed-off-by: Jaegeuk Kim --- tools/f2fs_io/f2fs_io.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/f2fs_io/f2fs_io.c b/tools/f2fs_io/f2fs_io.c index 2f0fc7b25d41..e7359836b126 100644 --- a/tools/f2fs_io/f2fs_io.c +++ b/tools/f2fs_io/f2fs_io.c @@ -508,7 +508,8 @@

Re: [f2fs-dev] [PATCH] f2fs: fix iostat related lock protection

2022-06-15 Thread Jaegeuk Kim
On 06/15, Chao Yu wrote: > On 2022/6/11 2:32, Daeho Jeong wrote: > > From: Daeho Jeong > > > > Made iostat related locks safe to be called from irq context again. > > > > Will be better to add a 'Fixes' line? Added some tags. Thanks, https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2f

Re: [f2fs-dev] [PATCH -next] f2fs: fix build error too many arguments to functions

2022-06-15 Thread Jaegeuk Kim
Thanks, but I deqeued the buggy patch, so expect to get the right change later. On 06/15, Ren Zhijie wrote: > If CONFIG_F2FS_FS_COMPRESSION is not set. > > make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: > fs/f2fs/data.c: In function ‘f2fs_finish_read_bio’: > fs/f2fs/

Re: [f2fs-dev] [PATCH -next] f2fs: fix build error too many arguments to functions

2022-06-15 Thread kernel test robot
Hi Ren, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20220615] url: https://github.com/intel-lab-lkp/linux/commits/Ren-Zhijie/f2fs-fix-build-error-too-many-arguments-to-functions/20220615-150808 base:6012273897fefb12566580efedee10bb06e5e6ed config

Re: [f2fs-dev] [RFC PATCH v2 1/7] statx: add I/O alignment information

2022-06-15 Thread Christoph Hellwig
On Mon, Jun 13, 2022 at 10:25:12PM -0700, Eric Biggers wrote: > While working on the man-pages update, I'm having second thoughts about the > stx_offset_align_optimal field. Does any filesystem other than XFS actually > want stx_offset_align_optimal, when st[x]_blksize already exists? Many > net

Re: [f2fs-dev] [PATCH 05/10] f2fs: Convert f2fs_invalidate_compress_pages() to use filemap_get_folios()

2022-06-15 Thread Chao Yu
On 2022/6/6 3:38, Matthew Wilcox (Oracle) wrote: Convert this function to use folios throughout. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] https://li

Re: [f2fs-dev] [PATCH v2 14/19] f2fs: Convert to filemap_migrate_folio()

2022-06-15 Thread Chao Yu
On 2022/6/8 23:02, Matthew Wilcox (Oracle) wrote: filemap_migrate_folio() fits f2fs's needs perfectly. Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list [email protected] http

Re: [f2fs-dev] [PATCH] f2fs: fix iostat related lock protection

2022-06-15 Thread Chao Yu
On 2022/6/11 2:32, Daeho Jeong wrote: From: Daeho Jeong Made iostat related locks safe to be called from irq context again. Will be better to add a 'Fixes' line? Thanks, Signed-off-by: Daeho Jeong --- fs/f2fs/iostat.c | 31 ++- 1 file changed, 18 insertions

[f2fs-dev] [PATCH -next] f2fs: fix build error too many arguments to functions

2022-06-15 Thread Ren Zhijie via Linux-f2fs-devel
If CONFIG_F2FS_FS_COMPRESSION is not set. make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-, will be failed, like this: fs/f2fs/data.c: In function ‘f2fs_finish_read_bio’: fs/f2fs/data.c:136:5: error: too many arguments to function ‘f2fs_end_read_compressed_page’ f2fs_end_read_compressed_page