Re: [f2fs-dev] [PATCH v3 14/23] f2fs: Convert f2fs_write_cache_pages() to use filemap_get_folios_tag()

2022-11-29 Thread Matthew Wilcox
On Mon, Nov 14, 2022 at 03:02:34PM +0800, Chao Yu wrote: > On 2022/10/18 4:24, Vishal Moola (Oracle) wrote: > > Converted the function to use a folio_batch instead of pagevec. This is in > > preparation for the removal of find_get_pages_range_tag(). > > > > Also modified

Re: [f2fs-dev] [xfstests-bld PATCH] test_appliance: add f2fs/compress config

2022-11-29 Thread Jaegeuk Kim
On 11/28, Eric Biggers wrote: > From: Eric Biggers > > Add a f2fs/compress configuration which causes all files to be > automatically compressed, similar to how f2fs/encrypt causes all files > to be automatically encrypted. > > Signed-off-by: Eric Biggers Acked-by: Jaegeuk Kim Thanks, :) >

Re: [f2fs-dev] [PATCH v4] fsverity: stop using PG_error to track error status

2022-11-29 Thread Jaegeuk Kim
On 11/28, Eric Biggers wrote: > On Mon, Nov 28, 2022 at 10:48:41PM -0800, Jaegeuk Kim wrote: > > > static void f2fs_finish_read_bio(struct bio *bio, bool in_task) > > > { > > > struct bio_vec *bv; > > > struct bvec_iter_all iter_all; > > > + struct bio_post_read_ctx *ctx = bio->bi_private; >

[f2fs-dev] [PATCH] f2fs: issue discard when discard_cmd_cnt is not 0 in f2fs_put_super()

2022-11-29 Thread Yangtao Li via Linux-f2fs-devel
No need to call f2fs_issue_discard_timeout() in f2fs_put_super, when no discard command requires issue. Since the caller of f2fs_issue_discard_timeout() usually judges the number of discard commands before using it. Let's move this logic to f2fs_issue_discard_timeout(). By the way, use

[f2fs-dev] [PATCH] f2fs: judge whether discard_unit is section only when have CONFIG_BLK_DEV_ZONED

2022-11-29 Thread Yangtao Li via Linux-f2fs-devel
The current logic, regardless of whether CONFIG_BLK_DEV_ZONED is enabled or not, will judge whether discard_unit is SECTION, when f2fs_sb_has_blkzoned. In fact, when CONFIG_BLK_DEV_ZONED is not enabled, this judgment is a path that will never be accessed. At this time, -EINVAL will be returned in