Re: [f2fs-dev] [PATCH v2 00/11] fsverity: support for non-4K pages

2023-02-03 Thread Eric Biggers
On Fri, Dec 23, 2022 at 12:36:27PM -0800, Eric Biggers wrote: > ext4: simplify ext4_readpage_limit() > f2fs: simplify f2fs_readpage_limit() > fs/buffer.c: support fsverity in block_read_full_folio() > ext4: allow verity with fs block size < PAGE_SIZE I'd still appreciate acks from the othe

[f2fs-dev] [PATCH v2 7/7] f2fs: Enable negative dentries on case-insensitive lookup

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Instead of invalidating negative dentries during case-insensitive lookups, mark them as such and let them be added to the dcache. d_ci_revalidate is able to properly filter them out if necessary based on the dentry casefold flag. Signed-off-by: Gabriel Krisman Berta

[f2fs-dev] [PATCH v2 0/7] Support negative dentries on case-insensitive ext4 and f2fs

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel krisman Bertazi This patchset enables negative dentries for case-insensitive directories in ext4/f2fs. It solves the corner cases for this feature, including those already tested by fstests (generic/556). It also solves an existing bug with the existing implementation where old ne

[f2fs-dev] [PATCH v2 3/7] libfs: Validate negative dentries in case-insensitive directories

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Introduce a dentry revalidation helper to be used by case-insensitive filesystems to check if it is safe to reuse a negative dentry. A negative dentry is safe to be reused on a case-insensitive lookup if it was created during a case-insensitive lookup and this is no

[f2fs-dev] [PATCH v2 4/7] libfs: Support revalidation of encrypted case-insensitive dentries

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Preserve the existing behavior for encrypted directories, by rejecting negative dentries of encrypted+casefolded directories. This allows generic_ci_d_revalidate to be used by filesystems with both features enabled, as long as the directory is either casefolded or e

[f2fs-dev] [PATCH v2 5/7] libfs: Merge encrypted_ci_dentry_ops and ci_dentry_ops

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Now that casefold needs d_revalidate and calls fscrypt_d_revalidate itself, generic_encrypt_ci_dentry_ops and generic_ci_dentry_ops are now equivalent. Merge them together and simplify the setup code. Signed-off-by: Gabriel Krisman Bertazi --- fs/libfs.c | 44 +++

[f2fs-dev] [PATCH v2 1/7] fs: Expose name under lookup to d_revalidate hook

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Negative dentries support on case-insensitive ext4/f2fs will require access to the name under lookup to ensure it matches the dentry. This adds an optional new flavor of cached dentry revalidation hook to expose this extra parameter. I'm fine with extending d_reval

[f2fs-dev] [PATCH v2 6/7] ext4: Enable negative dentries on case-insensitive lookup

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi Instead of invalidating negative dentries during case-insensitive lookups, mark them as such and let them be added to the dcache. d_ci_revalidate is able to properly filter them out if necessary based on the dentry casefold flag. Signed-off-by: Gabriel Krisman Berta

[f2fs-dev] [PATCH v2 2/7] fs: Add DCACHE_CASEFOLD_LOOKUP flag

2023-02-03 Thread Gabriel Krisman Bertazi
From: Gabriel Krisman Bertazi This flag marks a negative or positive dentry as being created after a case-insensitive lookup operation. It is useful to differentiate dentries this way to detect whether the negative dentry can be trusted during a case-insensitive lookup. Signed-off-by: Gabriel K

[f2fs-dev] KASAN: slab-out-of-bounds Read in f2fs_iget

2023-02-03 Thread Sanan Hasanov
Good day, dear maintainers, We found a bug using a modified kernel configuration file used by syzbot. We enhanced the coverage of the configuration file using our tool, klocalizer. Kernel Branch: 6.2.0-rc6-next-20230201 Kernel config:  https://drive.google.com/file/d/17UnUG1E5HyCPGz_HN8--CTXXxSH

Re: [f2fs-dev] [PATCH] f2fs: fix cgroup writeback accounting with fs-layer encryption

2023-02-03 Thread Tejun Heo
On Thu, Feb 02, 2023 at 05:02:39PM -0800, Eric Biggers wrote: > From: Eric Biggers > > When writing a page from an encrypted file that is using > filesystem-layer encryption (not inline encryption), f2fs encrypts the > pagecache page into a bounce page, then writes the bounce page. > > It also p

Re: [f2fs-dev] [PATCH v3 2/3] f2fs: add missing description for ipu_policy node

2023-02-03 Thread Chao Yu
On 2023/2/2 16:48, Yangtao Li wrote: IPU policy can be disabled, let's add description for it and other policy. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https

Re: [f2fs-dev] [PATCH v3 1/3] f2fs: fix to set ipu policy

2023-02-03 Thread Chao Yu
On 2023/2/2 16:48, Yangtao Li wrote: For LFS mode, it should update outplace and no need inplace update. When using LFS mode for small-volume devices, IPU will not be used, and the OPU writing method is actually used, but F2FS_IPU_FORCE can be read from the ipu_policy node, which is different fro

Re: [f2fs-dev] [PATCH] f2fs: fix cgroup writeback accounting with fs-layer encryption

2023-02-03 Thread Chao Yu
On 2023/2/3 9:02, Eric Biggers wrote: From: Eric Biggers When writing a page from an encrypted file that is using filesystem-layer encryption (not inline encryption), f2fs encrypts the pagecache page into a bounce page, then writes the bounce page. It also passes the bounce page to wbc_account

Re: [f2fs-dev] [PATCH 2/2 v3] f2fs: add sysfs nodes to set last_age_weight

2023-02-03 Thread Chao Yu
On 2023/2/2 16:20, qixiaoyu1 wrote: Signed-off-by: qixiaoyu1 Signed-off-by: xiongping1 --- Documentation/ABI/testing/sysfs-fs-f2fs | 5 + fs/f2fs/extent_cache.c | 15 +-- fs/f2fs/f2fs.h | 1 + fs/f2fs/sysfs.c