Re: [f2fs-dev] [PATCH -next] f2fs: make f2fs_sync_inode_meta() static

2023-03-06 Thread Chao Yu
On 2023/2/23 9:25, Li Zetao wrote: After commit 26b5a079197c ("f2fs: cleanup dirty pages if recover failed"), f2fs_sync_inode_meta() is only used in checkpoint.c, so f2fs_sync_inode_meta() should only be visible inside. Delete the declaration in the header file and change f2fs_sync_inode_meta()

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Chao Yu
On 2023/3/6 20:25, Douglas RAILLARD wrote: From: Douglas Raillard Fix the nid_t field so that its size is correctly reported in the text format embedded in trace.dat files. As it stands, it is reported as being of size 4: field:nid_t nid[3]; offset:24; size:4; signed:0;

Re: [f2fs-dev] [PATCH v2] f2fs: fix uninitialized skipped_gc_rwsem

2023-03-06 Thread Jaegeuk Kim
On 02/16, Yonggil Song wrote: > When f2fs skipped a gc round during victim migration, there was a bug which > would skip all upcoming gc rounds unconditionally because skipped_gc_rwsem > was not initialized. It fixes the bug by correctly initializing the > skipped_gc_rwsem inside the gc loop. > >

Re: [f2fs-dev] [PATCH] f2fs: fix to check quota inums

2023-03-06 Thread Jaegeuk Kim
On 02/23, Yangtao Li wrote: > We should check quota file ino before enable quota, and not only 0. > > BTW fix following check error: > > WARNING: Do not crash the kernel unless it is absolutely > unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) > instead of BUG() or variants. >

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Steven Rostedt
On Mon, 6 Mar 2023 11:15:13 -0500 Steven Rostedt wrote: > > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > > index 31d994e6b4ca..8d053838d6cf 100644 > > --- a/include/trace/events/f2fs.h > > +++ b/include/trace/events/f2fs.h > > @@ -512,7 +512,7 @@

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Steven Rostedt
On Mon, 6 Mar 2023 12:25:49 + Douglas RAILLARD wrote: > diff --git a/include/trace/events/f2fs.h b/include/trace/events/f2fs.h > index 31d994e6b4ca..8d053838d6cf 100644 > --- a/include/trace/events/f2fs.h > +++ b/include/trace/events/f2fs.h > @@ -512,7 +512,7 @@

Re: [f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Mukesh Ojha
On 3/6/2023 5:55 PM, Douglas RAILLARD wrote: From: Douglas Raillard Fix the nid_t field so that its size is correctly reported in the text format embedded in trace.dat files. As it stands, it is reported as being of size 4: field:nid_t nid[3]; offset:24; size:4; signed:0;

[f2fs-dev] [PATCH] f2fs: Fix f2fs_truncate_partial_nodes ftrace event

2023-03-06 Thread Douglas RAILLARD
From: Douglas Raillard Fix the nid_t field so that its size is correctly reported in the text format embedded in trace.dat files. As it stands, it is reported as being of size 4: field:nid_t nid[3]; offset:24; size:4; signed:0; Instead of 12: field:nid_t nid[3];

Re: [f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
On Wed, Feb 01, 2023 at 02:42:54PM +0100, Christian Brauner wrote: > On Wed, Feb 01, 2023 at 02:30:20PM +0100, Christoph Hellwig wrote: > > This version looks good to me, but I'd really prefer if a reiserfs > > insider could look over the reiserfs patches. > > I consider this material for v6.4

Re: [f2fs-dev] [PATCH v3 00/10] acl: drop posix acl handlers from xattr handlers

2023-03-06 Thread Christian Brauner
From: Christian Brauner (Microsoft) On Wed, 01 Feb 2023 14:14:51 +0100, Christian Brauner wrote: > Hey everyone, > > After we finished the introduction of the new posix acl api last cycle > we still left the generic POSIX ACL xattr handlers around in the > filesystems xattr handlers for two