Re: [f2fs-dev] [PATCH v2] f2fs: refactor struct f2fs_attr macro

On 2023/4/15 23:29, Yangtao Li wrote: This patch provides a large number of variants of F2FS_RW_ATTR and F2FS_RO_ATTR macros, reducing the number of parameters required to initialize the f2fs_attr structure. Reported-by: kernel test robot Link:

Re: [f2fs-dev] [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 2023/4/18 14:09, Qi Han wrote: This comment make no sense and is in the wrong place, so let's remove it. Signed-off-by: Qi Han --- fs/f2fs/extent_cache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c index 28b12553f2b3..1f6d7de35794

Re: [f2fs-dev] [PATCH] f2fs: allocate node blocks for atomic write block replacement

On 2023/4/19 1:42, Daeho Jeong wrote: From: Daeho Jeong When a node block is missing for atomic write block replacement, we need to allocate it in advance of the replacement. Miss a fixes line? Otherwise it looks good to me. Thanks, Signed-off-by: Daeho Jeong --- fs/f2fs/segment.c |

Re: [f2fs-dev] [PATCH] f2fs: use cow inode data when updating atomic write

On 2023/4/19 1:52, Daeho Jeong wrote: From: Daeho Jeong Need to use cow inode data content instead of the one in the original inode, when we try to write the already updated atomic write files. Miss a fixes line? Otherwise it looks good to me. Thanks Signed-off-by: Daeho Jeong ---

Re: [f2fs-dev] [PATCH v2] f2fs: remove power-of-two limitation fo zoned device

On 2023/4/18 23:55, Jaegeuk Kim wrote: In f2fs, there's no reason to force po2. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

[f2fs-dev] [PATCH] f2fs: compress: fix to check validity of i_compress_flag field

The last valid compress related field is i_compress_flag, check its validity instead of i_log_cluster_size. Signed-off-by: Chao Yu --- fs/f2fs/inode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index cf4327ad106c..516d5dd8f976

Re: [f2fs-dev] [PATCH v8] f2fs: support errors=remount-ro|continue|panic mountoption

On 2023/4/21 0:34, Jaegeuk Kim wrote: On 04/20, Chao Yu wrote: On 2023/4/20 4:19, Jaegeuk Kim wrote: On 04/08, Chao Yu wrote: This patch supports errors=remount-ro|continue|panic mount option, by default it uses "remount-ro" mode. Signed-off-by: Chao Yu Signed-off-by: Yangtao Li --- v8: -

Re: [f2fs-dev] [DISCUSSION] f2fs for desktop

Hi Chao, On Fri, Apr 21, 2023 at 1:19 AM Chao Yu wrote: > > Hi JuHyung, > > Sorry for delay reply. > > On 2023/4/11 1:03, Juhyung Park wrote: > > Hi Chao, > > > > On Tue, Apr 11, 2023 at 12:44 AM Chao Yu wrote: > >> > >> Hi Juhyung, > >> > >> On 2023/4/4 15:36, Juhyung Park wrote: > >>> Hi

Re: [f2fs-dev] [PATCH] fsck.f2fs: fix sanity check logic for cp_payload

On Fri, Apr 21, 2023 at 1:06 AM Chao Yu wrote: > > On 2023/4/4 13:54, Juhyung Park wrote: > > cp_payload is set differently [1] when extended node bitmap feature is > > enabled. Commit b79c3ba4ea9d broke fsck on f2fs file systems created on > > 2+ TB device with extended node bitmap feature

Re: [f2fs-dev] [PATCH v8] f2fs: support errors=remount-ro|continue|panic mountoption

On 04/20, Chao Yu wrote: > On 2023/4/20 4:19, Jaegeuk Kim wrote: > > On 04/08, Chao Yu wrote: > > > This patch supports errors=remount-ro|continue|panic mount option, > > > by default it uses "remount-ro" mode. > > > > > > Signed-off-by: Chao Yu > > > Signed-off-by: Yangtao Li > > > --- > > >

Re: [f2fs-dev] [DISCUSSION] f2fs for desktop

Hi JuHyung, Sorry for delay reply. On 2023/4/11 1:03, Juhyung Park wrote: Hi Chao, On Tue, Apr 11, 2023 at 12:44 AM Chao Yu wrote: Hi Juhyung, On 2023/4/4 15:36, Juhyung Park wrote: Hi everyone, I want to start a discussion on using f2fs for regular desktops/workstations. There are

Re: [f2fs-dev] [PATCH] fsck.f2fs: fix sanity check logic for cp_payload

On 2023/4/4 13:54, Juhyung Park wrote: cp_payload is set differently [1] when extended node bitmap feature is enabled. Commit b79c3ba4ea9d broke fsck on f2fs file systems created on 2+ TB device with extended node bitmap feature enabled. As the sanity check is for checking overflows, fix this

[f2fs-dev] [PATCH v9] f2fs: support errors=remount-ro|continue|panic mountoption

This patch supports errors=remount-ro|continue|panic mount option, by default it uses "continue" mode. Signed-off-by: Yangtao Li Signed-off-by: Chao Yu --- v9: - use continue mode by default. Documentation/filesystems/f2fs.rst | 5 ++ fs/f2fs/checkpoint.c | 7 +-

Re: [f2fs-dev] [PATCH v8] f2fs: support errors=remount-ro|continue|panic mountoption

On 2023/4/20 4:19, Jaegeuk Kim wrote: On 04/08, Chao Yu wrote: This patch supports errors=remount-ro|continue|panic mount option, by default it uses "remount-ro" mode. Signed-off-by: Chao Yu Signed-off-by: Yangtao Li --- v8: - record stop reason synchronously if it's from ioctl shutdown

Re: [f2fs-dev] (2) [PATCH] f2fs: add async reset zone command support

Hi Jeageuk, Thanks for helpful review. > > On 04/14, Daejun Park wrote: > > This patch enables submit reset zone command asynchornously. It helps > > decrease average latency of write IOs in high utilization scenario by > > faster checkpointing. > > > > Signed-off-by: Daejun Park > > --- > >  

[f2fs-dev] [PATCH v6] f2fs: support FAULT_LOCK type fault injection

Similar to FAULT_LOCK_OP, this patch supports to inject fault into variant of _trylock(), including: - inode_trylock - down_read_trylock - down_write_trylock - mutex_trylock - sb_start_write_trylock - trylock_page Usage: a) echo 524288 > /sys/fs/f2fs//inject_type or b) mount -o