Re: [f2fs-dev] [PATCH] f2fs: no need test opt for f2fs_issue_flush

2023-06-18 Thread Chao Yu
On 2023/4/26 0:58, Yangtao Li wrote: This information can now be obtained from the mount, and there isi no need to print it out every time the trace event is triggered. It makes sense. Jaegeuk, is it intentional to print mount option in f2fs_issue_flush tracepoint? Thanks,

Re: [f2fs-dev] [PATCH 2/2] f2fs: convert to use sbi directly

2023-06-18 Thread Chao Yu
On 2023/6/13 15:51, Yangtao Li wrote: F2FS_I_SB(inode) is redundant. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode

2023-06-18 Thread Chao Yu
On 2023/6/19 11:11, Yangtao Li wrote: On 2023/6/19 8:54, Chao Yu wrote: On 2023/6/13 12:14, Yangtao Li wrote: On 2023/6/12 22:38, Chao Yu wrote: On 2023/6/9 21:15, Yangtao Li wrote: It is observed that when in user compression mode (compress_extension=*), even though the file is not

Re: [f2fs-dev] [PATCH] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode

2023-06-18 Thread Yangtao Li via Linux-f2fs-devel
On 2023/6/19 8:54, Chao Yu wrote: On 2023/6/13 12:14, Yangtao Li wrote: On 2023/6/12 22:38, Chao Yu wrote: On 2023/6/9 21:15, Yangtao Li wrote: It is observed that when in user compression mode (compress_extension=*), even though the file is not compressed, the file is still forced to use

Re: [f2fs-dev] [PATCH v4] f2fs: refactor struct f2fs_attr macro

2023-06-18 Thread Chao Yu
On 2023/5/6 23:16, Yangtao Li wrote: This patch provides a large number of variants of F2FS_RW_ATTR and F2FS_RO_ATTR macros, reducing the number of parameters required to initialize the f2fs_attr structure. Reported-by: kernel test robot Link:

Re: [f2fs-dev] [PATCH v2] f2fs: enable nowait async buffered writes

2023-06-18 Thread Chao Yu
On 2023/6/13 15:29, Yangtao Li wrote: This adds the async buffered write support to f2fs, the following is the relevant test data. iodepth | 1| 2| 4| 8| 16 | before(M/s) | 1012 | 1133 | 894 | 981 | 866 | after(M/s) | 1488 | 1896 | 2081 | 2188 | 2207 | The following

Re: [f2fs-dev] [PATCH v3] f2fs_io: expend fallocate command

2023-06-18 Thread Chao Yu
On 2023/6/13 14:59, Yangtao Li wrote: Expend fallocate command to support more flags. Signed-off-by: Yangtao Li Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH] f2fs: count mmap write io more accurately

2023-06-18 Thread Chao Yu
On 2023/6/13 14:51, Yunlei He wrote: This patch count mmap write io more accurately and remove redundant PageUptodate judgement in f2fs_vm_page_mkwrite. Yunlei, What about separating this patch: - remove unneeded uptodate check/set. - fix incorrect PageMappedToDisk check and goto logic.

Re: [f2fs-dev] [PATCH] f2fs: compress: don't force buffered io when in COMPR_MODE_USER mode

2023-06-18 Thread Chao Yu
On 2023/6/13 12:14, Yangtao Li wrote: On 2023/6/12 22:38, Chao Yu wrote: On 2023/6/9 21:15, Yangtao Li wrote: It is observed that when in user compression mode (compress_extension=*), even though the file is not compressed, the file is still forced to use buffer io, which makes the AndroBench