Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Damien Le Moal
On 6/21/23 23:45, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely though,

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Tom Talpey
On 6/21/2023 10:45 AM, Jeff Layton wrote: struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is accessed in certain inodes in order to make use of them. In order to do that safely though,

Re: [f2fs-dev] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 15:21 -0400, Steven Rostedt wrote: > On Wed, 21 Jun 2023 10:45:05 -0400 > Jeff Layton wrote: > > > Most of this conversion was done via coccinelle, with a few of the more > > non-standard accesses done by hand. There should be no behavioral > > changes with this set. That

Re: [f2fs-dev] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Steven Rostedt
On Wed, 21 Jun 2023 10:45:05 -0400 Jeff Layton wrote: > Most of this conversion was done via coccinelle, with a few of the more > non-standard accesses done by hand. There should be no behavioral > changes with this set. That will come later, as we convert individual > filesystems to use

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Tom Talpey
On 6/21/2023 2:01 PM, Jeff Layton wrote: On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: On 6/21/2023 10:45 AM, Jeff Layton wrote: struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 14:19 -0400, Tom Talpey wrote: > On 6/21/2023 2:01 PM, Jeff Layton wrote: > > On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: > > > On 6/21/2023 10:45 AM, Jeff Layton wrote: > > > > struct timespec64 has unused bits in the tv_nsec field that can be used > > > > for other

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
On Wed, 2023-06-21 at 13:29 -0400, Tom Talpey wrote: > On 6/21/2023 10:45 AM, Jeff Layton wrote: > > struct timespec64 has unused bits in the tv_nsec field that can be used > > for other purposes. In future patches, we're going to change how the > > inode->i_ctime is accessed in certain inodes in

Re: [f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jan Kara
On Wed 21-06-23 10:45:06, Jeff Layton wrote: > struct timespec64 has unused bits in the tv_nsec field that can be used > for other purposes. In future patches, we're going to change how the > inode->i_ctime is accessed in certain inodes in order to make use of > them. In order to do that safely

[f2fs-dev] Trying to use compression options in f2fs

2023-06-21 Thread Michael Opdenacker via Linux-f2fs-devel
Greetings, I'm trying to compare the performance of the various compression options in f2fs versus the default settings, on an SD card. Here's what I'm doing: * Creating the filesystem: mkfs.f2fs -f -l data -O compression,extra_attr /dev/mmcblk0p3 * Mounting the filesystem: mount -o

[f2fs-dev] [PATCH 79/79] fs: rename i_ctime field to __i_ctime

2023-06-21 Thread Jeff Layton
Now that everything in-tree is converted to use the accessor functions, rename the i_ctime field in the inode to make its accesses more self-documenting. Signed-off-by: Jeff Layton --- include/linux/fs.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[f2fs-dev] [PATCH 30/79] f2fs: switch to new ctime accessors

2023-06-21 Thread Jeff Layton
In later patches, we're going to change how the ctime.tv_nsec field is utilized. Switch to using accessor functions instead of raw accesses of inode->i_ctime. Signed-off-by: Jeff Layton --- fs/f2fs/dir.c | 8 fs/f2fs/f2fs.h | 5 - fs/f2fs/file.c | 16

[f2fs-dev] [PATCH 00/79] fs: new accessors for inode->i_ctime

2023-06-21 Thread Jeff Layton
I've been working on a patchset to change how the inode->i_ctime is accessed in order to give us conditional, high-res timestamps for the ctime and mtime. struct timespec64 has unused bits in it that we can use to implement this. In order to do that however, we need to wrap all accesses of

[f2fs-dev] [PATCH 01/79] fs: add ctime accessors infrastructure

2023-06-21 Thread Jeff Layton
struct timespec64 has unused bits in the tv_nsec field that can be used for other purposes. In future patches, we're going to change how the inode->i_ctime is accessed in certain inodes in order to make use of them. In order to do that safely though, we'll need to eradicate raw accesses of the

Re: [f2fs-dev] [PATCH 2/2] f2fs: truncate pages if move file range success

2023-06-21 Thread Chao Yu
On 2023/6/21 17:43, Yunlei He wrote: If move file range success, it should remove old data from src and dst page cache. Signed-off-by: Yunlei He Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method

2023-06-21 Thread Chao Yu
On 2023/6/21 17:43, Yunlei He wrote: Mtime and ctime stay old value without update after move file range ioctl. This patch add time update. Signed-off-by: Yunlei He --- v2: -update both src and dst inode fs/f2fs/file.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[f2fs-dev] [PATCH 1/2 v2] f2fs: update mtime and ctime in move file range method

2023-06-21 Thread Yunlei He via Linux-f2fs-devel
Mtime and ctime stay old value without update after move file range ioctl. This patch add time update. Signed-off-by: Yunlei He --- v2: -update both src and dst inode fs/f2fs/file.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index

[f2fs-dev] [PATCH 2/2] f2fs: truncate pages if move file range success

2023-06-21 Thread Yunlei He via Linux-f2fs-devel
If move file range success, it should remove old data from src and dst page cache. Signed-off-by: Yunlei He --- fs/f2fs/file.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 4adcf62e2665..25ef36f2376a 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c

Re: [f2fs-dev] [PATCH v8] fsck.f2fs: Detect and fix looped node chain efficiently

2023-06-21 Thread Chunhai Guo via Linux-f2fs-devel
Hi Chao, Sorry for replying late, I have send patch "fsck.f2fs: refactor looped node chain detetected logic for cleanup" as you suggested. Thanks. On 2023/6/17 10:20, Chao Yu wrote: On 2023/6/14 17:27, Chunhai Guo wrote: Hi Jaegeuk, Could you please help to confirm if this patch has been

[f2fs-dev] [PATCH] fsck.f2fs: refactor looped node chain detetected logic for cleanup

2023-06-21 Thread Chunhai Guo via Linux-f2fs-devel
Refactor looped node chain detected logic for cleanup as kernel does. Suggested-by: Chao Yu Signed-off-by: Chunhai Guo --- fsck/mount.c | 115 --- 1 file changed, 55 insertions(+), 60 deletions(-) diff --git a/fsck/mount.c b/fsck/mount.c index