[f2fs-dev] [PATCH] f2fs-tools: do sanity check on xattr entry

2023-07-17 Thread Chao Yu
If there are corrupted xattr entries in xattr space, it may cause traversing across end of xattr space issue, this patch adds sanity check during xattr traverse to avoid such issue. This patch synchronizes kernel commits: 2777e654371d ("f2fs: fix to avoid accessing xattr across the boundary") 688

[f2fs-dev] [PATCH] dump.f2fs: support to dump fsverity xattr info in print_xattr_entry()

2023-07-17 Thread Chao Yu
This patch adds to support dumping fsverity xattr info in print_xattr_entry(). Signed-off-by: Chao Yu --- fsck/mount.c | 13 + fsck/xattr.h | 11 +++ 2 files changed, 24 insertions(+) diff --git a/fsck/mount.c b/fsck/mount.c index dbb516b..2691b2f 100644 --- a/fsck/mount.c +

Re: [f2fs-dev] [PATCH v2] f2fs: do not issue small discard commands during checkpoint

2023-07-17 Thread Chao Yu
Comments? On 2023/7/13 9:31, Chao Yu wrote: On 2023/7/12 23:55, Jaegeuk Kim wrote: On 07/12, Chao Yu wrote: On 2023/7/12 0:37, Jaegeuk Kim wrote: On 07/06, Chao Yu wrote: On 2023/7/6 1:30, Jaegeuk Kim wrote: On 07/04, Chao Yu wrote: On 2023/7/4 18:53, Jaegeuk Kim wrote: On 07/03, Chao Yu

[f2fs-dev] [PATCH] f2fs_io: fix build warning

2023-07-17 Thread Jaegeuk Kim
external/f2fs-tools/tools/f2fs_io/f2fs_io.c:1452:3: error: format specifies type 'unsigned long' but the argument has type 'u64' (aka 'unsigned long long') [-Werror,-Wformat] range.start, range.len, ret); ^~~ external/f2fs-tools/tools/f2fs_io/f2fs_io.c:1452

Re: [f2fs-dev] [PATCH] f2fs-tools: quick fix for Android build

2023-07-17 Thread Chao Yu
On 2023/7/18 2:18, Jaegeuk Kim wrote: In file included from external/f2fs-tools/lib/nls_utf8.c:29: external/f2fs-tools/include/f2fs_fs.h:1781:44: error: call to undeclared function 'S_ISDIR'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]

[f2fs-dev] [PATCH] f2fs-tools: quick fix for Android build

2023-07-17 Thread Jaegeuk Kim
In file included from external/f2fs-tools/lib/nls_utf8.c:29: external/f2fs-tools/include/f2fs_fs.h:1781:44: error: call to undeclared function 'S_ISDIR'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] raw_node->i.i_current_depth = cpu_to_

Re: [f2fs-dev] [PATCH 1/2] f2fs: allow f2fs_ioc_{, de}compress_file to be interrupted

2023-07-17 Thread patchwork-bot+f2fs
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 12 Jul 2023 04:08:05 +0800 you wrote: > This patch allows f2fs_ioc_{,de}compress_file() to be interrupted, so that, > userspace won't be blocked when manual {,de}compression on large file is > interrupted by signal.

Re: [f2fs-dev] [PATCH] f2fs: don't handle error case of f2fs_compress_alloc_page()

2023-07-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 10 Jul 2023 14:10:58 +0800 you wrote: > f2fs_compress_alloc_page() uses mempool to allocate memory, it never > fail, don't handle error case in its callers. > > Signed-off-by: Chao Yu > --- > fs/f2fs/compress.c |

Re: [f2fs-dev] [PATCH] f2fs: flush inode if atomic file is aborted

2023-07-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 7 Jul 2023 07:11:42 -0700 you wrote: > Let's flush the inode being aborted atomic operation to avoid stale dirty > inode during eviction in this call stack: > > f2fs_mark_inode_dirty_sync+0x22/0x40 [f2fs] > f2f

[f2fs-dev] Patchwork summary for: f2fs

2023-07-17 Thread patchwork-bot+f2fs
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: [f2fs-dev,1/2] f2fs: allow f2fs_ioc_{, de}compress_file to be interrupted Submitter: Chao Yu Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/

Re: [f2fs-dev] [PATCH] f2fs: get out of a repeat loop when getting a locked data page

2023-07-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 23 Mar 2023 14:39:19 -0700 you wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=216050 > > Somehow we're getting a page which has a different mapping. > Let's avoid the infinite loop. > > Cc: > Signed-off-by:

Re: [f2fs-dev] [PATCH v3] f2fs: fix to avoid mmap vs set_compress_option case

2023-07-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 6 Jul 2023 10:06:14 +0800 you wrote: > Compression option in inode should not be changed after they have > been used, however, it may happen in below race case: > > Thread A Thread B >

Re: [f2fs-dev] [PATCH] f2fs: fix spelling in ABI documentation

2023-07-17 Thread patchwork-bot+f2fs
Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Sun, 9 Jul 2023 22:23:24 -0700 you wrote: > Correct spelling problems as identified by codespell. > > Fixes: 9e615dbba41e ("f2fs: add missing description for ipu_policy node") > Fixes: b2e4a2b300e5 ("f2fs: expose discar

Re: [f2fs-dev] [PATCH v1] f2fs: increase usage of folio_next_index() helper

2023-07-17 Thread Chao Yu
On 2023/7/17 15:11, Minjie Du wrote: Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using the existing helper folio_next_index(). Signed-off-by: Minjie Du Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f

Re: [f2fs-dev] [PATCH v6] f2fs-tools: support to show fscrypt_context_v2 in print_xattr_entry

2023-07-17 Thread Chao Yu
On 2023/7/17 18:52, Weichao Guo wrote: As the fscrypt context has two versions now, this patch adds the support of fscrypt_context_v2 for print_xattr_entry. Signed-off-by: Weichao Guo Signed-off-by: Sheng Yong Reviewed-by: Chao Yu Thanks, ___ L

Re: [f2fs-dev] [PATCH] f2fs: don't reopen the main block device in f2fs_scan_devices

2023-07-17 Thread Chao Yu
On 2023/7/11 13:01, Christoph Hellwig wrote: I think that's because it doesn't look at sbi->s_ndevs in destroy_device_list. Let's try the variant below, which also fixes the buildbot warning for non-zoned configfs: --- From 645d8dceaa97b6ee73be067495b111b15b187498 Mon Sep 17 00:00:00 2001 From

Re: [f2fs-dev] [PATCH v4] f2fs-tools: support to show fscrypt_context_v2 in print_xattr_entry

2023-07-17 Thread Chao Yu
On 2023/7/17 9:40, Chao Yu wrote: If I understand Eric's commnets correctly, if size == 0, we'd better just return in order to avoid below codes which may access out-of-boundary on xattr entry. Oh, wrong comment, please ignore it. Thanks, ___ Linu

[f2fs-dev] [PATCH v6] f2fs-tools: support to show fscrypt_context_v2 in print_xattr_entry

2023-07-17 Thread Weichao Guo via Linux-f2fs-devel
As the fscrypt context has two versions now, this patch adds the support of fscrypt_context_v2 for print_xattr_entry. Signed-off-by: Weichao Guo Signed-off-by: Sheng Yong --- v6: - print notice for unsupported fscrypt_context version v5: - check if e_name/e_name_len is match with F2FS_XATTR_NAME

[f2fs-dev] [PATCH v1] f2fs: increase usage of folio_next_index() helper

2023-07-17 Thread Minjie Du via Linux-f2fs-devel
Simplify code pattern of 'folio->index + folio_nr_pages(folio)' by using the existing helper folio_next_index(). Signed-off-by: Minjie Du --- fs/f2fs/data.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 5882afe71..298024b07 100644 ---