Re: [f2fs-dev] [PATCH] f2fs: fix thread name cannot be fully displayed

2023-11-07 Thread Zhiguo Niu
Dear Chao, On Tue, Nov 7, 2023 at 10:53 PM Chao Yu wrote: > > On 2023/11/2 9:20, Zhiguo Niu wrote: > > Because the length of task'name in task_struct can not exceed > > 16 characters, f2fs some thread'name cannot be fully displayed, > > including important device number information. > > If there

[f2fs-dev] [PATCH AUTOSEL 6.5 14/18] f2fs: fix error handling of __get_node_page

2023-11-07 Thread Sasha Levin
From: Zhiguo Niu [ Upstream commit 9b4c8dd99fe48721410741651d426015e03a4b7a ] Use f2fs_handle_error to record inconsistent node block error and return -EFSCORRUPTED instead of -EINVAL. Signed-off-by: Zhiguo Niu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/node.c | 3

[f2fs-dev] [PATCH AUTOSEL 6.1 08/11] f2fs: fix error handling of __get_node_page

2023-11-07 Thread Sasha Levin
From: Zhiguo Niu [ Upstream commit 9b4c8dd99fe48721410741651d426015e03a4b7a ] Use f2fs_handle_error to record inconsistent node block error and return -EFSCORRUPTED instead of -EINVAL. Signed-off-by: Zhiguo Niu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/node.c | 3

[f2fs-dev] [PATCH AUTOSEL 6.5 13/18] f2fs: fix error path of __f2fs_build_free_nids

2023-11-07 Thread Sasha Levin
From: Zhiguo Niu [ Upstream commit a5e80e18f268ea7c7a36bc4159de0deb3b5a2171 ] If NAT is corrupted, let scan_nat_page() return EFSCORRUPTED, so that, caller can set SBI_NEED_FSCK flag into checkpoint for later repair by fsck. Also, this patch introduces a new fscorrupted error flag, and in

[f2fs-dev] [PATCH AUTOSEL 6.6 14/18] f2fs: fix error handling of __get_node_page

2023-11-07 Thread Sasha Levin
From: Zhiguo Niu [ Upstream commit 9b4c8dd99fe48721410741651d426015e03a4b7a ] Use f2fs_handle_error to record inconsistent node block error and return -EFSCORRUPTED instead of -EINVAL. Signed-off-by: Zhiguo Niu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- fs/f2fs/node.c | 3

[f2fs-dev] [PATCH AUTOSEL 6.6 13/18] f2fs: fix error path of __f2fs_build_free_nids

2023-11-07 Thread Sasha Levin
From: Zhiguo Niu [ Upstream commit a5e80e18f268ea7c7a36bc4159de0deb3b5a2171 ] If NAT is corrupted, let scan_nat_page() return EFSCORRUPTED, so that, caller can set SBI_NEED_FSCK flag into checkpoint for later repair by fsck. Also, this patch introduces a new fscorrupted error flag, and in

Re: [f2fs-dev] [PATCH] f2fs: the name of a struct is wrong in a comment.

2023-11-07 Thread kernel test robot
Hi, kernel test robot noticed the following build errors: [auto build test ERROR on jaegeuk-f2fs/dev-test] [also build test ERROR on jaegeuk-f2fs/dev linus/master v6.6 next-20231107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [f2fs-dev] [PATCH] f2fs: data: fix possible overflow in check_swap_activate()

2023-11-07 Thread Chao Yu
Hi Sergey, Thanks for the patch. On 2023/10/26 4:20, Sergey Shtylyov wrote: In check_swap_activate(), if the *while* loop exits early (0- or 1-page long swap file), an overflow happens while calculating the value of the span parameter as the lowest_pblock variable ends up being greater than

Re: [f2fs-dev] [PATCH] f2fs: explicitly null-terminate the xattr list

2023-11-07 Thread Chao Yu
On 2023/11/7 12:44, Eric Biggers wrote: From: Eric Biggers When setting an xattr, explicitly null-terminate the xattr list. This eliminates the fragile assumption that the unused xattr space is always zeroed. Signed-off-by: Eric Biggers Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: the name of a struct is wrong in a comment.

2023-11-07 Thread Chao Yu
On 2023/11/4 15:45, ds...@lzu.edu.cn wrote: From: Yang Hubin The macro SUMMARY_SIZE represents the size of the struct f2fs_summary, instead of the size of the struct summary. Signed-off-by: Yang Hubin Signed-off-by: Qian Haolai Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: fix thread name cannot be fully displayed

2023-11-07 Thread Chao Yu
On 2023/11/2 9:20, Zhiguo Niu wrote: Because the length of task'name in task_struct can not exceed 16 characters, f2fs some thread'name cannot be fully displayed, including important device number information. If there are more than one partition using the f2fs file system, it is very

Re: [f2fs-dev] [PATCH 1/1] f2fs: fix fallocate failed under pinned block situation

2023-11-07 Thread Chao Yu
On 2023/10/30 17:40, Wu Bo wrote: If GC victim has pinned block, it can't be recycled. And if GC is foreground running, after many failure try, the pinned file is expected to be clear pin flag. To enable the section be recycled. But when fallocate trigger FG_GC, GC can never recycle the pinned

Re: [f2fs-dev] [PATCH] f2fs: use inode_lock_shared instead of inode_lock in f2fs_seek_block()

2023-11-07 Thread Chao Yu
On 2023/10/21 20:19, zhangxirui wrote: inode_lock_shared() -> down_read(>i_rwsem) inode_lock() -> down_write(>i_rwsem) Inode is not updated in f2fs_seek_block(), so there is no need to hold write lock, use read lock for more efficiency. Signed-off-by: zhangxirui Reviewed-by: Chao Yu

Re: [f2fs-dev] [RFC] weirdness in f2fs_rename() with RENAME_WHITEOUT

2023-11-07 Thread Chao Yu
On 2023/10/27 0:16, Jan Kara wrote: Jaegeuk, Chao, any comment on this? It really looks like a filesystem corruption issue in f2fs when whiteouts are used... Sorry for delay reply, I was busy handling product issues these days... Let me check this ASAP. Thanks,