Re: [f2fs-dev] [PATCH v2] f2fs_io: add list/setattr command

2023-11-14 Thread Chao Yu
On 2023/10/20 10:39, Jaegeuk Kim wrote: Let's add list/set/removexattrs commands. It looks it missed to add related description in man/f2fs_io.8. Thanks, Signed-off-by: Jaegeuk Kim --- - add removexattrs tools/f2fs_io/f2fs_io.c | 107 1 file

Re: [f2fs-dev] [PATCH 2/2] fsck.f2fs: fix cache offset for multiple partitions

2023-11-14 Thread Chao Yu
On 2023/10/17 5:58, Jaegeuk Kim wrote: The cache offset should have been considered multiple partitions per fd. Let's fix. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH 1/2] Revert "f2fs-tools: do not support user-space cache"

2023-11-14 Thread Chao Yu
On 2023/10/17 5:58, Jaegeuk Kim wrote: This reverts commit 2835107ae3908576b41ff5f6a4e63ba7ec9a6246. There's a report that the impact was true. Signed-off-by: Jaegeuk Kim Sorry for delay reply, feel free to add: Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Chao Yu
On 2023/11/15 10:45, Jaegeuk Kim wrote: On 11/15, Chao Yu wrote: On 2023/11/15 5:24, Jaegeuk Kim wrote: When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. What about skipping f2fs_bug_on() just for zoned UFS case? so

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Jaegeuk Kim
On 11/15, Chao Yu wrote: > On 2023/11/15 5:24, Jaegeuk Kim wrote: > > When recovering zoned UFS, sometimes we add the same zone to discard > > multiple > > times. Simple workaround is to bypass adding it. > > What about skipping f2fs_bug_on() just for zoned UFS case? so that the check >

Re: [f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Chao Yu
On 2023/11/15 5:24, Jaegeuk Kim wrote: When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. What about skipping f2fs_bug_on() just for zoned UFS case? so that the check condition can still be used for non-zoned UFS case.

[f2fs-dev] [PATCH] f2fs: skip adding a discard command if exists

2023-11-14 Thread Jaegeuk Kim
When recovering zoned UFS, sometimes we add the same zone to discard multiple times. Simple workaround is to bypass adding it. Signed-off-by: Jaegeuk Kim --- fs/f2fs/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index