Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Al Viro
On Wed, Nov 22, 2023 at 04:18:56PM -0800, Linus Torvalds wrote: > On Wed, 22 Nov 2023 at 13:19, Al Viro wrote: > > > > The serious gap, AFAICS, is the interplay with open-by-fhandle. > > So I'm obviously not a fan of igncase filesystems, but I don't think > this series actually changes any of

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Al Viro
On Thu, Nov 23, 2023 at 01:12:08AM +, Al Viro wrote: > On Wed, Nov 22, 2023 at 09:19:01PM +, Al Viro wrote: > > On Tue, Nov 21, 2023 at 02:27:34AM +, Al Viro wrote: > > > > > I will review that series; my impression from the previous iterations > > > had been fairly unpleasant, TBH,

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Linus Torvalds
On Wed, 22 Nov 2023 at 13:19, Al Viro wrote: > > The serious gap, AFAICS, is the interplay with open-by-fhandle. So I'm obviously not a fan of igncase filesystems, but I don't think this series actually changes any of that. > It's not unfixable, but we need to figure out what to do when >

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Al Viro
On Wed, Nov 22, 2023 at 09:19:01PM +, Al Viro wrote: > On Tue, Nov 21, 2023 at 02:27:34AM +, Al Viro wrote: > > > I will review that series; my impression from the previous iterations > > had been fairly unpleasant, TBH, but I hadn't rechecked since April > > or so. > > The serious gap,

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Al Viro
On Tue, Nov 21, 2023 at 02:27:34AM +, Al Viro wrote: > I will review that series; my impression from the previous iterations > had been fairly unpleasant, TBH, but I hadn't rechecked since April > or so. The serious gap, AFAICS, is the interplay with open-by-fhandle. It's not unfixable, but

Re: [f2fs-dev] [PATCH v6 0/9] Support negative dentries on case-insensitive ext4 and f2fs

2023-11-22 Thread Al Viro
On Tue, Nov 21, 2023 at 12:12:15AM -0500, Theodore Ts'o wrote: > Yeah, agreed, that would be a nice optimization. However, in the > unfortunate case where (a) it's non-ASCII, and (b) the input string is > non-normalized and/or differs in case, we end up scanning some portion > of the two strings

Re: [f2fs-dev] [PATCH v6 3/9] fs: Expose name under lookup to d_revalidate hooks

2023-11-22 Thread Al Viro
On Wed, Aug 16, 2023 at 01:07:57AM -0400, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi > > Negative dentries support on case-insensitive ext4/f2fs will require > access to the name under lookup to ensure it matches the dentry. This > adds the information on d_revalidate and

Re: [f2fs-dev] [PATCH v6 4/9] fs: Add DCACHE_CASEFOLDED_NAME flag

2023-11-22 Thread Al Viro
On Wed, Aug 16, 2023 at 01:07:58AM -0400, Gabriel Krisman Bertazi wrote: > From: Gabriel Krisman Bertazi > > This flag marks a negative or positive dentry as being created after a > case-insensitive lookup operation. It is useful to differentiate > dentries this way to detect whether the

Re: [f2fs-dev] [PATCH v6 5/9] libfs: Validate negative dentries in case-insensitive directories

2023-11-22 Thread Al Viro
On Wed, Aug 16, 2023 at 01:07:59AM -0400, Gabriel Krisman Bertazi wrote: > +static int generic_ci_d_revalidate(struct dentry *dentry, > +const struct qstr *name, > +unsigned int flags) > +{ > + const struct dentry *parent; > +

[f2fs-dev] [PATCH] f2fs: sysfs: support discard_io_aware

2023-11-22 Thread Chao Yu
It gives a way to enable/disable IO aware feature for background discard, so that we can tune background discard more precisely based on undiscard condition. e.g. force to disable IO aware if there are large number of discard extents, and discard IO may always be interrupted by frequent common IO.

[f2fs-dev] [syzbot] Monthly f2fs report (Nov 2023)

2023-11-22 Thread syzbot
Hello f2fs maintainers/developers, This is a 31-day syzbot report for the f2fs subsystem. All related reports/information can be found at: https://syzkaller.appspot.com/upstream/s/f2fs During the period, 1 new issues were detected and 0 were fixed. In total, 4 issues are still open and 34 have