On Mon, Dec 18, 2023 at 08:21:22AM +, Ed Tsai (蔡宗軒) wrote:
> On Mon, 2023-12-18 at 15:53 +0900, Damien Le Moal wrote:
> > On 2023/12/18 15:15, Ed Tsai (蔡宗軒) wrote:
> > > Hi Christoph,
> > >
> > > some minor suggestions:
> > >
> > > On Sun, 2023-12-17 at 17:53 +0100, Christoph Hellwig wrote:
On Tue, Dec 19, 2023 at 12:00 PM Chao Yu wrote:
>
> On 2023/12/19 10:21, Zhiguo Niu wrote:
> > The current pending_discard attr just only shows the discard_cmd_cnt
> > information. More discard status can be shown so that we can check
> > them through sysfs when needed.
> >
> > Signed-off-by:
On 2023/12/19 10:21, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
---
changes of v2: Improve the patch according to Chao's
unify the error handling of ERROR_INVALID_BLKADDR in f2fs_is_valid_blkaddr
and remove some redundant codes in f2fs_cache_compressed_page.
Signed-off-by: Zhiguo Niu
---
changes of v2: improve patch according Chao's suggestions.
changes of v3:
-rebase patch to dev-test
-correct
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
---
changes of v2: Improve the patch according to Chao's suggestions.
changes of v3: Add a blank line
Christoph,
> Fortunately only a few HDD prototypes shipped using this model which
> never made it to mass production. Drop the support before it is too
> late. Note that any such host aware prototype HDD can still be used
> with Linux as we'll now treat it as a conventional HDD.
Looks good to
On Tue, Dec 19, 2023 at 1:45 AM Jaegeuk Kim wrote:
>
> On 12/18, Zhiguo Niu wrote:
> > The current pending_discard attr just only shows the discard_cmd_cnt
> > information. More discard status can be shown so that we can check
> > them through sysfs when needed.
> >
> > Signed-off-by: Zhiguo Niu
On 12/18, Zhiguo Niu wrote:
> The current pending_discard attr just only shows the discard_cmd_cnt
> information. More discard status can be shown so that we can check
> them through sysfs when needed.
>
> Signed-off-by: Zhiguo Niu
> ---
> changes of v2: Improve the patch according to Chao's
On Mon, Dec 18, 2023 at 06:48:43PM +0900, Damien Le Moal wrote:
> > - if (devip->zmodel == BLK_ZONED_HA)
> > - arr[4] = 1 << 4;/* zoned field = 01b */
>
> I think we should keep everything related to HA in scsi debug as that is an
> easy
> way to test the block layer and
On 2023/12/18 19:07, Zhiguo Niu wrote:
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
The current pending_discard attr just only shows the discard_cmd_cnt
information. More discard status can be shown so that we can check
them through sysfs when needed.
Signed-off-by: Zhiguo Niu
---
changes of v2: Improve the patch according to Chao's suggestions.
changes of v3: Add a blank line
On 2023/12/18 1:53, Christoph Hellwig wrote:
> disk_clear_zoned only needs to be called when a device reported zone
> managed mode first and we clear it. Add a check so that disk_clear_zoned
> isn't called on devices that were never zoned.
>
> This avoids a fairly expensive queue freezing when
On 2023/12/18 1:53, Christoph Hellwig wrote:
> Only use disk_set_zoned to actually enable zoned device support.
> For clearing it, call disk_clear_zoned, which is renamed from
> disk_clear_zone_settings and now directly clears the zoned flag as
> well.
>
> Signed-off-by: Christoph Hellwig
Looks
On 2023/12/18 1:53, Christoph Hellwig wrote:
> When zones were first added the SCSI and ATA specs, two different
> models were supported (in addition to the drive managed one that
> is invisible to the host):
>
> - host managed where non-conventional zones there is strict requirement
>to
On 2023/12/18 1:53, Christoph Hellwig wrote:
> virtblk_revalidate_zones is called unconditionally from
> virtblk_config_changed_work from the virtio config_changed callback.
>
> virtblk_revalidate_zones is a bit odd in that it re-clears the zoned
> state for host aware or non-zoned devices, which
On 2023/12/18 1:53, Christoph Hellwig wrote:
> Move reading and checking the zoned model from virtblk_probe_zoned_device
> into the caller, leaving only the code to perform the actual setup for
> host managed zoned devices in virtblk_probe_zoned_device.
>
> This allows to share the model reading
On 12/18/23 17:21, Ed Tsai (蔡宗軒) wrote:
> On Mon, 2023-12-18 at 15:53 +0900, Damien Le Moal wrote:
>> On 2023/12/18 15:15, Ed Tsai (蔡宗軒) wrote:
>>> Hi Christoph,
>>>
>>> some minor suggestions:
>>>
>>> On Sun, 2023-12-17 at 17:53 +0100, Christoph Hellwig wrote:
diff --git
17 matches
Mail list logo
