Re: [f2fs-dev] [PATCH] ovl: Reject mounting case-insensitive filesystems

2023-12-22 Thread Amir Goldstein
[CC: overlayfs] On Sat, Dec 23, 2023 at 8:20 AM Amir Goldstein wrote: > > On Sat, Dec 23, 2023 at 6:23 AM Gabriel Krisman Bertazi > wrote: > > > > Eric Biggers writes: > > > > > On Fri, Dec 15, 2023 at 04:16:00PM -0500, Gabriel Krisman Bertazi wrote: > > >> [Apologies for the quick spin of a

Re: [f2fs-dev] [PATCH] ovl: Reject mounting case-insensitive filesystems

2023-12-22 Thread Amir Goldstein
On Sat, Dec 23, 2023 at 6:23 AM Gabriel Krisman Bertazi wrote: > > Eric Biggers writes: > > > On Fri, Dec 15, 2023 at 04:16:00PM -0500, Gabriel Krisman Bertazi wrote: > >> [Apologies for the quick spin of a v2. The only difference are a couple > >> fixes to the build when CONFIG_UNICODE=n

[f2fs-dev] [PATCH] ovl: Reject mounting case-insensitive filesystems

2023-12-22 Thread Gabriel Krisman Bertazi
Eric Biggers writes: > On Fri, Dec 15, 2023 at 04:16:00PM -0500, Gabriel Krisman Bertazi wrote: >> [Apologies for the quick spin of a v2. The only difference are a couple >> fixes to the build when CONFIG_UNICODE=n caught by LKP and detailed in >> each patch changelog.] >> >> When

Re: [f2fs-dev] [PATCH 1/2] f2fs: Constrain the modification range of dir_level in the sysfs

2023-12-22 Thread Chao Yu
On 2023/12/22 11:29, Yongpeng Yang wrote: The {struct f2fs_sb_info}->dir_level can be modified through the sysfs interface, but its value range is not limited. If the value exceeds MAX_DIR_HASH_DEPTH and the mount options include "noinline_dentry", the following error will occur: [root@fedora

Re: [f2fs-dev] [PATCH 2/2] f2fs: Add error handling for negative returns from do_garbage_collect

2023-12-22 Thread Chao Yu
On 2023/12/22 11:29, Yongpeng Yang wrote: The function do_garbage_collect can return a value less than 0 due to f2fs_cp_error being true or page allocation failure, as a result of calling f2fs_get_sum_page. However, f2fs_gc does not account for such cases, which could potentially lead to an