Dear Chao,
Do you have any other suggestions about this patch version?
thanks!
On Tue, Dec 19, 2023 at 11:57 AM Zhiguo Niu wrote:
>
> unify the error handling of ERROR_INVALID_BLKADDR in f2fs_is_valid_blkaddr
> and remove some redundant codes in f2fs_cache_compressed_page.
>
> Signed-off-by:
syzbot suspects this issue was fixed by commit:
commit fd1464105cb37a3b50a72c1d2902e97a71950af8
Author: Jan Kara
Date: Wed Oct 18 15:29:24 2023 +
fs: Avoid grabbing sb->s_umount under bdev->bd_holder_lock
bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=14639595e8
On 2023/12/21 14:49, Kevin Hao wrote:
A freezable kernel thread can enter frozen state during freezing by
either calling try_to_freeze() or using wait_event_freezable() and its
variants. So for the following snippet of code in a kernel thread loop:
wait_event_interruptible_timeout();
In reserve_compress_blocks(), we update blkaddrs of dnode in prior to
inc_valid_block_count(), it may cause inconsistent status bewteen
i_blocks and blkaddrs once inc_valid_block_count() fails.
To fix this issue, it needs to reverse their invoking order.
Fixes: c75488fb4d82 ("f2fs: introduce
