Re: [f2fs-dev] [PATCH v3 3/4] f2fs: atomic: fix to truncate pagecache before on-disk metadata truncation

On 08/01, Chao Yu wrote: > We should always truncate pagecache while truncating on-disk data. > > Fixes: a46bebd502fe ("f2fs: synchronize atomic write aborts") > Signed-off-by: Chao Yu > --- > v3: > - check dirty page before truncation > - use invalidate_mapping_pages() instead of truncate_inode_

Re: [f2fs-dev] [PATCH v5] f2fs: reduce expensive checkpoint trigger frequency

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 26 Jun 2024 09:47:27 +0800 you wrote: > We may trigger high frequent checkpoint for below case: > 1. mkdir /mnt/dir1; set dir1 encrypted > 2. touch /mnt/file1; fsync /mnt/file1 > 3. mkdir /mnt/dir2; set dir2 encrypte

Re: [f2fs-dev] [PATCH v3] f2fs: fix to avoid racing in between read and OPU dio write

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 27 Jun 2024 15:15:21 +0800 you wrote: > If lfs mode is on, buffered read may race w/ OPU dio write as below, > it may cause buffered read hits unwritten data unexpectly, and for > dio read, the race condition exists

Re: [f2fs-dev] [PATCH] f2fs: fix several potential integer overflows in file offsets

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 24 Jul 2024 10:28:38 -0700 you wrote: > When dealing with large extents and calculating file offsets by > summing up according extent offsets and lengths of unsigned int type, > one may encounter possible integer ove

Re: [f2fs-dev] [PATCH V2] f2fs: fix to use per-inode maxbytes and cleanup

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 26 Jul 2024 14:27:26 +0800 you wrote: > This is a supplement to commit 6d1451bf7f84 ("f2fs: fix to use per-inode > maxbytes") > for some missed cases, also cleanup redundant code in f2fs_llseek. > > Cc: Chengguang

Re: [f2fs-dev] [PATCH] f2fs: avoid potential int overflow in sanity_check_area_boundary()

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 24 Jul 2024 10:51:58 -0700 you wrote: > While calculating the end addresses of main area and segment 0, u32 > may be not enough to hold the result without the danger of int > overflow. > > Just in case, play it safe

Re: [f2fs-dev] [PATCH v5] f2fs:Add write priority option based on zone UFS

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 15 Jul 2024 20:34:51 +0800 you wrote: > Currently, we are using a mix of traditional UFS and zone UFS to support > some functionalities that cannot be achieved on zone UFS alone. However, > there are some issues with

Re: [f2fs-dev] [PATCH 1/4] f2fs: atomic: fix to avoid racing w/ GC

Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 25 Jun 2024 11:13:48 +0800 you wrote: > Case #1: > SQLite AppGC Thread Kworker Shrinker > - f2fs_ioc_start_atomic_write > > - f2fs_ioc_commit_atomic_write > - f2fs_commit_atomic_w

Re: [f2fs-dev] [PATCH] Revert "f2fs: use flush command instead of FUA for zoned device"

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Fri, 14 Jun 2024 00:48:41 + you wrote: > This reverts commit c550e25bca660ed2554cbb48d32b82d0bb98e4b1. > > Commit c550e25bca660ed2554cbb48d32b82d0bb98e4b1 ("f2fs: use flush > command instead of FUA for zoned device")

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: fix macro definition on_f2fs_build_free_nids

Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Sun, 21 Jul 2024 22:39:12 -0400 you wrote: > The macro on_f2fs_build_free_nids accepts a parameter nmi, > but it was not used, rather the variable nm_i was directly used, > which may be a local variable inside a function

Re: [f2fs-dev] [PATCH] f2fs: prevent possible int overflow in dir_block_index()

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Wed, 24 Jul 2024 10:05:44 -0700 you wrote: > The result of multiplication between values derived from functions > dir_buckets() and bucket_blocks() *could* technically reach > 2^30 * 2^2 = 2^32. > > While unlikely to hap

Re: [f2fs-dev] [PATCH] f2fs: use f2fs_get_node_page when write inline data

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 1 Apr 2024 13:48:20 + you wrote: > From: Zijie Wang > Date: Mon, 1 Apr 2024 21:24:08 +0800 > Subject: [PATCH] [f2fs-dev] f2fs: use f2fs_get_node_page when write inline > data > > We just need inode page when w

[f2fs-dev] Patchwork summary for: f2fs

Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Patch: [f2fs-dev,v5] f2fs:Add write priority option based on zone UFS Submitter: Liao Yuanhong Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series

Re: [f2fs-dev] [PATCH] f2fs: fix to wait dio completion

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 27 Jun 2024 15:17:11 +0800 you wrote: > It should wait all existing dio write IOs before block removal, > otherwise, previous direct write IO may overwrite data in the > block which may be reused by other inode. > >

Re: [f2fs-dev] [PATCH v2 3/3] f2fs: clean up data_blkaddr() and get_dnode_addr()

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Thu, 11 Jul 2024 09:46:32 +0800 you wrote: > Introudce a new help get_dnode_base() to wrap common code from > get_dnode_addr() and data_blkaddr() for cleanup. > > Signed-off-by: Chao Yu > --- > v2: > - clean up get_dnod

Re: [f2fs-dev] [PATCH v3] f2fs: get rid of buffer_head use

Hello: This patch was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Tue, 18 Jun 2024 15:26:20 +0800 you wrote: > Convert to use folio and related functionality. > > Cc: Matthew Wilcox > Signed-off-by: Chao Yu > --- > - support large folio > - use bd_mapping instead of bd_inode->i_mappi

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_vm_page_mkwrite

syzbot suspects this issue was fixed by commit: commit a8eb3de28e7a365690c61161e7a07a4fc7c60bbf Author: Chao Yu Date: Mon Jun 3 01:07:45 2024 + f2fs: fix return value of f2fs_convert_inline_inode() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1055414b98 start commi