Re: [f2fs-dev] [PATCH v3] f2fs: fix using wrong 'submitted' value in f2fs_write_cache_pages

2025-01-08 Thread 臧阳阳
Jaegeuk Kim 于2025年1月9日周四 02:29写道: > > On 01/06, zangyangyang wrote: > > From: zangyangyang1 > > > > When f2fs_write_single_data_page fails, f2fs_write_cache_pages > > will use the last 'submitted' value incorrectly, which will cause > > 'nwritten' and 'wbc->nr_to_write' calculation errors > > >

Re: [f2fs-dev] [PATCH v4 0/4] Speed up f2fs truncate

2025-01-08 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: This series was applied to jaegeuk/f2fs.git (dev) by Jaegeuk Kim : On Mon, 23 Dec 2024 16:10:40 +0800 you wrote: > Deleting large files is time-consuming, and a large part > of the time is spent in f2fs_invalidate_blocks() > ->down_write(sit_info->sentry_lock) and up_write(). > > If some

[f2fs-dev] Patchwork summary for: f2fs

2025-01-08 Thread patchwork-bot+f2fs--- via Linux-f2fs-devel
Hello: The following patches were marked "accepted", because they were applied to jaegeuk/f2fs.git (dev): Series: Speed up f2fs truncate Submitter: Yi Sun Committer: Jaegeuk Kim Patchwork: https://patchwork.kernel.org/project/f2fs/list/?series=920345 Lore link: https://lore.kernel.org/

Re: [f2fs-dev] [PATCH v3] f2fs: fix using wrong 'submitted' value in f2fs_write_cache_pages

2025-01-08 Thread Jaegeuk Kim via Linux-f2fs-devel
On 01/06, zangyangyang wrote: > From: zangyangyang1 > > When f2fs_write_single_data_page fails, f2fs_write_cache_pages > will use the last 'submitted' value incorrectly, which will cause > 'nwritten' and 'wbc->nr_to_write' calculation errors > > Signed-off-by: zangyangyang1 > --- > v3: No logic

[f2fs-dev] [PATCH] f2fs: remove blk_finish_plug

2025-01-08 Thread Jaegeuk Kim via Linux-f2fs-devel
Let's remove unclear blk_finish_plug. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 35b9455fb899..f681742ebecb 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -511,10 +511,6 @@ static void f2fs_submi

Re: [f2fs-dev] [PATCH] f2fs: Fix slab-out-of-bounds Read KASAN bug in f2fs_getxattr()

2025-01-08 Thread qasdev
On Wed, Jan 08, 2025 at 07:44:03PM +0800, Chao Yu wrote: > Hi Qasim, > > On 2025/1/8 07:03, qasdev wrote: > > In f2fs_getxattr(), the function lookup_all_xattrs() allocates a 12-byte > > (base_size) buffer for an inline extended attribute. However, when > > __find_inline_xattr() calls __find_xattr

Re: [f2fs-dev] [PATCH 1/2] f2fs: fix missing discard candidates in fstrim

2025-01-08 Thread Chao Yu via Linux-f2fs-devel
On 2025/1/3 16:07, Chunhai Guo wrote: 在 1/3/2025 11:26 AM, Chao Yu 写道: On 2025/1/2 18:13, Chunhai Guo wrote: fstrim may miss candidates that need to be discarded in fstrim, as shown in the examples below. The root cause is that when cpc->reason is set with CP_DISCARD, add_discard_addrs() expect

Re: [f2fs-dev] [PATCH] f2fs: Fix slab-out-of-bounds Read KASAN bug in f2fs_getxattr()

2025-01-08 Thread Chao Yu via Linux-f2fs-devel
Hi Qasim, On 2025/1/8 07:03, qasdev wrote: In f2fs_getxattr(), the function lookup_all_xattrs() allocates a 12-byte (base_size) buffer for an inline extended attribute. However, when __find_inline_xattr() calls __find_xattr(), it uses the macro "list_for_each_xattr(entry, addr)", which starts by