Re: [f2fs-dev] [PATCH] vfs: remove the excl argument from the ->create() inode_operation

2025-11-05 Thread NeilBrown
On Thu, 06 Nov 2025, Jeff Layton wrote: > Since ce8644fcadc5 ("lookup_open(): expand the call of vfs_create()"), > the "excl" argument to the ->create() inode_operation is always set to > true. Remove it, and fix up all of the create implementations. nonono > @@ -3802,7 +3802,7 @@ static struct

[f2fs-dev] [PATCH] vfs: remove the excl argument from the ->create() inode_operation

2025-11-05 Thread Jeff Layton via Linux-f2fs-devel
better prompts. In any case, I'm not sure how to properly attribute this (or if I even need to). [1]: https://lore.kernel.org/linux-nfs/[email protected]/ --- fs/9p/vfs_inode.c | 2 +- fs/9p/vfs_inode_dotl.c | 2 +- fs/affs/affs.h | 2 +-

Re: [f2fs-dev] [syzbot] [iomap?] kernel BUG in folio_end_read (2)

2025-11-05 Thread John Ogness
On 2025-11-05, Petr Mladek wrote: > I guess that we should do: > > From f9cae42b4a910127fb7694aebe2e46247dbb0fcb Mon Sep 17 00:00:00 2001 > From: Petr Mladek > Date: Wed, 5 Nov 2025 17:14:57 +0100 > Subject: [PATCH] printk_ringbuffer: Fix check of valid data size when blk_lpos > overflows > > Th

Re: [f2fs-dev] [syzbot] [iomap?] kernel BUG in folio_end_read (2)

2025-11-05 Thread Petr Mladek via Linux-f2fs-devel
On Wed 2025-11-05 16:00:28, John Ogness wrote: > On 2025-11-04, Petr Mladek wrote: > > Adding John into Cc. > > Thanks. > > > It rather looks like an internal bug in the printk_ringbuffer code. > > And there is only one recent patch: > > > >https://patch.msgid.link/20250905144152.9137-2-d-ta

Re: [f2fs-dev] [syzbot] [iomap?] kernel BUG in folio_end_read (2)

2025-11-05 Thread John Ogness
On 2025-11-04, Petr Mladek wrote: > Adding John into Cc. Thanks. > It rather looks like an internal bug in the printk_ringbuffer code. > And there is only one recent patch: > >https://patch.msgid.link/[email protected] > > The scenario leading to the WARN() is n

Re: [f2fs-dev] [PATCH v4 2/2] f2fs: Add sanity checks before unlinking and loading inodes

2025-11-05 Thread Chao Yu via Linux-f2fs-devel
On 11/5/25 19:09, Nikola Z. Ivanov wrote: > Add check for inode->i_nlink == 1 for directories during unlink, > as their value is decremented twice, which can trigger a warning in > drop_nlink. In such case mark the filesystem as corrupted and return > from the function call with the relevant failur

Re: [f2fs-dev] [PATCH v4 1/2] f2fs: Rename f2fs_unlink exit label

2025-11-05 Thread Chao Yu via Linux-f2fs-devel
On 11/5/25 19:09, Nikola Z. Ivanov wrote: > Rename "fail" label to "out" as it's used as a default > exit path out of f2fs_unlink as well as error path. > > Signed-off-by: Nikola Z. Ivanov Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing l

[f2fs-dev] [PATCH v4 1/2] f2fs: Rename f2fs_unlink exit label

2025-11-05 Thread Nikola Z. Ivanov
Rename "fail" label to "out" as it's used as a default exit path out of f2fs_unlink as well as error path. Signed-off-by: Nikola Z. Ivanov --- fs/f2fs/namei.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index b882771e4699..

[f2fs-dev] [PATCH v4 2/2] f2fs: Add sanity checks before unlinking and loading inodes

2025-11-05 Thread Nikola Z. Ivanov
Add check for inode->i_nlink == 1 for directories during unlink, as their value is decremented twice, which can trigger a warning in drop_nlink. In such case mark the filesystem as corrupted and return from the function call with the relevant failure return value. Additionally add the check for i_

[f2fs-dev] [PATCH v4 0/2] f2fs: Add sanity checks before unlinking and loading inodes

2025-11-05 Thread Nikola Z. Ivanov
This series is provoked by syzbot warnings caused by corrupted directory inode with i_nlink == 1 that passes the initial sanity check which will only mark the filesystem as corrupted in case i_nlink == 0. Tests: - fio/fsmark parallel create/unlink on VM with f2fs root filesystem. - syzbot Changel

Re: [f2fs-dev] [PATCH v4] f2fs-tools: revert summary entry count from 2048 to 512 in 16kb block support

2025-11-05 Thread Chao Yu via Linux-f2fs-devel
On 11/5/25 00:22, Daeho Jeong wrote: > From: Daeho Jeong > > The recent increase in the number of Segment Summary Area (SSA) entries > from 512 to 2048 was an unintentional change in logic of 16kb block > support. This commit corrects the issue. > > To better utilize the space available from the

Re: [f2fs-dev] [PATCH] f2fs: revert summary entry count from 2048 to 512 in 16kb block support

2025-11-05 Thread Chao Yu via Linux-f2fs-devel
On 11/5/25 00:24, Daeho Jeong wrote: > From: Daeho Jeong > > The recent increase in the number of Segment Summary Area (SSA) entries > from 512 to 2048 was an unintentional change in logic of 16kb block > support. This commit corrects the issue. > > To better utilize the space available from the

Re: [f2fs-dev] [PATCH v2] f2fs: fix age extent cache insertion skip on counter overflow

2025-11-05 Thread Chao Yu via Linux-f2fs-devel
Jaegeuk, Just in case, you may missed this patch. On 10/27/25 17:23, Xiaole He wrote: > The age extent cache uses last_blocks (derived from > allocated_data_blocks) to determine data age. However, there's a > conflict between the deletion > marker (last_blocks=0) and legitimate last_blocks=0 case