Re: [f2fs-dev] [PATCH] f2fs: optimize trace_f2fs_write_checkpoint with enums

2025-11-18 Thread Chao Yu via Linux-f2fs-devel
On 11/18/25 14:21, YH Lin wrote: > This patch optimizes the tracepoint by replacing these hardcoded strings > with a new enumeration f2fs_cp_phase. > > 1.Defines enum f2fs_cp_phase with values for each checkpoint phase. > 2.Updates trace_f2fs_write_checkpoint to accept a u16 phase argument > inste

Re: [f2fs-dev] [RFC PATCH] block: change __blkdev_issue_discard() return type to void

2025-11-18 Thread Chaitanya Kulkarni via Linux-f2fs-devel
On 11/18/25 00:04, Christoph Hellwig wrote: > On Mon, Nov 17, 2025 at 11:42:43PM -0800, Chaitanya Kulkarni wrote: >> Due to involvement of all the subsystem making it as an RFC, ideally >> it shuoldn't be an RFC. > I think best would be a series that drops error checking first, > and then changes t

[f2fs-dev] [PATCH v1] mkfs.f2fs: fix incorrect start_sector detection due to typo in HDIO_GETGEO macro check

2025-11-18 Thread Xiaole He
The code was checking for a non-existent macro `HDIO_GETGIO` instead of `HDIO_GETGEO`, which caused the ioctl() call to never be executed. This resulted in start_sector always being set to 0, even when the partition actually starts at a different sector (e.g., 2048). This bug affects: - lib/libf2f

Re: [f2fs-dev] [RFC PATCH] block: change __blkdev_issue_discard() return type to void

2025-11-18 Thread Christoph Hellwig
On Mon, Nov 17, 2025 at 11:42:43PM -0800, Chaitanya Kulkarni wrote: > Due to involvement of all the subsystem making it as an RFC, ideally > it shuoldn't be an RFC. I think best would be a series that drops error checking first, and then changes the return type. That way we can maybe get all the