[CC: overlayfs]
On Sat, Dec 23, 2023 at 8:20 AM Amir Goldstein wrote:
>
> On Sat, Dec 23, 2023 at 6:23 AM Gabriel Krisman Bertazi
> wrote:
> >
> > Eric Biggers writes:
> >
> > > On Fri, Dec 15, 2023 at 04:16:00PM -0500, Gabriel Krisman Bertazi wrote:
>
e first
> d_revalidate to happen before the check, so I'll adopt that.
>
> While looking into overlayfs, I found another reason we would need this
> patchset. A side effect of not configuring ->d_op through s_d_op is
> that the root dentry won't have d_op set. While thi
Hi Edward,
Thanks for the quick fix, but it is incorrect.
On Sun, Dec 17, 2023 at 10:11 AM Edward Adam Davis wrote:
>
> workdir and destdir could be the same when copying up to indexdir.
This is not the reason for the bug, the reason is:
syzbot exercised the forbidden practice of moving th
On Sun, Dec 17, 2023 at 1:19 AM syzbot
wrote:
>
> syzbot has bisected this issue to:
>
> commit c63e56a4a6523fcb1358e1878607d77a40b534bb
> Author: Amir Goldstein
> Date: Wed Aug 16 09:42:18 2023 +
>
> ovl: do not open/llseek lower file with upper sb_writer
On Fri, Sep 29, 2023 at 3:19 AM Linus Torvalds
wrote:
...
> So yes, real programs to cache stat information, and it matters for
> performance.
>
> But I don't think any actual reasonable program will have
> *correctness* issues, though -
I beg to disagree.
> because there are certainly filesyst
On Thu, Sep 28, 2023 at 8:19 PM Darrick J. Wong wrote:
>
> On Thu, Sep 28, 2023 at 01:06:03PM -0400, Jeff Layton wrote:
> > On Thu, 2023-09-28 at 11:48 -0400, Arnd Bergmann wrote:
> > > On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote:
> > > > This shaves 8 bytes off struct inode, according to pa
On Thu, Sep 28, 2023 at 2:06 PM Jeff Layton wrote:
>
> The recent change to use discrete integers instead of struct timespec64
> in struct inode shaved 8 bytes off of it, but it also moves the i_lock
> into the previous cacheline, away from the fields that it protects.
>
> Move i_blocks up above t
On Thu, May 25, 2023 at 1:17 PM Jan Kara wrote:
>
> Currently lock_two_nondirectories() is skipping any passed directories.
> After vfs_rename() uses lock_two_inodes(), all the remaining four users
> of this function pass only regular files to it. So drop the somewhat
> unusual "skip directory" lo
On Wed, Aug 28, 2019 at 11:15 AM Jan Kara via samba-technical
wrote:
>
> On Tue 20-08-19 11:06:48, Mark Salyzyn wrote:
> > diff --git a/Documentation/filesystems/Locking
> > b/Documentation/filesystems/Locking
> > index 204dd3ea36bb..e2687f21c7d6 100644
> > --- a/Documentation/filesystems/Locking
ints on supposedly immutable files. Therefore, reject setflags
> and fssetxattr calls on an immutable file if the file is immutable and
> will remain that way.
>
> Signed-off-by: Darrick J. Wong
> ---
> v2: use memcmp instead of open coding a bunch of checks
Thanks,
Reviewed-b
On Fri, Jun 28, 2019 at 9:37 PM Darrick J. Wong wrote:
>
> From: Darrick J. Wong
>
> The chattr manpage has this to say about immutable files:
>
> "A file with the 'i' attribute cannot be modified: it cannot be deleted
> or renamed, no link can be created to this file, most of the file's
> metada
On Thu, Mar 7, 2019 at 12:12 AM Dave Chinner wrote:
>
> On Wed, Mar 06, 2019 at 09:44:54AM +0200, Amir Goldstein wrote:
> > > > >
> > > > > Oh, wait, we *already have that infrastructure*: src/fsync-tester.c
> > > > > and generic/311.
> > &
> > >
> > > Oh, wait, we *already have that infrastructure*: src/fsync-tester.c
> > > and generic/311.
> > >
Right now 311 is not "quick".
That means adding quick tests to it without breaking it up or declaring it quick
is not a good idea.
> > > Can we please consider rolling all of these "do som
On Fri, Feb 15, 2019 at 4:23 AM Darrick J. Wong wrote:
>
> From: Darrick J. Wong
>
> d_tmpfile was introduced to instantiate an inode in the dentry cache as
> a temporary file. This helper decrements the inode's nlink count and
> dirties the inode, presumably so that filesystems could call new_i
On Mon, Apr 16, 2018 at 3:10 AM, Vijay Chidambaram wrote:
[...]
> Consider the following workload:
>
> creat foo
> link (foo, A/bar)
> fsync(foo)
> crash
>
> In this case, after the file system recovers, do we expect foo's link
> count to be 2 or 1? I would say 2, but POSIX is silent on this,
On Fri, Apr 13, 2018 at 3:54 PM, Vijay Chidambaram wrote:
> Hi Amir,
>
> Thanks for the reply!
>
> On Fri, Apr 13, 2018 at 12:52 AM, Amir Goldstein wrote:
>>
>> Not a bug.
>>
>> From man 2 fsync:
>>
>> "Calling fsync() does not necessari
On Thu, Apr 12, 2018 at 8:51 PM, Jayashree Mohan
wrote:
> Hi,
>
> We came across what seems to be a crash consistency bug on btrfs and
> f2fs. When we create a symlink for a file and fsync the symlink, on
> recovery from crash, the fsync-ed file is missing.
>
> You can reproduce this behaviour usi
On Sat, Sep 16, 2017 at 1:12 AM, Theodore Ts'o wrote:
> On Fri, Sep 15, 2017 at 11:44:33AM -0700, Jaegeuk Kim wrote:
>>
>> So, I digged it in more detail, and found, in drivers/android/binder.c [1],
>> - binder_ioctl()
>> - create a kernel thread
>> - zombie_cleanup_check()
>> - binder_defer_w
On Thu, Apr 27, 2017 at 8:45 PM, Eric Biggers wrote:
> On Thu, Apr 27, 2017 at 09:37:18AM +0200, Richard Weinberger wrote:
>> > +FSCRYPT: FILE SYSTEM LEVEL ENCRYPTION SUPPORT
>> > M: Theodore Y. Ts'o
>> > M: Jaegeuk Kim
>>
>> IMHO we should also add such an entry, to match reality:
>>
19 matches
Mail list logo
