Re: [f2fs-dev] [PATCH 86/87] fs: switch timespec64 fields in inode to discrete integers

On Thu, Sep 28, 2023, at 07:05, Jeff Layton wrote: > This shaves 8 bytes off struct inode, according to pahole. > > Signed-off-by: Jeff Layton FWIW, this is similar to the approach that Deepa suggested back in 2016:

Re: [f2fs-dev] [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

On Mon, Nov 14, 2022, at 10:23, Zhiguo Niu wrote: > Arnd Bergmann 于2022年11月11日周五 17:57写道： > so I just modify struct victim_entry as your suggestion: > diff --git a/fs/f2fs/gc.h b/fs/f2fs/gc.h > index 19b956c2d697..e2f25b8fd865 100644 > --- a/fs/f2fs/gc.h > +++ b/fs/f2fs/gc.h

Re: [f2fs-dev] [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

On Fri, Nov 11, 2022, at 10:40, Zhiguo Niu wrote: > Arnd Bergmann 于2022年11月10日周四 21:45写道： > I thinks the gcc complier build warning : > > In file included from fs/f2fs/segment.c:24: >>> fs/f2fs/gc.h:73:1:

Re: [f2fs-dev] [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

On Thu, Nov 10, 2022, at 11:20, Zhiguo Niu wrote: > Arnd Bergmann 于2022年11月10日周四 17:07写道： >> On Thu, Nov 10, 2022, at 09:33, kernel test robot wrote: >> > base: >> > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git >> > dev-

Re: [f2fs-dev] [PATCH V2] f2fs: fix atgc bug on issue in 32bits platform

On Thu, Nov 10, 2022, at 09:33, kernel test robot wrote: > Hi zhiguo.niu", > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on jaegeuk-f2fs/dev-test] > [also build test WARNING on linus/master v6.1-rc4 next-20221109] > [If your patch is applied to the wrong

[f2fs-dev] [PATCH] f2fs: fix unused function warning

From: Arnd Bergmann The f2fs_compress_set_level() function is only used for zstd and lz4 compression modes, and otherwise causes a compile-time warning for having no users. Change the #ifdef check to match what calls it. Fixes: c08e95fc6466 ("f2fs: compress: support compress level")

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

On Thu, May 21, 2020 at 11:22 AM Naresh Kamboju wrote: > On Thu, 21 May 2020 at 00:39, Chris Down wrote: > > Since you have i386 hardware available, and I don't, could you please apply > > only "avoid stale protection" again and check if it only happens with that > > commit, or requires both?

Re: [f2fs-dev] mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

On Tue, May 19, 2020 at 9:52 AM Michal Hocko wrote: > > On Mon 18-05-20 19:40:55, Naresh Kamboju wrote: > > Thanks for looking into this problem. > > > > On Sat, 2 May 2020 at 02:28, Andrew Morton > > wrote: > > > > > > On Fri, 1 May 2020 18:08:28 +0530 Naresh Kamboju > > > wrote: > > > > > >

[PATCH v6 30/43] fs: compat_ioctl: move FITRIM emulation into file systems

-by: Arnd Bergmann --- fs/compat_ioctl.c | 2 -- fs/ecryptfs/file.c | 1 + fs/ext4/ioctl.c| 1 + fs/f2fs/file.c | 1 + fs/hpfs/dir.c | 1 + fs/hpfs/file.c | 1 + fs/nilfs2/ioctl.c | 1 + fs/ocfs2/ioctl.c | 1 + 8 files changed, 7 insertions(+), 2 deletions(-) diff --git a/fs

Re: [f2fs-dev] [GIT PULL RESEND] vfs: Add support for timestamp limits

On Fri, Aug 30, 2019 at 5:48 PM Deepa Dinamani wrote: > > [resending, rebased onto linux v5.3-rc6, and dropped orangefs patch from the > series] > > Hi Al, Arnd, > > This is a pull request for filling in min and max timestamps for filesystems. > I've added all the acks, and dropped the adfs

Re: [f2fs-dev] [GIT PULL] vfs: Add support for timestamp limits

On Fri, Aug 30, 2019 at 4:02 AM Deepa Dinamani wrote: > On Thu, Aug 29, 2019 at 6:20 PM Mike Marshall wrote: > > > > Hi Deepa... > > > > I installed this patch series on top of Linux 5.3-rc6 and ran xfstests > > on orangefs and got a regression... generic/258 failed > > with: "Timestamp

[f2fs-dev] [PATCH v5 04/18] fs: compat_ioctl: move FITRIM emulation into file systems

Remove the special case for FITRIM, and make file systems handle that like all other ioctl commands with their own handlers. Signed-off-by: Arnd Bergmann --- fs/compat_ioctl.c | 2 -- fs/ecryptfs/file.c | 1 + fs/ext4/ioctl.c| 1 + fs/f2fs/file.c | 1 + fs/hpfs/dir.c | 1 + fs

[f2fs-dev] [PATCH v5 00/18] compat_ioctl.c removal, part 2/3

to ppp_generic Arnd Bergmann (16): xfs: compat_ioctl: use compat_ptr() xfs: compat_ioctl: add missing conversions gfs2: add compat_ioctl support fs: compat_ioctl: move FITRIM emulation into file systems watchdog: cpwd: use generic compat_ptr_ioctl compat_ioctl: move WDIOC handling into wdt

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit linking

On Fri, Jun 28, 2019 at 5:59 PM Jaegeuk Kim wrote: > > Hi Arnd, > > If you don't mind, can I integrate this into the original patch in the queue? Yes, I think that would be good anyway, it may take a little longer to fix all the architectures. Arnd

Re: [PATCH] f2fs: fix 32-bit linking

On Fri, Jun 28, 2019 at 3:17 PM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 03:09:47PM +0200, Arnd Bergmann wrote: > > I came across this on arm-nommu (which disables > > CONFIG_CPU_SPECTRE) during randconfig testing. > > > > I don't see an easy w

Re: [PATCH] f2fs: fix 32-bit linking

On Fri, Jun 28, 2019 at 2:44 PM Christoph Hellwig wrote: > > On Fri, Jun 28, 2019 at 12:39:52PM +0200, Arnd Bergmann wrote: > > Not all architectures support get_user() with a 64-bit argument: > > Which architectures are still missing? I think we finally need to > get eve

[f2fs-dev] [PATCH] f2fs: fix 32-bit linking

Not all architectures support get_user() with a 64-bit argument: ERROR: "__get_user_bad" [fs/f2fs/f2fs.ko] undefined! Use copy_from_user() here, this will always work. Fixes: d2ae7494d043 ("f2fs: ioctl for removing a range from F2FS") Signed-off-by: Arnd Bergmann --- fs/f2

[f2fs-dev] [PATCH] f2fs: rework fault injection handling to avoid a warning

it, but the more reliable way of doing this seems to be to remove the other #ifdefs where that is easily possible. By defining time_to_inject() as a trivial stub, most of the checks for CONFIG_F2FS_FAULT_INJECTION can go away. This also leads to nicer formatting of the code. Signed-off-by: Arnd Bergmann

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

On Wed, Jul 25, 2018 at 5:21 PM, Chao Yu wrote: > On 2018/7/24 17:34, Arnd Bergmann wrote: >> On 32-bit targets, size_t is often 'unsigned int', so printing it as %lu >> causes a warning: >> >> fs/f2fs/inode.c: In function 'sanity_check_inode': >> fs/f2fs/

[f2fs-dev] [PATCH] f2fs: fix 32-bit format string warning

=] The correct format string is %zu. Fixes: ba3a252d3367 ("f2fs: fix to do sanity check with i_extra_isize") Signed-off-by: Arnd Bergmann --- fs/f2fs/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 3fe63b0c7325..4fd339fd3

Re: [f2fs-dev] [PATCH] [RESEND] f2fs: use timespec64 for inode timestamps

On Fri, Jul 13, 2018 at 6:10 PM, Jaegeuk Kim wrote: > Hi Arnd, > > I queued in the testing branch, since I'm trying to fix another issue in > -next. > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test=2cdbbf025aac9f3dd54b9dec0a6603839a3171d3 > > Allow me to

[f2fs-dev] [PATCH] [RESEND] f2fs: use timespec64 for inode timestamps

The on-disk representation and the vfs both use 64-bit tv_sec values, so let's change the last missing piece in the middle. Reviewed-by: Chao Yu Signed-off-by: Arnd Bergmann --- I sent this on Jun 20 and got an Ack, but nobody picked up the patch into linux-next. Could you merge this for 4.19

[f2fs-dev] [PATCH] f2fs: use timespec64 for inode timestamps

The on-disk representation and the vfs both use 64-bit tv_sec values, so let's change the last missing piece in the middle. Signed-off-by: Arnd Bergmann --- fs/f2fs/f2fs.h | 16 ++-- fs/f2fs/inode.c | 12 ++-- fs/f2fs/namei.c | 2 +- 3 files changed, 13 insertions(+), 17

[f2fs-dev] [PATCH] f2fs: avoid using timespec

All uses of timespec are deprecated, and this one is not particularly useful, as the documented method for converting seconds to jiffies is to multiply by 'HZ'. Signed-off-by: Arnd Bergmann <a...@arndb.de> --- fs/f2fs/f2fs.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[f2fs-dev] [PATCH] f2fs: use extra parenthesis around assignment/condition

=parentheses] while (nr_pages = pagevec_lookup_tag(, mapping, , This seems reasonable, so let's do that. Fixes: 4aba7297f4a5 ("f2fs: simplify page iteration loops") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- The warning is from mmotm. Andrew, please fold this fix into the p

Re: [f2fs-dev] [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

On Fri, Jun 2, 2017 at 2:18 PM, Yan, Zheng <uker...@gmail.com> wrote: > On Fri, Jun 2, 2017 at 7:33 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng <uker...@gmail.com> wrote: >> What I meant is another related problem in

Re: [f2fs-dev] [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

On Fri, Jun 2, 2017 at 1:18 PM, Yan, Zheng <uker...@gmail.com> wrote: > On Fri, Jun 2, 2017 at 6:51 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng <uker...@gmail.com> wrote: >>> On Fri, Jun 2, 2017 at 5:45 PM,

Re: [f2fs-dev] [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

On Fri, Jun 2, 2017 at 12:10 PM, Yan, Zheng <uker...@gmail.com> wrote: > On Fri, Jun 2, 2017 at 5:45 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Fri, Jun 2, 2017 at 4:09 AM, Yan, Zheng <uker...@gmail.com> wrote: >>> On Fri, Jun 2, 2017 at 8:57 AM, De

Re: [f2fs-dev] [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

26 PM, Yan, Zheng <uker...@gmail.com> wrote: >>>> On Thu, Jun 1, 2017 at 6:22 PM, Arnd Bergmann <a...@arndb.de> wrote: >>>>> On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng <uker...@gmail.com> wrote: >>>>>> On Sat, Apr 8, 2017 at 8:57 AM, Deep

Re: [f2fs-dev] [PATCH 04/12] fs: ceph: CURRENT_TIME with ktime_get_real_ts()

On Thu, Jun 1, 2017 at 11:56 AM, Yan, Zheng wrote: > On Sat, Apr 8, 2017 at 8:57 AM, Deepa Dinamani wrote: >> diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c >> index 517838b..77204da 100644 >> --- a/drivers/block/rbd.c >> +++

Re: [f2fs-dev] [PATCH 06/12] audit: Use timespec64 to represent audit timestamps

On Sat, Apr 8, 2017 at 5:58 PM, Deepa Dinamani wrote: >> I have no problem merging this patch into audit/next for v4.12, would >> you prefer me to do that so at least this patch is merged? > > This would be fine. > But, I think whoever takes the last 2 deletion patches

Re: [f2fs-dev] [PATCH] f2fs: fix 32-bit build

On Wednesday, November 23, 2016 10:42:26 AM CET Jaegeuk Kim wrote: > > Unfortunately, the sector number is usually a 64-bit number, and > we guarantee that bdev_zone_size() returns a power-of-two number. The sentence no longer makes sense. Maybe Fortunately, bdev_zone_size() is guaranteed to

[f2fs-dev] [PATCH] f2fs: fix 32-bit build

is usually a 64-bit number, and we probably can't guarantee that bdev_zone_size() returns a power-of-two number, so we actually have to do the expensive 64-bit operation to get the remainder. Fixes: 792b84b74b54 ("f2fs: support multiple devices") Signed-off-by: Arnd Bergmann <a...@arnd

Re: [f2fs-dev] [PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

On Wednesday 02 November 2016, Chao Yu wrote: > Hi Arnd, Jaegeuk, > > It is trivial, but it's better keep commit *title*, commit log and code > consistent. :) Sorry for my silly mistake, sent it again with a new subject now. Arnd

[f2fs-dev] [PATCH v2] f2fs: replace a build-time warning with runtime WARN_ON

port in batch multi blocks preallocation") Signed-off-by: Arnd Bergmann <a...@arndb.de> --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) v2: use simpler workaround, as discussed with Chao Yu. diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 68edb47f5f71..cf5e

Re: [f2fs-dev] [PATCH 04/28] f2fs: replace a build-time warning with runtime WARN_ON

On Wednesday, October 26, 2016 10:05:00 PM CEST Chao Yu wrote: > On 2016/10/18 6:05, Arnd Bergmann wrote: > > gcc is unsure about the use of last_ofs_in_node, which might happen > > without a prior initialization: > > > > fs/f2fs//git/arm-soc/fs/f2fs/data.c: In functio

[f2fs-dev] [PATCH 28/28] Kbuild: bring back -Wmaybe-uninitialized warning

send them for inclusion in v4.10. Link: https://rusty.ozlabs.org/?p=232 [1] Link: https://gcc.gnu.org/wiki/Better_Uninitialized_Warnings [2] Signed-off-by: Arnd Bergmann <a...@arndb.de> --- Makefile | 10 ++ arch/arc/Makefile | 4 +++- scripts/Makefile.ubsan |

[f2fs-dev] [PATCH 00/28] Reenable maybe-uninitialized warnings

Arnd Bergmann (28): [v2] netfilter: nf_tables: avoid uninitialized variable warning [v2] mtd: mtk: avoid warning in mtk_ecc_encode [v2] infiniband: shut up a maybe-uninitialized warning f2fs: replace a build-time warning with runtime WARN_ON ext2: avoid bogus -Wmaybe-uninitialized warning

[f2fs-dev] [PATCH 04/28] f2fs: replace a build-time warning with runtime WARN_ON

ch could just be disregarded. It would certainly be helpful to get an opinion from the maintainers on the matter. Fixes: 46008c6d4232 ("f2fs: support in batch multi blocks preallocation") Cc: Chao Yu <yuch...@huawei.com> Cc: Jaegeuk Kim <jaeg...@kernel.org> Signed-off-by

Re: [f2fs-dev] [GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

On Monday, August 15, 2016 6:23:12 PM CEST Greg KH wrote: > On Sat, Aug 13, 2016 at 03:48:12PM -0700, Deepa Dinamani wrote: > > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC > > macros. > > The macros are not y2038 safe. There is no plan to transition them into > >

Re: [f2fs-dev] [Y2038] [PATCH v3 00/24] Delete CURRENT_TIME_SEC and replace current_fs_time()

; y2038 safe. > ktime_get_* api's can be used in their place. And, these are y2038 safe. > > CURRENT_TIME will be deleted after 4.8 rc1 as there is a dependency function > time64_to_tm() for one of the CURRENT_TIME occurance. > > Thanks to Arnd Bergmann for all the guidance and disc

Re: [f2fs-dev] [Y2038] [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

in their place. And, these are y2038 safe. > > Thanks to Arnd Bergmann for all the guidance and discussions. > > Patches 2-4 were mostly generated using coccinelle scripts. > > All filesystem timestamps use current_fs_time() for right granularity as > mentioned in the respecti

Re: [f2fs-dev] [Y2038] [PATCH v2 00/24] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

On Monday, June 20, 2016 11:03:01 AM CEST you wrote: > On Sun, Jun 19, 2016 at 5:26 PM, Deepa Dinamani > wrote: > > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC > > macros. > Gcc handles 8-byte structure returns (on most architectures) by >

Re: [f2fs-dev] [PATCH 04/21] fs: Replace CURRENT_TIME with current_fs_time() for inode timestamps

On Wednesday, June 8, 2016 10:04:48 PM CEST Deepa Dinamani wrote: > > Signed-off-by: Deepa Dinamani > Cc: Steve French > Cc: linux-c...@vger.kernel.org > Cc: samba-techni...@lists.samba.org > Cc: Joern Engel > Cc: Prasad Joshi

[f2fs-dev] [PATCH] f2fs: add missing argument to f2fs_setxattr stub

prototype of the empty stub function to match that of the actual implementation. This will not make the key management work when F2FS_FS_XATTR is disabled, but it gets it to build at least. Signed-off-by: Arnd Bergmann <a...@arndb.de> Fixes: 1448eee67def ("f2fs: support access control via key mana

[f2fs-dev] [PATCH] f2fs: fix building on 32-bit architectures

to annotate that this is an expensive operation. As the function is only called for debug out, we know this is not performance critical, so it is safe to use div_u64. Signed-off-by: Arnd Bergmann a...@arndb.de Fixes: d1f85bd38db19 (f2fs: avoid value overflow in showing current status

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Wednesday 04 June 2014 17:10:24 H. Peter Anvin wrote: On 06/04/2014 12:24 PM, Arnd Bergmann wrote: For other timekeeping stuff in the kernel, I agree that using some 64-bit representation (nanoseconds, 32/32 unsigned seconds/nanoseconds, ...) has advantages, that's exactly the point I

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Tuesday 03 June 2014, Dave Chinner wrote: On Tue, Jun 03, 2014 at 04:22:19PM +0200, Arnd Bergmann wrote: On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: On 06/02/2014 12:55 PM, Arnd Bergmann wrote: The possible uses I can see for non-ktime_t types in the kernel are: * inodes

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Wednesday 04 June 2014 13:30:32 Nicolas Pitre wrote: On Wed, 4 Jun 2014, Arnd Bergmann wrote: On Tuesday 03 June 2014, Dave Chinner wrote: Just ot be pedantic, inodes don't need 96 bit timestamps - some filesystems can *support up to* 96 bit timestamps. If the kernel only supports

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: On 06/02/2014 12:55 PM, Arnd Bergmann wrote: The bit that is really going to hurt is every single ioctl that uses a timespec. Honestly, though, I really don't understand the point with struct inode_time. It seems like the zeroeth

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Tuesday 03 June 2014 14:33:10 Joseph S. Myers wrote: On Tue, 3 Jun 2014, Arnd Bergmann wrote: I think John Stultz and Thomas Gleixner have already started looking at how the timekeeping code can be updated. Once that is done, we should be able to add a functional 64-bit gettimeofday

Re: [f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

On Monday 02 June 2014 12:26:22 H. Peter Anvin wrote: On 06/02/2014 12:19 PM, Arnd Bergmann wrote: On Monday 02 June 2014 13:52:19 Joseph S. Myers wrote: On Fri, 30 May 2014, Arnd Bergmann wrote: a) is this the right approach in general? The previous discussion pointed this way

[f2fs-dev] [RFC 00/32] making inode time stamps y2038 ready

to cover. c) Should we continue this way for all 32-bit platforms for consistency, including future ones, or should we go to different 64-bit types right away? My feeling is that the second approach would complicate this work. Arnd [1] http://kernelnewbies.org/y2038 Arnd Bergmann