Hi Jaegeuk Kim and Chao Yu,
On 11/24/25 23:11, Chao Yu wrote:
> On 11/25/2025 2:33 PM, Christoph Hellwig wrote:
>> On Tue, Nov 25, 2025 at 09:10:00AM +0800, Chao Yu wrote:
>>> Reviewed-by: Chao Yu
>>
>> Sending these all as a series might be confusing - it would be good
>> if the individual patch
On 11/25/25 18:37, Yongpeng Yang wrote:
>> diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c
>> index 6917de832191..b6ffe4807a11 100644
>> --- a/fs/xfs/xfs_discard.c
>> +++ b/fs/xfs/xfs_discard.c
>> @@ -108,7 +108,7 @@ xfs_discard_endio(
>> * list. We plug and chain the bios so that we on
On 11/25/25 18:47, Chao Yu wrote:
> On 11/25/25 07:48, Chaitanya Kulkarni wrote:
>> __blkdev_issue_discard() always returns 0, making the error assignment
>> in __submit_discard_cmd() dead code.
>>
>> Initialize err to 0 and remove the error assignment from the
>> __blkdev_issue_discard() call to e
On 11/18/25 00:04, Christoph Hellwig wrote:
> On Mon, Nov 17, 2025 at 11:42:43PM -0800, Chaitanya Kulkarni wrote:
>> Due to involvement of all the subsystem making it as an RFC, ideally
>> it shuoldn't be an RFC.
> I think best would be a series that drops error checking first,
> and then changes t
On 4/14/22 21:52, Christoph Hellwig wrote:
> Move all the logic to limit the discard bio size into a common helper
> so that it is better documented.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
> Acked-by: Coly Li
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to query the number of sectors support per each discard bio
> based on the block device and use this helper to stop various places from
> poking into the request_queue to see if discard is supported and if so how
> much. This mirrors what i
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to check the FUA flag based on the block_device instead of
> having to poke into the block layer internal request_queue.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
Looks good.
Reviewed-by: Chaitanya Kulkarni
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to check the nonrot flag based on the block_device instead
> of having to poke into the block layer internal request_queue.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
> Acked-by: David Sterba [btrfs]
> ---
Lo
On 4/14/22 21:52, Christoph Hellwig wrote:
> Use the bdev based helper instead of poking into the queue.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
On 4/14/22 21:52, Christoph Hellwig wrote:
> Just use a non-zero max_discard_sectors as an indicator for discard
> support, similar to what is done for write zeroes.
>
> The only places where needs special attention is the RAID5 driver,
> which must clear discard support for security reasons by de
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to check the write cache flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
> Acked-by: David Sterba [btrfs]
> --
On 4/14/22 21:52, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Johannes Thumshirn
> Acked-by: David Sterba
> ---
Looks good.
Reviewed-by: Chaitanya Kulkarni
-ck
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@list
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to check the stable writes flag based on the block_device
> instead of having to poke into the block layer internal request_queue.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
> ---
Looks good.
Reviewed-by: Cha
On 4/14/22 21:52, Christoph Hellwig wrote:
> Use the proper bdev_discard_alignment helper that accounts for partition
> offsets.
>
> Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6")
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
> ---
Helper does handl
On 4/14/22 21:52, Christoph Hellwig wrote:
> Replace the open coded offset calculation with the proper helper.
> This is an ABI change in that the -1 for a misaligned partition is
> properly propagated, which can be considered a bug fix and matches
> what is done on the whole device.
>
> Signed-of
On 4/14/22 21:52, Christoph Hellwig wrote:
> Add a helper to check the max supported sectors for zone append based on
> the block_device instead of having to poke into the block layer internal
> request_queue.
>
> Signed-off-by: Christoph Hellwig
> Acked-by: Damien Le Moal
> Reviewed-by: Martin
On 4/14/22 21:52, Christoph Hellwig wrote:
> Secure erase is a very different operation from discard in that it is
> a data integrity operation vs hint. Fully split the limits and helper
> infrastructure to make the separation more clear.
>
> Signed-off-by: Christoph Hellwig
> Reviewed-by: Marti
On 4/14/22 21:52, Christoph Hellwig wrote:
> The SCSI target drivers is a consumer of the block layer and shoul
> d generally work on struct block_device.
> > Signed-off-by: Christoph Hellwig
> Reviewed-by: Martin K. Petersen
Except from split word in log "should", looks good.
Reviewed-by: Cha
On 4/14/22 21:52, Christoph Hellwig wrote:
> For block devices, the SCSI target drivers implements UNMAP as calls to
> blkdev_issue_discard, which does not guarantee zeroing just because
> Write Zeroes is supported.
>
> Note that this does not affect the file backed path which uses
> fallocate to
On 2/10/22 10:11 PM, Eric Biggers wrote:
> From: Eric Biggers
>
> Traditionally, the conditions for when DIO (direct I/O) is supported
> were fairly simple: filesystems either supported DIO aligned to the
> block device's logical block size, or didn't support DIO at all.
>
> However, due to file
On 2/11/22 3:40 AM, Chaitanya Kulkarni wrote:
> On 2/10/22 10:11 PM, Eric Biggers wrote:
>> From: Eric Biggers
>>
>> Traditionally, the conditions for when DIO (direct I/O) is supported
>> were fairly simple: filesystems either supported DIO aligned to the
>> block device's logical block size, or
21 matches
Mail list logo
