On 2024/4/5 3:52, Jaegeuk Kim wrote:
Shutdown does not check the error of thaw_super due to readonly, which
causes a deadlock like below.
f2fs_ioc_shutdown(F2FS_GOING_DOWN_FULLSYNC)issue_discard_thread
- bdev_freeze
- freeze_super
- f2fs_stop_checkpoint()
-
Jeong
Signed-off-by: Chao Yu
---
v3:
- avoid race condition in between __submit_merged_bio()
and __allocate_new_segment().
fs/f2fs/data.c| 105 ++
fs/f2fs/f2fs.h| 34 ---
fs/f2fs/iostat.c | 7
fs/f2fs/iostat.h | 2 +
fs/f2fs
allocator.
Signed-off-by: Chao Yu
---
v2:
- rebase to last dev-test branch
fs/f2fs/segment.c | 30 ++
fs/f2fs/segment.h | 1 +
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 4fd76e867e0a..9039d60c989d 10064
FLAGS
0: [0..4095]: 147456..1515514096 0x1001
Signed-off-by: Chao Yu
---
v2:
- rebase to last dev-test branch
fs/f2fs/segment.c | 24
fs/f2fs/segment.h | 6 ++
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/seg
FLAGS
0: [0..4095]: 147456..1515514096 0x1001
Signed-off-by: Chao Yu
---
fs/f2fs/segment.c | 24
fs/f2fs/segment.h | 6 ++
2 files changed, 18 insertions(+), 12 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index ecb9ee80d5e0..ec3288381
allocator.
Signed-off-by: Chao Yu
---
fs/f2fs/segment.c | 30 ++
fs/f2fs/segment.h | 1 +
2 files changed, 23 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 4a3cf2888faf..ecb9ee80d5e0 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs
On 2024/4/7 10:11, Zhiguo Niu wrote:
On Wed, Apr 3, 2024 at 10:26 PM Chao Yu wrote:
compress and pinfile flag should be checked after inode lock held to
avoid race condition, fix it.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Fixes: 5fed0be8583f ("f2fs: do no
dsjzmwo7de...@mail.gmail.com
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 2cd4ca8433e1..ca401cf8152a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3549,9 +3549,6 @@
yjvymgyhr2+yluj0slg9ddsjzmwo7de...@mail.gmail.com
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index ca401cf8152a..232dd5fc8ab3 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4142
From: Wenjie Qi
If the max open zones of zoned devices are less than
the active logs of F2FS, the device may error due to
insufficient zone resources when multiple active logs
are being written at the same time.
Signed-off-by: Wenjie Qi
Signed-off-by: Chao Yu
---
v7:
- check
On 2024/4/4 21:47, Wang Jianjian wrote:
dquot_mark_dquot_dirty returns old dirty state not the error code.
I think it's fine to just pass return value of dquot_mark_dquot_dirty()
to caller, because caller can distinguish status from return value:
1) < 0, there is an error, 2) >= 0, there is no
On 2024/4/2 3:08, Daeho Jeong wrote:
On Thu, Mar 28, 2024 at 8:20 PM Chao Yu wrote:
max open zone may be larger than log header number of f2fs, for
such case, it doesn't need to wait last IO in previous zone, let's
introduce available_open_zone semaphore, and reduce it once we
submit first
On 2024/4/5 2:20, Daeho Jeong wrote:
On Thu, Mar 28, 2024 at 12:23 AM Chao Yu wrote:
From: Wenjie Qi
If the max open zones of zoned devices are less than
the active logs of F2FS, the device may error due to
insufficient zone resources when multiple active logs
are being written at the same
Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
ioctl(F2FS_IOC_MOVE_RANGE) can truncate or punch hole on pinned file,
fix to disallow it.
Fixes: 5fed0be8583f ("f2fs: do not allow partial truncation on pinned file")
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2f
compress and pinfile flag should be checked after inode lock held to
avoid race condition, fix it.
Fixes: 4c8ff7095bef ("f2fs: support data compression")
Fixes: 5fed0be8583f ("f2fs: do not allow partial truncation on pinned file")
Signed-off-by: Chao Yu
---
eliminate unnecessary struct use.
Signed-off-by: Zijie Wang
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2024/3/30 3:13, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage. To make it consistent across
storage devices, we disallow it regardless of storage device types.
Signed-off-by: Daeho
On 2024/3/29 14:55, Wu Bo wrote:
Consider of a f2fs system with 2 devices:
Info: Device[0] : /dev/block/dm-46 blkaddr = 0--3f
Info: Device[1] : /dev/block/dm-47 blkaddr = 40--67f
f2fs_map_blocks will return logical addr of fs when doing buffered io:
f2fs_map_blocks: dev = (254,46),
This patch adds unset subcommand for pinfile command.
Usage: f2fs_io pinfile unset [target_file]
Signed-off-by: Chao Yu
---
man/f2fs_io.8 | 2 +-
tools/f2fs_io/f2fs_io.c | 11 +--
2 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/man/f2fs_io.8 b/man/f2fs_io.8
On 2024/3/27 4:31, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage. To make it consistent across
storage devices, we disallow it regardless of storage device types.
Signed-off-by: Daeho
On 2024/3/27 16:53, Zhiguo Niu wrote:
A length that exceeds the real size of the inode may be
specified from user, although these out-of-range areas
are not mapped, but they still need to be check in
while loop, which is unnecessary.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks
Jeong
Signed-off-by: Chao Yu
---
v2:
- remove unneeded declaration.
fs/f2fs/data.c| 80 +--
fs/f2fs/f2fs.h| 33 ---
fs/f2fs/iostat.c | 7 +
fs/f2fs/iostat.h | 2 ++
fs/f2fs/segment.c | 58
Jeong
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 80 +--
fs/f2fs/f2fs.h| 34 +---
fs/f2fs/iostat.c | 7 +
fs/f2fs/iostat.h | 2 ++
fs/f2fs/segment.c | 58 ++
fs/f2fs/segment.h | 12 ++-
fs
From: Wenjie Qi
If the max open zones of zoned devices are less than
the active logs of F2FS, the device may error due to
insufficient zone resources when multiple active logs
are being written at the same time.
Signed-off-by: Wenjie Qi
Signed-off-by: Chao Yu
---
v6:
- add check condition
d-by: Yi Zhang
Fixes: 1517c1a7a445 ("f2fs: implement iomap operations")
Fixes: 8d3c1fa3fa5e ("f2fs: don't rely on F2FS_MAP_* in f2fs_iomap_begin")
Signed-off-by: Chao Yu
---
v2:
- add Tested-by tag of Yi Zhang.
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 2024/3/27 9:26, Zhiguo Niu wrote:
On Tue, Mar 26, 2024 at 7:11 PM Chao Yu wrote:
On 2024/3/25 13:56, Zhiguo Niu wrote:
A length that exceeds the real size of the inode may be
specified from user, although these out-of-range areas
are not mapped, but they still need to be check in
while
Yunlei He
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2024/3/26 21:26, Yi Zhang wrote:
I confirmed the issue was fixed now, thanks.
Tested-by: Yi Zhang
Yi, thanks for the test.
Thanks,
On Mon, Mar 25, 2024 at 11:26 PM Chao Yu wrote:
As reported by Yi Zhang in mailing list [1], kernel warning was catched
during zbd/010 test as below
- f2fs_up_write(dst)
- f2fs_down_write(dst)
- __exchange_data_block
- __clone_blkaddrs
- f2fs_get_new_data_page
- memcpy_page
Fixes: 0a2aa8fbb969 ("f2fs: refactor __exchange_data_block for speed up")
Signed-off-by: Chao Yu
---
fs/f2fs/file.c | 3 +++
1 file
On 2024/3/25 13:56, Zhiguo Niu wrote:
A length that exceeds the real size of the inode may be
specified from user, although these out-of-range areas
are not mapped, but they still need to be check in
while loop, which is unnecessary.
Signed-off-by: Zhiguo Niu
---
v2: check i_size within inode
On 2024/3/25 23:02, Daeho Jeong wrote:
On Fri, Mar 22, 2024 at 9:26 PM Chao Yu wrote:
On 2024/3/21 1:42, Daeho Jeong wrote:
On Wed, Mar 20, 2024 at 2:38 AM Chao Yu wrote:
On 2024/3/20 5:23, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee
On 2024/3/25 14:56, Shinichiro Kawasaki wrote:
On Mar 25, 2024 / 11:06, Chao Yu wrote:
On 2024/3/25 10:14, Shinichiro Kawasaki wrote:
On Mar 24, 2024 / 20:13, Chao Yu wrote:
...
Hi Shinichiro,
Can you please check below diff? IIUC, for the case: f2fs_map_blocks()
returns zero blkaddr in non
tart blkaddr =
0x, len = 0x100, flags = 4, seg_type = 1, may_create = 0, multidevice =
0, flag = 3, err = 0
f2fs_direct_IO_exit: dev = (253,16), ino = 11 pos = 0 len = 1048576 rw = 0 ret
= 1048576
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 29 +++--
1 file cha
No logic changes.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 5ef1874b572a..9c000ca4f808 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -1507,6 +1507,23
es: 1517c1a7a445 ("f2fs: implement iomap operations")
Fixes: 8d3c1fa3fa5e ("f2fs: don't rely on F2FS_MAP_* in f2fs_iomap_begin")
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index d9494b5
On 2024/3/25 10:14, Shinichiro Kawasaki wrote:
On Mar 24, 2024 / 20:13, Chao Yu wrote:
...
Hi Shinichiro,
Can you please check below diff? IIUC, for the case: f2fs_map_blocks()
returns zero blkaddr in non-primary device, which is a verified valid
block address, we'd better to check m_flags
On 2024/3/19 19:13, Shinichiro Kawasaki wrote:
On Mar 19, 2024 / 10:22, Chao Yu wrote:
On 2024/3/18 13:47, Shinichiro Kawasaki via Linux-f2fs-devel wrote:
I confirmed that the trigger commit is dbf8e63f48af as Yi reported. I took a
look in the commit, but it looks fine to me. So I thought
On 2024/3/21 1:42, Daeho Jeong wrote:
On Wed, Mar 20, 2024 at 2:38 AM Chao Yu wrote:
On 2024/3/20 5:23, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage.
Signed-off-by: Daeho Jeong
On 2024/3/22 14:03, Zhiguo Niu wrote:
A length that exceeds the real size of the inode may be
specified from user, although these out-of-range areas
are not mapped, but they still need to be check in
while loop, which is unnecessary.
Signed-off-by: Zhiguo Niu
---
fs/f2fs/file.c | 4 +++-
1
-by: Sunmin Jeong
Signed-off-by: Yeongjin Gil
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
des() may return -ENOENT, and
f2fs_truncate_inode_blocks() doesn't handle such error correctly,
fix it.
Reported-by: Roman Smirnov
Closes:
https://lore.kernel.org/linux-f2fs-devel/085b27fd2b364a3c8c3a9ca77363e...@omp.ru
Signed-off-by: Chao Yu
---
fs/f2fs/node.c | 12 +++-
1 file changed, 11 i
,: waiting
STOP_CP_REASON_SHUTDOWN);
- f2fs_stop_discard_thread(sbi);
- kthread_stop()
: waiting
- mnt_drop_write_file(filp);
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs
On 2024/3/20 5:23, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage.
Signed-off-by: Daeho Jeong
---
v2: covered the direct io case
v3: covered the mkwrite case
---
fs/f2fs/data.c | 14
On 2024/3/20 14:22, Zhiguo Niu wrote:
some user behaviors requested filesystem operations, which
will cause filesystem not idle.
Meanwhile adjust some f2fs_update_time(REQ_TIME) positions.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks
On 2024/3/18 13:47, Shinichiro Kawasaki via Linux-f2fs-devel wrote:
I confirmed that the trigger commit is dbf8e63f48af as Yi reported. I took a
look in the commit, but it looks fine to me. So I thought the cause is not
in the commit diff.
I found the WARN is printed when the f2fs is set up
On 2024/3/15 19:32, Zhiguo Niu wrote:
some user behaviors requested filesystem operations, which
will cause filesystem not idle.
Meanwhile adjust some f2fs_update_time(REQ_TIME) positions.
Signed-off-by: Zhiguo Niu
---
v2: update patch according to Chao's suggestions
---
---
fs/f2fs/file.c |
On 2024/3/15 9:46, Zhiguo Niu wrote:
On Thu, Mar 14, 2024 at 9:06 PM Chao Yu wrote:
On 2024/3/13 12:11, Zhiguo Niu wrote:
some user behaviors requested filesystem operations, which
will cause filesystem not idle.
Meanwhile adjust f2fs_update_time(REQ_TIME) of
f2fs_ioc_defragment
On 2024/3/13 12:11, Zhiguo Niu wrote:
some user behaviors requested filesystem operations, which
will cause filesystem not idle.
Meanwhile adjust f2fs_update_time(REQ_TIME) of
f2fs_ioc_defragment to successful case.
Signed-off-by: Zhiguo Niu
---
fs/f2fs/file.c | 9 -
1 file changed,
+
Reviewed-by: Sungjong Seo
Reviewed-by: Yeongjin Gil
Signed-off-by: Sunmin Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
- skip f2fs_update_inode since the inode is clean
Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
Cc: sta...@vger.kernel.org #v5.19+
Reviewed-by: Sungjong Seo
Reviewed-by: Yeongjin Gil
Signed-off-by: Sunmin Jeong
Reviewed-by: Chao Y
On 2024/3/13 9:31, Jaegeuk Kim wrote:
On 03/12, Ed Tsai (蔡宗軒) wrote:
On Mon, 2024-01-15 at 20:05 +0800, Hillf Danton wrote:
...
--- x/fs/f2fs/file.c
+++ y/fs/f2fs/file.c
@@ -39,6 +39,7 @@
static vm_fault_t f2fs_filemap_fault(struct vm_fault *vmf)
{
struct inode *inode =
e.
Fixes: 87f3afd366f7 ("f2fs: add tracepoint for f2fs_vm_page_mkwrite()")
Reported-and-tested-by: syzbot+763afad57075d3f86...@syzkaller.appspotmail.com
Closes: https://lore.kernel.org/lkml/e8222b060f00d...@google.com
Cc: Ed Tsai
Cc: Hillf Danton
Signed-off-by: Chao Yu
---
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip
On 2024/1/15 17:12, syzbot wrote:
Hello,
syzbot found the following issue on:
HEAD commit:052d534373b7 Merge tag 'exfat-for-6.8-rc1' of git://git.ke..
git tree: upstream
console output:
On 2024/3/13 4:49, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage.
Signed-off-by: Daeho Jeong
---
v2: covered the direct io case
Oh, one more missed case, mkwrite?
Thanks,
---
On 2024/3/12 7:59, Daeho Jeong wrote:
From: Daeho Jeong
In a case writing without fallocate(), we can't guarantee it's allocated
in the conventional area for zoned stroage.
Signed-off-by: Daeho Jeong
---
fs/f2fs/data.c | 7 +++
fs/f2fs/file.c | 4
2 files changed, 11
On 2024/3/12 7:59, Daeho Jeong wrote:
From: Daeho Jeong
Since atomic write way was changed to out-place-update, we should
prevent it on pinned files.
Signed-off-by: Daeho Jeong
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Ping,
On 2024/2/29 22:38, Chao Yu wrote:
Support .shutdown callback in f2fs_sops, then, it can be called to
shut down the file system when underlying block device is marked dead.
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/file.c | 70
Ping,
Jaegeuk, do you have any comments on this patch?
Thanks,
On 2024/2/26 16:00, Chao Yu wrote:
Any comments?
Thanks,
On 2024/2/19 11:13, Chao Yu wrote:
On 2024/2/8 8:18, Jaegeuk Kim wrote:
On 02/06, Chao Yu wrote:
generic/730 2s ... - output mismatch (see
/media/fstests/results
On 2024/3/11 15:48, Zhiguo Niu wrote:
{new,change}_curseg() may return error in some special cases,
error handling should be did in their callers, and this will also
facilitate subsequent error path expansion in {new,change}_curseg().
Signed-off-by: Zhiguo Niu
Signed-off-by: Chao Yu
On 2024/3/8 18:12, Zhiguo Niu wrote:
{new,change}_curseg() may return error in some special cases,
error handling should be did in their callers, and this will also
facilitate subsequent error path expansion in {new,change}_curseg().
Signed-off-by: Zhiguo Niu
Signed-off-by: Chao Yu
---
fs
On 2024/3/8 18:12, Zhiguo Niu wrote:
add_bio_entry should not trigger system panic when bio_add_page fail,
fix to remove it.
Fixes: 0b20fcec8651 ("f2fs: cache global IPU bio")
Signed-off-by: Zhiguo Niu
---
fs/f2fs/data.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff
On 2024/3/8 14:25, Zhiguo Niu wrote:
There are some cases of f2fs_is_valid_blkaddr not handled as
ERROR_INVALID_BLKADDR,so unify the error handling about all of
f2fs_is_valid_blkaddr.
Do f2fs_handle_error in __f2fs_is_valid_blkaddr for cleanup.
Signed-off-by: Zhiguo Niu
Signed-off-by: Chao Yu
On 2020/6/20 6:47, Jaegeuk Kim wrote:
diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 3268f8dd59bb..1862073b96d2 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -1250,6 +1250,7 @@ static int __clone_blkaddrs(struct inode *src_inode,
struct inode *dst_inode,
Commit 2e2c6e9b72ce ("f2fs: remove power-of-two limitation of zoned
device") missed to remove pow2 check condition in init_blkz_info(),
fix it.
Fixes: 2e2c6e9b72ce ("f2fs: remove power-of-two limitation of zoned device")
Signed-off-by: Feng Song
Signed-off-by: Yongpeng Yang
on, so
we need to use truncate_inode_pages_range() instead of
invalidate_mapping_pages() to make sure meta_inode page will be dropped.
Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC")
Fixes: e3b49ea36802 ("f2fs: invalidate META_MAPPING before IPU/DIO write")
Si
On 2024/3/8 2:37, Jaegeuk Kim wrote:
On 03/07, Chao Yu wrote:
Below race case can cause data corruption:
Thread AGC thread
- f2fs_inplace_write_data
- gc_data_segment
and so on, so
we need to use truncate_inode_pages_range() instead of
invalidate_mapping_pages() to make sure meta_inode page will be dropped.
Fixes: 6aa58d8ad20a ("f2fs: readahead encrypted block during GC")
Fixes: e3b49ea36802 ("f2fs: invalidate META_MAPPING before IPU/DIO write")
Support get_advise command to get i_advise field value and info
in file.
For example:
f2fs_io get_advise /mnt/f2fs/foo.so
i_advise=0x11, advise_type: cold keep_size
Signed-off-by: Chao Yu
---
man/f2fs_io.8 | 3 +++
tools/f2fs_io/f2fs_io.c | 41
reserve_cblocks test.apk
924
Fixes: c75488fb4d82 ("f2fs: introduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Xiuhong Wang
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-
placed after
the judgement of is_inode_flag_set(inode, FI_COMPRESS_RELEASED).
Fixes: c75488fb4d82 ("f2fs: introduce F2FS_IOC_RESERVE_COMPRESS_BLOCKS")
Signed-off-by: Xiuhong Wang
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-
On 2024/3/6 7:28, Jaegeuk Kim wrote:
This patch adds the disk map of block address ranges configured by multiple
partitions.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel
On 2024/3/6 4:48, Jaegeuk Kim wrote:
This fixes some android build failures due to the missing permission when
checking the loop device. Until we get a better solution, let's ignore
the error with warnings.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks
On 2024/3/5 16:40, Xiuhong Wang wrote:
When a file only needs one direct_node, performing the following
operations will cause the file to be unrepairable:
unisoc # ./f2fs_io compress test.apk
unisoc #df -h | grep dm-48
/dev/block/dm-48 112G 112G 1.2M 100% /data
unisoc # ./f2fs_io
On 2024/3/5 16:40, Xiuhong Wang wrote:
The following f2fs_io test will get a "0" result instead of -EINVAL,
unisoc # ./f2fs_io compress file
unisoc # ./f2fs_io reserve_cblocks file
0
it's not reasonable, so the judgement of
atomic_read(_I(inode)->i_compr_blocks) should be placed after
the
On 2024/3/5 16:09, Roman Smirnov wrote:
Cast expression type to unsigned long in __count_extent_cache()
to prevent integer overflow.
Found by Linux Verification Center (linuxtesting.org) with Svace.
Signed-off-by: Roman Smirnov
Reviewed-by: Sergey Shtylyov
Reviewed-by: Chao Yu
Thanks
On 2024/3/4 15:52, Zhiguo Niu wrote:
On Mon, Mar 4, 2024 at 3:17 PM Chao Yu wrote:
On 2024/3/4 11:33, Zhiguo Niu wrote:
On Mon, Mar 4, 2024 at 11:19 AM Chao Yu wrote:
On 2024/3/1 19:36, Zhiguo Niu wrote:
new_curseg may return error if get_new_segment fail, so its result
should be check
On 2024/3/4 11:33, Zhiguo Niu wrote:
On Mon, Mar 4, 2024 at 11:19 AM Chao Yu wrote:
On 2024/3/1 19:36, Zhiguo Niu wrote:
new_curseg may return error if get_new_segment fail, so its result
should be check in its caller f2fs_allocate_segment_for_resize,
alos pass this results
Just cleanup, no functional change.
Signed-off-by: Chao Yu
---
v2:
- don't cast type of segment number from unsigned int
to long long, because segs << log_blocks_per_seg won't
overflow due to f2fs doesn't support 64-bits addressing.
fs/f2fs/debug.c | 7 +++
fs/f2fs/f2fs.h
On 2024/3/1 19:36, Zhiguo Niu wrote:
new_curseg may return error if get_new_segment fail, so its result
should be check in its caller f2fs_allocate_segment_for_resize,
alos pass this results to free_segment_range.
Zhiguo,
What about handling all error paths of new_curseg() and change_curseg()
.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
On 2024/3/1 16:25, Zhiguo Niu wrote:
__allocate_new_segment may return error when get_new_segment
fails, so its caller should check its return value.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux
On 2024/3/1 9:57, Jaegeuk Kim wrote:
On 03/01, Chao Yu wrote:
On 2024/3/1 0:35, Jaegeuk Kim wrote:
On 02/29, Chao Yu wrote:
On 2024/2/28 1:47, Jaegeuk Kim wrote:
On 02/21, Chao Yu wrote:
Just cleanup, no functional change.
Signed-off-by: Chao Yu
---
fs/f2fs/debug.c | 7
On 2024/3/1 1:41, Daeho Jeong wrote:
On Thu, Feb 29, 2024 at 2:11 AM Chao Yu wrote:
Jaegeuk, Daeho,
Any comments on this serials?
Thanks,
No functional difference here, since start_blk is always aligned with
the section address.
You're right.
However, this is more clear in itself
On 2024/3/1 0:35, Jaegeuk Kim wrote:
On 02/29, Chao Yu wrote:
On 2024/2/28 1:47, Jaegeuk Kim wrote:
On 02/21, Chao Yu wrote:
Just cleanup, no functional change.
Signed-off-by: Chao Yu
---
fs/f2fs/debug.c | 7 +++
fs/f2fs/f2fs.h| 14 --
fs/f2fs/gc.c | 10
some redundant judgment code.
Signed-off-by: Zhiguo Niu
Reviewed-by: Chao Yu
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
Support .shutdown callback in f2fs_sops, then, it can be called to
shut down the file system when underlying block device is marked dead.
Signed-off-by: Chao Yu
---
fs/f2fs/f2fs.h | 2 ++
fs/f2fs/file.c | 70 ++---
fs/f2fs/super.c | 6 +
3
Jaegeuk, Daeho,
Any comments on this serials?
Thanks,
On 2024/2/26 9:32, Chao Yu wrote:
In f2fs_migrate_blocks(), when traversing blocks in last section,
blkofs_end should be (start_blk + blkcnt - 1) % blk_per_sec, fix it.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c | 5 +++--
1 file
On 2024/2/28 1:47, Jaegeuk Kim wrote:
On 02/21, Chao Yu wrote:
Just cleanup, no functional change.
Signed-off-by: Chao Yu
---
fs/f2fs/debug.c | 7 +++
fs/f2fs/f2fs.h| 14 --
fs/f2fs/gc.c | 10 +-
fs/f2fs/gc.h | 4 ++--
fs/f2fs/segment.c | 12
On 2024/2/28 1:50, Jaegeuk Kim wrote:
On 02/22, Chao Yu wrote:
f2fs_stop_checkpoint(, false) is complex and it may sleep, so we should
move it outside segmap_lock spinlock coverage in get_new_segment().
Chao, I merged this patch into
https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk
On 2024/2/28 1:47, Jaegeuk Kim wrote:
On 02/21, Chao Yu wrote:
Just cleanup, no functional change.
Signed-off-by: Chao Yu
---
fs/f2fs/debug.c | 7 +++
fs/f2fs/f2fs.h| 14 --
fs/f2fs/gc.c | 10 +-
fs/f2fs/gc.h | 4 ++--
fs/f2fs/segment.c | 12
On 2024/2/28 1:18, Jaegeuk Kim wrote:
On 02/27, Zhiguo Niu wrote:
On Tue, Feb 27, 2024 at 9:13 AM Jaegeuk Kim wrote:
On 02/26, Zhiguo Niu wrote:
Dear Chao,
On Fri, Feb 23, 2024 at 10:38 AM Chao Yu wrote:
On 2024/2/23 10:01, Zhiguo Niu wrote:
On Thu, Feb 22, 2024 at 8:30 PM Chao Yu
On 2024/2/27 6:52, Jaegeuk Kim wrote:
No functional change, but add some more logs.
Reviewed-by: Chao Yu
v2 looks fine to me.
Thanks,
___
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists
On 2024/2/27 8:59, Jaegeuk Kim wrote:
Even if the roll forward recovery stopped due to any error, we have to fix
the write pointers in order to mount the disk from the previous checkpoint.
Signed-off-by: Jaegeuk Kim
Reviewed-by: Chao Yu
Thanks
On 2024/2/27 7:14, Jaegeuk Kim wrote:
In cfd66bb715fd ("f2fs: fix deadloop in foreground GC"), we needed to check
the number of blocks in a section instead of the segment.
Fixes: cfd66bb715fd ("f2fs: fix deadloop in foreground GC")
Signed-off-by: Jaegeuk Kim
Reviewed-
Any comments?
Thanks,
On 2024/2/19 11:13, Chao Yu wrote:
On 2024/2/8 8:18, Jaegeuk Kim wrote:
On 02/06, Chao Yu wrote:
generic/730 2s ... - output mismatch (see
/media/fstests/results//generic/730.out.bad)
--- tests/generic/730.out 2023-08-07 01:39:51.055568499 +
+++ /media
Loop to Zhiguo,
On 2024/2/22 20:18, Chao Yu wrote:
If CONFIG_F2FS_CHECK_FS is off, and for very rare corner case that
we run out of free segment, we should not panic kernel, instead,
let's handle such error correctly in its caller.
Signed-off-by: Chao Yu
---
fs/f2fs/data.c| 7
:
f2fs_update_read_extent_tree_range: dev = (253,48), ino = 5, pgofs = 36, len =
4, blkaddr = 66600, c_len = 3
Fixes: 94afd6d6e525 ("f2fs: extent cache: support unaligned extent")
Signed-off-by: Chao Yu
---
fs/f2fs/compress.c | 10 ++
fs/f2fs/f2fs.h | 6 --
fs/f2fs/node.
:00 [f2fs_discard-253:48]
There will be no deletion in readonly image, let's skip starting
discard thread to save system resources.
Signed-off-by: Chao Yu
---
fs/f2fs/segment.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index b486fe4485f9
On 2024/2/26 11:25, Zhiguo Niu wrote:
Dear Chao,
On Fri, Feb 23, 2024 at 10:38 AM Chao Yu wrote:
On 2024/2/23 10:01, Zhiguo Niu wrote:
On Thu, Feb 22, 2024 at 8:30 PM Chao Yu mailto:c...@kernel.org>> wrote:
On 2024/2/7 10:01, Zhiguo Niu wrote:
> A panic issue
101 - 200 of 6638 matches
Mail list logo
