Re: [f2fs-dev] [PATCH v6.1] f2fs: fix to truncate preallocated blocks in f2fs_file_open()

2024-09-04 Thread Greg KH
On Mon, Sep 02, 2024 at 02:26:16AM -0700, Shivani Agarwal wrote: > From: Chao Yu > > [ Upstream commit 298b1e4182d657c3e388adcc29477904e9600ed5 ] Now qeued up, thanks. greg k-h ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH 6.1] f2fs: add helper to check compression level

2024-02-13 Thread Greg KH
On Tue, Feb 13, 2024 at 12:05:30AM +0800, Chao Yu wrote: > From: Sheng Yong > > commit c571fbb5b59a3741e48014faa92c2f14bc59fe50 upstream. > > This patch adds a helper function to check if compression level is > valid. Now queued up, thanks. greg k-h __

Re: [f2fs-dev] [PATCH 4.19] f2fs: fix to do sanity check on inode type during garbage collection

2023-10-31 Thread Greg KH
On Wed, Oct 25, 2023 at 08:54:32AM +, Kazunori Kobayashi wrote: > From: Chao Yu > > commit 9056d6489f5a41cfbb67f719d2c0ce61ead72d9f upstream. > > As report by Wenqing Liu in bugzilla: > > https://bugzilla.kernel.org/show_bug.cgi?id=215231 > > - Overview > kernel NULL pointer dereference tr

Re: [f2fs-dev] [PATCH v3 01/10] kobject: introduce kobject_del_and_put()

2023-03-23 Thread Greg KH
On Thu, Mar 23, 2023 at 12:58:30AM +0800, Yangtao Li wrote: > There are plenty of using kobject_del() and kobject_put() together > in the kernel tree. This patch wraps these two calls in a single helper. > > Signed-off-by: Yangtao Li > --- > v3: > -convert to inline helper > v2: > -add kobject_de

Re: [f2fs-dev] [PATCH 4.19] f2fs: fix cgroup writeback accounting with fs-layer encryption

2023-03-10 Thread Greg KH
On Tue, Mar 07, 2023 at 10:17:46PM -0800, Eric Biggers wrote: > From: Eric Biggers > > commit 844545c51a5b2a524b22a2fe9d0b353b827d24b4 upstream. > > When writing a page from an encrypted file that is using > filesystem-layer encryption (not inline encryption), f2fs encrypts the > pagecache page

Re: [f2fs-dev] Please apply "ext4, f2fs: fix readahead of verity data" to stable

2022-11-08 Thread Greg KH
On Mon, Nov 07, 2022 at 10:18:34AM -0800, Eric Biggers wrote: > Stable maintainers, > > Please apply commit 4fa0e3ff217f775cb58d2d6d51820ec519243fb9 > ("ext4,f2fs: fix readahead of verity data") to stable, 5.10 and later. It > cherry-picks cleanly to 6.0 and 5.15. I'll send it out manually for 5

Re: [f2fs-dev] [PATCH v3] kset: fix memory leak when kset_register() returns error

2022-10-25 Thread Greg KH
On Tue, Oct 25, 2022 at 03:15:49PM +0800, Yang Yingliang wrote: > Inject fault while loading module, kset_register() may fail. > If it fails, the kset.kobj.name allocated by kobject_set_name() > which must be called before a call to kset_register() may be > leaked, since refcount of kobj was set in

Re: [f2fs-dev] [PATCH v2] kset: fix memory leak when kset_register() returns error

2022-10-24 Thread Greg KH
On Mon, Oct 24, 2022 at 10:39:44PM +0800, Yang Yingliang wrote: > > On 2022/10/24 21:52, Greg KH wrote: > > On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote: > > > Inject fault while loading module, kset_register() may fail. > > > If it fails, the name

Re: [f2fs-dev] [PATCH v2] kset: fix memory leak when kset_register() returns error

2022-10-24 Thread Greg KH
On Mon, Oct 24, 2022 at 08:19:10PM +0800, Yang Yingliang wrote: > Inject fault while loading module, kset_register() may fail. > If it fails, the name allocated by kobject_set_name() which > is called before kset_register() is leaked, because refcount > of kobject is hold in kset_init(). > > As a

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 04:24:23PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > > The previous discussion link: >

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 03:55:18AM -0400, Luben Tuikov wrote: > On 2022-10-21 01:37, Greg KH wrote: > > On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > >> On 2022-10-20 22:20, Yang Yingliang wrote: > >>> The previous discus

Re: [f2fs-dev] [PATCH 01/11] kset: fix documentation for kset_register()

2022-10-21 Thread Greg KH
On Fri, Oct 21, 2022 at 04:05:18PM +0800, Yang Yingliang wrote: > > On 2022/10/21 13:34, Luben Tuikov wrote: > > On 2022-10-20 22:20, Yang Yingliang wrote: > > > kset_register() is currently used in some places without calling > > > kset_put() in error path, because the callers think it should be

Re: [f2fs-dev] [PATCH 00/11] fix memory leak while kset_register() fails

2022-10-20 Thread Greg KH
On Fri, Oct 21, 2022 at 01:29:31AM -0400, Luben Tuikov wrote: > On 2022-10-20 22:20, Yang Yingliang wrote: > > The previous discussion link: > > https://lore.kernel.org/lkml/0db486eb-6927-927e-3629-958f8f211...@huawei.com/T/ > > The very first discussion on this was here: > > https://www.spinics.

Re: [f2fs-dev] [PATCH 5.10 5.15]f2fs: invalidate META_MAPPING before IPU/DIO write

2022-10-13 Thread Greg KH
On Thu, Oct 13, 2022 at 02:26:40PM +0800, lvgaofei wrote: > > OPPO > > 本电子邮件及其附件含有OPPO公司的保密信息,仅限于邮件指明的收件人使用(包含个人及群组)。禁止任何人在未经授权的情况下以任何形式使用。如果您错收了本邮件,请立即以电子邮件通知发件人并删除本邮件及其附件。 > > This e-mail and its attachments contain confidential information from OPPO, > which i

Re: [f2fs-dev] [PATCH] Cherry picked from commit e3b49ea36802053f312013fd4ccb6e59920a9f76 [Please apply to 5.10-stable and 5.15-stable.]

2022-10-13 Thread Greg KH
On Thu, Oct 13, 2022 at 10:39:34AM +0800, lvgaofei wrote: > This e-mail and its attachments contain confidential information from OPPO, > which is intended only for the person or entity whose address is listed > above. Any use of the information contained herein in any way (including, but > not

Re: [f2fs-dev] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Mon, Feb 28, 2022 at 01:06:57PM +0100, Jakob Koschel wrote: > > > > On 28. Feb 2022, at 12:20, Greg KH wrote: > > > > On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > >> If the list does not contain the expected element, the value of > &g

Re: [f2fs-dev] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 06:40:04PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 18:36, Greg KH wrote: > > > > On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > >> > >> > >>> On 1. Mar 2022, at 01:41, Linus Torval

Re: [f2fs-dev] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-03-01 Thread Greg KH
On Tue, Mar 01, 2022 at 12:28:15PM +0100, Jakob Koschel wrote: > > > > On 1. Mar 2022, at 01:41, Linus Torvalds > > wrote: > > > > On Mon, Feb 28, 2022 at 1:47 PM Jakob Koschel > > wrote: > >> > >> The goal of this is to get compiler warnings right? This would indeed be > >> great. > > >

Re: [f2fs-dev] [PATCH 2/6] treewide: remove using list iterator after loop body as a ptr

2022-02-28 Thread Greg KH
On Mon, Feb 28, 2022 at 12:08:18PM +0100, Jakob Koschel wrote: > If the list does not contain the expected element, the value of > list_for_each_entry() iterator will not point to a valid structure. > To avoid type confusion in such case, the list iterator > scope will be limited to list_for_each_e

Re: [f2fs-dev] [PATCH] f2fs: quota: fix potential deadlock

2022-01-05 Thread Greg KH
On Tue, Jan 04, 2022 at 11:48:25PM +0800, Chao Yu wrote: > On 2022/1/4 23:17, Greg KH wrote: > > On Tue, Jan 04, 2022 at 11:05:36PM +0800, Chao Yu wrote: > > > On 2022/1/4 21:18, Greg KH wrote: > > > > On Tue, Jan 04, 2022 at 09:05:13PM +0800, C

Re: [f2fs-dev] [PATCH] f2fs: quota: fix potential deadlock

2022-01-04 Thread Greg KH
On Tue, Jan 04, 2022 at 11:05:36PM +0800, Chao Yu wrote: > On 2022/1/4 21:18, Greg KH wrote: > > On Tue, Jan 04, 2022 at 09:05:13PM +0800, Chao Yu wrote: > > > commit a5c0042200b28fff3bde6fa128ddeaef97990f8d upstream. > > > > > > As Yi Zhuang repo

Re: [f2fs-dev] [PATCH] f2fs: quota: fix potential deadlock

2022-01-04 Thread Greg KH
On Tue, Jan 04, 2022 at 09:05:13PM +0800, Chao Yu wrote: > commit a5c0042200b28fff3bde6fa128ddeaef97990f8d upstream. > > As Yi Zhuang reported in bugzilla: > > https://bugzilla.kernel.org/show_bug.cgi?id=214299 > > There is potential deadlock during quota data flush as below: > > Thread A:

Re: [f2fs-dev] [PATCH 0/4] backport fscrypt symlink fixes to 4.19

2021-09-13 Thread Greg KH
On Wed, Sep 08, 2021 at 02:50:29PM -0700, Eric Biggers wrote: > This series backports some patches that failed to apply to 4.19-stable > due to the prototype of inode_operations::getattr having changed in > v5.12, as well as several other conflicts. Please apply to 4.19-stable. > > Eric Biggers (

Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

2021-09-13 Thread Greg KH
On Thu, Sep 09, 2021 at 08:09:05AM +0200, Greg KH wrote: > On Wed, Sep 08, 2021 at 10:42:53PM -0700, Jaegeuk Kim wrote: > > On 09/09, Greg KH wrote: > > > On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote: > > > > On 09/09, Greg KH wrote: > > >

Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

2021-09-08 Thread Greg KH
On Wed, Sep 08, 2021 at 10:42:53PM -0700, Jaegeuk Kim wrote: > On 09/09, Greg KH wrote: > > On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote: > > > On 09/09, Greg KH wrote: > > > > On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrot

Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

2021-09-08 Thread Greg KH
On Wed, Sep 08, 2021 at 10:28:37PM -0700, Jaegeuk Kim wrote: > On 09/09, Greg KH wrote: > > On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote: > > > From: Jaegeuk Kim > > > > > > commit 3d65293a52c2c3850c19b1e5115712e534d8 upstream. > >

Re: [f2fs-dev] [PATCH] f2fs: guarantee to write dirty data when enabling checkpoint back

2021-09-08 Thread Greg KH
On Wed, Sep 08, 2021 at 03:00:20PM -0700, Jaegeuk Kim wrote: > From: Jaegeuk Kim > > commit 3d65293a52c2c3850c19b1e5115712e534d8 upstream. > > We must flush all the dirty data when enabling checkpoint back. Let's > guarantee > that first by adding a retry logic on sync_inodes_sb(). In addit

Re: [f2fs-dev] [PATCH 5.4 0/4] backport fscrypt symlink fixes to 5.4

2021-09-03 Thread Greg KH
On Wed, Sep 01, 2021 at 09:40:37AM -0700, Eric Biggers wrote: > This series backports some patches that failed to apply to 5.4-stable > due to the prototype of inode_operations::getattr having changed in > v5.12, as well several other conflicts. Please apply to 5.4-stable. > > Eric Biggers (4): >

Re: [f2fs-dev] [PATCH 5.10, 5.12, 5.13] f2fs: Show casefolding support only when supported

2021-07-22 Thread Greg KH
On Tue, Jul 20, 2021 at 09:16:29AM -0700, Eric Biggers wrote: > From: Daniel Rosenberg > > commit 39307f8ee3539478c28e71b4909b5b028cce14b1 upstream. > [Please apply to 5.10-stable, 5.12-stable, and 5.13-stable.] Now queued up to 5.13 and 5.10 stable, thanks. greg k-h _

Re: [f2fs-dev] [PATCH 5.4] f2fs: Show casefolding support only when supported

2021-07-22 Thread Greg KH
On Tue, Jul 20, 2021 at 09:17:09AM -0700, Eric Biggers wrote: > From: Daniel Rosenberg > > commit 39307f8ee3539478c28e71b4909b5b028cce14b1 upstream. > [Please apply to 5.4-stable.] > > The casefolding feature is only supported when CONFIG_UNICODE is set. > This modifies the feature list f2fs pre

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs

2021-06-04 Thread Greg KH
On Fri, Jun 04, 2021 at 08:27:32AM +, David Laight wrote: > From: Jaegeuk Kim > > Sent: 04 June 2021 05:45 > ... > > > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > > > if (f2fs_sb_has_compression(sbi)) > > > > len += scnprintf(buf + len, PA

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs

2021-06-03 Thread Greg KH
On Thu, Jun 03, 2021 at 10:53:26AM -0700, Jaegeuk Kim wrote: > On 06/03, Greg KH wrote: > > On Thu, Jun 03, 2021 at 08:40:24AM -0700, Jaegeuk Kim wrote: > > > On 06/03, Greg KH wrote: > > > > On Thu, Jun 03, 2021 at 09:50:38AM +, Daniel Rosenberg wrote: > &g

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs

2021-06-03 Thread Greg KH
On Thu, Jun 03, 2021 at 08:40:24AM -0700, Jaegeuk Kim wrote: > On 06/03, Greg KH wrote: > > On Thu, Jun 03, 2021 at 09:50:38AM +, Daniel Rosenberg wrote: > > > Older kernels don't support encryption with casefolding. This adds > > > the sysfs entry encrypted_ca

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs

2021-06-03 Thread Greg KH
On Thu, Jun 03, 2021 at 09:50:38AM +, Daniel Rosenberg wrote: > Older kernels don't support encryption with casefolding. This adds > the sysfs entry encrypted_casefold to show support for those combined > features. Support for this feature was originally added by > commit 7ad08a58bf67 ("f2fs: H

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 11:42:04PM +0900, Daeho Jeong wrote: > So, do you want we protect the values here with spin_lock and just > read without spin_lock in sysfs read part? I would not use any lock at all if this were my code. Remember, this is for debugging/information only, right? And the da

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
A: http://en.wikipedia.org/wiki/Top_post Q: Were do I find info about this thing called top-posting? A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I includ

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 10:56:13PM +0900, Daeho Jeong wrote: > Thanks for suggesting me sysfs_emit(). > > For atomic values, actually, those are needed for writer part, not reader. > > +#define add_compr_block_stat(inode, blocks)\ > + do {

Re: [f2fs-dev] [PATCH v4] f2fs: add sysfs nodes to get runtime compression stat

2021-03-12 Thread Greg KH
On Fri, Mar 12, 2021 at 09:25:31PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > I've added new sysfs nodes to show runtime compression stat since mount. > compr_written_block - show the block count written after compression > compr_saved_block - show the saved block count with compression >

Re: [f2fs-dev] [PATCH 5.4 0/4] fscrypt: prevent creating duplicate encrypted filenames

2020-12-30 Thread Greg KH
On Mon, Dec 28, 2020 at 10:54:29AM -0800, Eric Biggers wrote: > Backport four commits from v5.11-rc1. I resolved a conflict in the > first one. The rest are clean cherry-picks which didn't get picked up > yet because they depend on the first one. > > Eric Biggers (4): > fscrypt: add fscrypt_is

Re: [f2fs-dev] [PATCH 4.19 0/4] fscrypt: prevent creating duplicate encrypted filenames

2020-12-30 Thread Greg KH
On Mon, Dec 28, 2020 at 11:12:07AM -0800, Eric Biggers wrote: > Backport four commits from v5.11-rc1. I resolved conflicts in the first > two. > > Eric Biggers (4): > fscrypt: add fscrypt_is_nokey_name() > ext4: prevent creating duplicate encrypted filenames > f2fs: prevent creating duplica

Re: [f2fs-dev] [PATCH 5.10.y] f2fs: fix to seek incorrect data offset in inline data file

2020-12-22 Thread Greg KH
On Tue, Dec 22, 2020 at 09:36:35AM +0100, Greg KH wrote: > On Tue, Dec 22, 2020 at 09:16:34AM +0800, Chao Yu wrote: > > As kitestramuort reported: > > > > F2FS-fs (nvme0n1p4): access invalid blkaddr:1598541474 > > [ 25.725898] [ cut here ] >

Re: [f2fs-dev] [PATCH 5.10.y] f2fs: fix to seek incorrect data offset in inline data file

2020-12-22 Thread Greg KH
On Tue, Dec 22, 2020 at 09:16:34AM +0800, Chao Yu wrote: > As kitestramuort reported: > > F2FS-fs (nvme0n1p4): access invalid blkaddr:1598541474 > [ 25.725898] [ cut here ] > [ 25.725903] WARNING: CPU: 6 PID: 2018 at f2fs_is_valid_blkaddr+0x23a/0x250 > [ 25.725923] Ca

Re: [f2fs-dev] [PATCH] f2fs: fix out-of-repair __setattr_copy()

2020-12-16 Thread Greg KH
On Wed, Dec 16, 2020 at 05:15:23PM +0800, Chao Yu wrote: > __setattr_copy() was copied from setattr_copy() in fs/attr.c, there is > two missing patches doesn't cover this inner function, fix it. > > Commit 7fa294c8991c ("userns: Allow chown and setgid preservation") > Commit 23adbe12ef7d ("fs,user

Re: [f2fs-dev] [PATCH] f2fs: init dirty_secmap incorrectly

2020-11-30 Thread Greg KH
On Mon, Nov 30, 2020 at 03:37:19PM +0800, Jack Qiu wrote: > section is dirty, but dirty_secmap may not set > > Reported-by: Jia Yang > Fixes: da52f8ade40b ("f2fs: get the right gc victim section when section > has several segments") > > Signed-off-by: Jack Qiu > --- > v2: > - cc stable mailing

Re: [f2fs-dev] [PATCH 4.19 0/5] backport some more fscrypt fixes to 4.19

2020-11-01 Thread Greg KH
On Sat, Oct 31, 2020 at 03:05:48PM -0700, Eric Biggers wrote: > Backport some fscrypt fixes from upstream 5.2 to 4.19-stable. > > This is needed to get 'kvm-xfstests -c ext4,f2fs,ubifs -g encrypt' to > fully pass on 4.19-stable. Before, generic/397 and generic/429 failed > on UBIFS due to missing

Re: [f2fs-dev] [PATCH 4.9 0/2] backport some more fscrypt fixes to 4.9

2020-11-01 Thread Greg KH
On Sat, Oct 31, 2020 at 04:11:22PM -0700, Eric Biggers wrote: > Backport some fscrypt fixes from 4.10 and 4.11 to 4.9-stable. > These will be needed for xfstest generic/395 to pass if > https://lkml.kernel.org/fstests/20201031054018.695314-1-ebigg...@kernel.org > is applied. > > These are clean ch

Re: [f2fs-dev] [PATCH 4.4] f2fs crypto: avoid unneeded memory allocation in ->readdir

2020-11-01 Thread Greg KH
On Sat, Oct 31, 2020 at 12:58:09PM -0700, Eric Biggers wrote: > From: Chao Yu > > commit e06f86e61d7a67fe6e826010f57aa39c674f4b1b upstream. > [This backport fixes a regression in 4.4-stable caused by commit > 11a6e8f89521 ("f2fs: check memory boundary by insane namelen"), which > depended on this

Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name

2020-07-22 Thread Greg KH
On Wed, Jul 22, 2020 at 10:24:37AM -0700, Jaegeuk Kim wrote: > On 07/22, Greg KH wrote: > > On Wed, Jul 22, 2020 at 09:43:56AM -0700, Jaegeuk Kim wrote: > > > On 07/19, Greg KH wrote: > > > > On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrot

Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name

2020-07-22 Thread Greg KH
On Wed, Jul 22, 2020 at 09:43:56AM -0700, Jaegeuk Kim wrote: > On 07/19, Greg KH wrote: > > On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote: > > > From: Daeho Jeong > > > > > > Added a symbolic link directory pointing to its device name > >

Re: [f2fs-dev] [PATCH 1/2] f2fs: add sysfs symbolic link to kobject with volume name

2020-07-19 Thread Greg KH
On Sun, Jul 19, 2020 at 02:44:08PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link directory pointing to its device name > directory using the volume name of the partition in sysfs. > (i.e., /sys/fs/f2fs/vol_#x -> /sys/fs/f2fs/sda1) No, please no. That is already created

Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs

2020-07-08 Thread Greg KH
On Mon, Jul 06, 2020 at 08:47:07AM +0900, Daeho Jeong wrote: > > No Documentation/ABI/ entry for your new sysfs file/link? > > This is for adding a symbolic link to a pre-existed > /sys/fs/f2fs/ directory and it means /sys/fs/f2fs/ points > to /sys/fs/f2fs/. I already added the description of this

Re: [f2fs-dev] [PATCH v3] f2fs: add symbolic link to kobject in sysfs

2020-07-03 Thread Greg KH
On Fri, Jul 03, 2020 at 03:54:20PM +0900, Daeho Jeong wrote: > From: Daeho Jeong > > Added a symbolic link to directory of sysfs. It will > create a symbolic link such as "mount_0" and "mount_1" to > each f2fs mount in the order of mounting filesystem. But > once one mount point was umounted, tha

Re: [f2fs-dev] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()

2020-06-01 Thread Greg KH
On Tue, Jun 02, 2020 at 07:51:52AM +0200, Christoph Hellwig wrote: > On Mon, Jun 01, 2020 at 10:44:26AM +0200, Greg KH wrote: > > But does this code path actually show up anywhere that is actually > > measurable as mattering? > > > > If so, please show that benchmar

Re: [f2fs-dev] [PATCH v2] blkdev: Replace blksize_bits() with ilog2()

2020-06-01 Thread Greg KH
On Mon, Jun 01, 2020 at 03:22:01PM +0800, Tao pilgrim wrote: > On Fri, May 29, 2020 at 10:13 PM Jens Axboe wrote: > > > > On 5/29/20 8:11 AM, Kaitao Cheng wrote: > > > There is a function named ilog2() exist which can replace blksize. > > > The generated code will be shorter and more efficient on

[f2fs-dev] Linux kernel development reports for the 5.5 release

2020-01-30 Thread Greg KH
Hi, I'm trying to keep track of the different companies that people are working for, or if people are just doing this as a hobby, or being paid as a consultant for future articles on lwn.net about who is doing the work on the Linux kernel. Jonathan Corbet has also been writing articles at lwn.net

Re: [f2fs-dev] [PATCH] fscrypt: reserve flags for hardware-wrapped keys feature

2020-01-17 Thread Greg KH
On Fri, Jan 17, 2020 at 11:40:54AM -0500, Theodore Y. Ts'o wrote: > On Fri, Jan 17, 2020 at 12:12:46AM -0800, Christoph Hellwig wrote: > > On Thu, Jan 16, 2020 at 11:20:08AM -0800, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > Reserve flags for the hardware-wrapped keys feature which i

Re: [f2fs-dev] loop: avoid EAGAIN, if offset or block_size are changed

2019-11-18 Thread Greg KH
On Mon, Nov 18, 2019 at 11:36:16AM -0700, Andrew Norrie wrote: > This email and any accompanying attachments are confidential. If you received > this email by mistake, please delete > it from your system. Any review, disclosure, copying, distribution, or use of > the email by others is strictly p

Re: [PATCH v8 03/20] timestamp_truncate: Replace users of timespec64_trunc

2019-08-18 Thread Greg KH
On Sun, Aug 18, 2019 at 09:58:00AM -0700, Deepa Dinamani wrote: > Update the inode timestamp updates to use timestamp_truncate() > instead of timespec64_trunc(). > > The change was mostly generated by the following coccinelle > script. > > virtual context > virtual patch > > @r1 depends on patch

Re: [f2fs-dev] [PATCH v2] f2fs: fix to update new block address correctly for OPU

2018-11-26 Thread Greg KH
On Tue, Nov 27, 2018 at 02:32:32AM +0800, Jia Zhu wrote: > Previously, we allocated a new block address for OPU mode in direct_IO. > > But the new address couldn't be assigned to @map->m_pblk correctly. > > This patch fix it. > > Fixes: 511f52d02f05 ('f2fs: allow out-place-update for direct IO i

Re: [f2fs-dev] Patch "Revert "f2fs: fix to clear PG_checked flag in set_page_dirty()"" has been added to the 4.18-stable tree

2018-11-11 Thread Greg KH
On Sun, Nov 11, 2018 at 06:13:14PM +0900, Ju Hyung Park wrote: > Hi, > > This bug was present only in 4.19. > Is it still applicable to older branches? > > Thanks. > > On Sun, Nov 11, 2018, 12:26 PM > > > > This is a note to let you know that I've just added the patch titled > > > > Revert

Re: [f2fs-dev] [PATCHv2 1/1] ext4/f2fs: don't put symlink in pagecache into highmem

2018-02-07 Thread Greg KH
Some minor nits for when you send your next patch for stable: On Tue, Feb 06, 2018 at 03:53:53PM -0800, Jin Qian wrote: > From: Jin Qian The original patch was written by Al Viro, please do not take the original authorship off, that's not good. > partial backport from 21fc61c73c3903c4c312d0802d

Re: [f2fs-dev] [PATCHv2 1/1] f2fs: sanity check checkpoint segno and blkoff

2017-05-14 Thread Greg KH
On Fri, May 12, 2017 at 10:50:40AM -0700, Jin Qian wrote: > Make sure segno and blkoff read from raw image are valid. > > Change-Id: Ia37f5e03aba85f483ddad7a38c64c8e2dbb02243 What is this here for? That's not really wanted on kernel patches :) thanks, greg k-h

Re: [f2fs-dev] [PATCH 1/1] f2fs: sanity check checkpoint segno and blkoff

2017-05-11 Thread Greg KH
On Thu, May 11, 2017 at 05:24:20PM -0700, Jin Qian wrote: > Make sure segno and blkoff read from raw image are valid. > > Signed-off-by: Jin Qian > --- > fs/f2fs/super.c | 18 ++ > 1 file changed, 18 insertions(+) This is not the correct way to submit patches for inclusion in

Re: [f2fs-dev] [GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-08-17 Thread Greg KH
On Sat, Aug 13, 2016 at 03:48:12PM -0700, Deepa Dinamani wrote: > The series is aimed at getting rid of CURRENT_TIME and CURRENT_TIME_SEC > macros. > The macros are not y2038 safe. There is no plan to transition them into being > y2038 safe. > ktime_get_* api's can be used in their place. And, the

Re: [f2fs-dev] [GIT PULL] [PATCH v4 00/26] Delete CURRENT_TIME and CURRENT_TIME_SEC macros

2016-08-17 Thread Greg KH
On Tue, Aug 16, 2016 at 11:18:52AM -0700, Deepa Dinamani wrote: > Thank you for the suggestion. > > > Who are you execting to pull this huge patch series? > > The last pull request was addressed to Al as per Arnd's suggestion. > I'm not completely sure who should it be addressed to. > > > Why no

Re: [f2fs-dev] [PATCH 6/26] staging: rtl8192u: Use skcipher and ahash

2016-01-24 Thread Greg KH
On Sun, Jan 24, 2016 at 09:16:57PM +0800, Herbert Xu wrote: > This patch replaces uses of blkcipher with skcipher, and the long > obsolete hash interface with ahash. > > Signed-off-by: Herbert Xu > --- > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 92 > +++--- >

Re: [f2fs-dev] [PATCH 3/26] staging: rtl8192e: Replace uses of obsolete blkcipher and hash

2016-01-24 Thread Greg KH
On Sun, Jan 24, 2016 at 09:16:26PM +0800, Herbert Xu wrote: > The interfaces blkcipher and hash are obsolete. This patch replaces > them with skcipher and ahash respectively. > > Signed-off-by: Herbert Xu > --- > > drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 99 > ++--

Re: [f2fs-dev] [PATCH 3.15 2/2] f2fs: check bdi->dirty_exceeded when trying to skip data writes

2014-07-14 Thread Greg KH
On Mon, Jul 14, 2014 at 07:52:51AM -0700, Jaegeuk Kim wrote: > commit dd6b9bf5883c3ca9c17bac80ccd8615fe5a452a3 upstream. You mean 2743f865543c0c4a5e12fc13edb2bf89a6e9687c, right? thanks, greg k-h > > If we don't check the current backing device status, balance_dirty_pages can > fall into infin