Re: [f2fs-dev] [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code

On Thu, Aug 10, 2023 at 8:05 PM Jan Kara wrote: > > On Fri 04-08-23 11:01:39, Ryusuke Konishi wrote: > > On Thu, Aug 3, 2023 at 8:46 PM Jan Kara wrote: > > > > > > On Wed 02-08-23 17:41:21, Christoph Hellwig wrote: > > > > Use the generic setup_bdev_

Re: [f2fs-dev] [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code

that only opens the block device after the superblock has allocated. > > It does not yet convert nilfs2 to the new mount API, but doing so will > become a bit simpler after this first step. > > Signed-off-by: Christoph Hellwig Acked-by: Ryusuke Konishi This patch itself looks to pr

Re: [f2fs-dev] [PATCH 02/12] nilfs2: use setup_bdev_super to de-duplicate the mount code

ent mount. If the current tree isn't mounted, it just cleans up the garbage, and the reference count wouldn't have incremented in parallel. If the current tree is mounted, d_count(s->s_root) will not decrease to 1, so it's not a problem. However, this will cause un

Re: [f2fs-dev] [PATCH v2 18/23] nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag()

--- > 1 file changed, 16 insertions(+), 13 deletions(-) Acked-by: Ryusuke Konishi Looks good. Thank you for reflecting the previous comment. Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https

Re: [f2fs-dev] [PATCH 21/23] nilfs2: Convert nilfs_copy_dirty_pages() to use filemap_get_folios_tag()

> 1 file changed, 20 insertions(+), 19 deletions(-) Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 18/23] nilfs2: Convert nilfs_lookup_dirty_data_buffers() to use filemap_get_folios_tag()

.pages[i]; > + struct folio *folio = fbatch.folios[i]; > > - lock_page(page); > - if (!page_has_buffers(page)) > - create_empty_buffers(page, i_blocksize(inode), 0); > - unlock_page(page); > +

Re: [f2fs-dev] [PATCH 22/23] nilfs2: Convert nilfs_clear_dirty_pages() to use filemap_get_folios_tag()

> 1 file changed, 10 insertions(+), 10 deletions(-) Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 19/23] nilfs2: Convert nilfs_lookup_dirty_node_buffers() to use filemap_get_folios_tag()

> 1 file changed, 7 insertions(+), 8 deletions(-) Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 20/23] nilfs2: Convert nilfs_btree_lookup_dirty_buffers() to use filemap_get_folios_tag()

> 1 file changed, 7 insertions(+), 7 deletions(-) Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 07/10] nilfs2: Convert nilfs_copy_back_pages() to use filemap_get_folios()

out, looks good to me. Thank you so much for your great work. Acked-by: Ryusuke Konishi Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 26/27] block: uncouple REQ_OP_SECURE_ERASE from REQ_OP_DISCARD

pages(void) > > extern void blk_io_schedule(void); > > -#define BLKDEV_DISCARD_SECURE (1 << 0)/* issue a secure erase */ > - > -extern int blkdev_issue_discard(struct block_device *bdev, sector_t sector, > - sector_t nr_sects, gfp_t gfp_mask

Re: [f2fs-dev] [PATCH 24/27] block: add a bdev_discard_granularity helper

ge.minlen = max_t(u64, > bdev_discard_granularity(sb->s_bdev), > range.minlen); > ret = ocfs2_trim_fs(sb, ); > if (ret < 0) > diff --git a/fs/xfs/xfs_discard.c b/fs/xfs/xfs_discard.c > index a4e6609d616b7..e

Re: [f2fs-dev] [PATCH 23/27] block: add a bdev_max_discard_sectors helper

eading things, could you please document that > bdev_max_discard_sectors() != 0 implies that discard is supported? I got the same impression. Checking the discard support with bdev_max_discard_sectors() != 0 seems a bit unclear than before. Thanks, Ryusuke Konishi ___

Re: [f2fs-dev] [PATCH 08/11] Remove bdi_congested() and wb_congested() and related functions

E > is set. > > So replace the calls by 'false' and simplify the code - and remove the > functions. > > Acked-by: Ryusuke Konishi (for nilfs bits) > Signed-off-by: NeilBrown > --- > drivers/block/drbd/drbd_int.h |3 --- > drivers/block/drbd/drbd_req.c |

Re: [f2fs-dev] [PATCH 2/9] Remove bdi_congested() and wb_congested() and related functions

mm/vmscan.c |4 +--- > 7 files changed, 2 insertions(+), 50 deletions(-) for nilfs2 bits, Acked-by: Ryusuke Konishi Thanks, Ryusuke Konishi ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH 04/21] fs: Replace CURRENT_TIME with current_fs_time() for inode timestamps

for nilfs2 bits: Acked-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp> Thanks, Ryusuke Konishi -- What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic patterns at an interface-level. R

Re: [f2fs-dev] [dm-devel] [PATCH 04/42] fs: have submit_bh users pass in op and flags separately

> > Signed-off-by: Mike Christie <mchri...@redhat.com> > Reviewed-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Hannes Reinecke <h...@suse.com> > --- Looks good with regard to nilfs2. Acked-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp> > drivers

Re: [f2fs-dev] [PATCH 16/42] nilfs: set bi_op to REQ_OP

ewed-by: Christoph Hellwig <h...@lst.de> > Reviewed-by: Hannes Reinecke <h...@suse.com> > --- > fs/nilfs2/segbuf.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) Looks good to me. Acked-by: Ryusuke Konishi <konishi.ryus...@lab.ntt.co.jp&g