Re: [PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Jaegeuk Kim
On 01/12, Eric Biggers wrote: > On Fri, Jan 12, 2024 at 05:28:31PM -0800, Jaegeuk Kim wrote: > > On 01/12, Eric Biggers wrote: > > > On Fri, Jan 12, 2024 at 04:57:47PM -0800, Eric Biggers wrote: > > > > From: Eric Biggers > > > > > > > > kill_f2fs_super() is called even if f2fs_fill_super()

Re: [PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Eric Biggers
On Fri, Jan 12, 2024 at 05:28:31PM -0800, Jaegeuk Kim wrote: > On 01/12, Eric Biggers wrote: > > On Fri, Jan 12, 2024 at 04:57:47PM -0800, Eric Biggers wrote: > > > From: Eric Biggers > > > > > > kill_f2fs_super() is called even if f2fs_fill_super() fails. > > > f2fs_fill_super() frees the

Re: [PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Jaegeuk Kim
On 01/12, Eric Biggers wrote: > On Fri, Jan 12, 2024 at 04:57:47PM -0800, Eric Biggers wrote: > > From: Eric Biggers > > > > kill_f2fs_super() is called even if f2fs_fill_super() fails. > > f2fs_fill_super() frees the struct f2fs_sb_info, so it must set > > sb->s_fs_info to NULL to prevent it

Re: [f2fs-dev] [PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Chao Yu
On 2024/1/13 8:57, Eric Biggers wrote: From: Eric Biggers kill_f2fs_super() is called even if f2fs_fill_super() fails. f2fs_fill_super() frees the struct f2fs_sb_info, so it must set sb->s_fs_info to NULL to prevent it from being freed again. Oh, I missed that case as well during reviewing,

Re: [PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Eric Biggers
On Fri, Jan 12, 2024 at 04:57:47PM -0800, Eric Biggers wrote: > From: Eric Biggers > > kill_f2fs_super() is called even if f2fs_fill_super() fails. > f2fs_fill_super() frees the struct f2fs_sb_info, so it must set > sb->s_fs_info to NULL to prevent it from being freed again. > > Fixes:

[PATCH] f2fs: fix double free of f2fs_sb_info

2024-01-12 Thread Eric Biggers
From: Eric Biggers kill_f2fs_super() is called even if f2fs_fill_super() fails. f2fs_fill_super() frees the struct f2fs_sb_info, so it must set sb->s_fs_info to NULL to prevent it from being freed again. Fixes: 275dca4630c1 ("f2fs: move release of block devices to after kill_block_super()")