Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-09-26 Thread Jaegeuk Kim
On 09/26, Jaegeuk Kim wrote: > On 09/26, Eric Biggers wrote: > > On Fri, Aug 16, 2019 at 11:03:34AM +0800, Chao Yu wrote: > > > There is one case can cause data corruption. > > > > > > - write 4k to fileA > > > - fsync fileA, 4k data is writebacked to lbaA > > > - write 4k to fileA > > > -

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-09-26 Thread Eric Biggers
On Fri, Aug 16, 2019 at 11:03:34AM +0800, Chao Yu wrote: > There is one case can cause data corruption. > > - write 4k to fileA > - fsync fileA, 4k data is writebacked to lbaA > - write 4k to fileA > - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet > - write 4k to fileB > -

Re: [f2fs-dev] [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-08-20 Thread Chao Yu
On 2019/8/20 9:00, Jaegeuk Kim wrote: > On 08/19, Chao Yu wrote: >> On 2019/8/16 11:03, Chao Yu wrote: >>> There is one case can cause data corruption. >>> >>> - write 4k to fileA >>> - fsync fileA, 4k data is writebacked to lbaA >>> - write 4k to fileA >>> - kworker flushs 4k to lbaB; dnode

Re: [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-08-19 Thread Jaegeuk Kim
On 08/19, Chao Yu wrote: > On 2019/8/16 11:03, Chao Yu wrote: > > There is one case can cause data corruption. > > > > - write 4k to fileA > > - fsync fileA, 4k data is writebacked to lbaA > > - write 4k to fileA > > - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet > > -

Re: [PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-08-19 Thread Chao Yu
On 2019/8/16 11:03, Chao Yu wrote: > There is one case can cause data corruption. > > - write 4k to fileA > - fsync fileA, 4k data is writebacked to lbaA > - write 4k to fileA > - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet > - write 4k to fileB > - kworker flush 4k to

[PATCH] f2fs: fix to avoid data corruption by forbidding SSR overwrite

2019-08-15 Thread Chao Yu
There is one case can cause data corruption. - write 4k to fileA - fsync fileA, 4k data is writebacked to lbaA - write 4k to fileA - kworker flushs 4k to lbaB; dnode contain lbaB didn't be persisted yet - write 4k to fileB - kworker flush 4k to lbaA due to SSR - SPOR -> dnode with lbaA will be