Re: [f2fs-dev] [PATCH] f2fs: cache more dentry pages

2024-11-22 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/11 12:31, zangyangyang1 wrote: f2fs_find_data_page is used to find dentry pages, I think we should cache more dentry pages. How about? "While traversing dir entries in dentry page, it's better to refresh current accessed page in lru list by using FGP_ACCESSED flag, otherwise, such p

Re: [f2fs-dev] [PATCH] f2fs: cache more dentry pages

2024-11-19 Thread zangyangyang1 via Linux-f2fs-devel
> On 2024/11/11 12:31, zangyangyang1 wrote: >> f2fs_find_data_page is used to find dentry pages, >> I think we should cache more dentry pages. > > Hi, > > Did you suffer any issue w/o this change? Hi, No issue encountered, I just think that dentry pages are more important, so we can put them in th

Re: [f2fs-dev] [PATCH] f2fs: cache more dentry pages

2024-11-17 Thread Chao Yu via Linux-f2fs-devel
On 2024/11/11 12:31, zangyangyang1 wrote: f2fs_find_data_page is used to find dentry pages, I think we should cache more dentry pages. Hi, Did you suffer any issue w/o this change? Thanks, Signed-off-by: zangyangyang1 --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[f2fs-dev] [PATCH] f2fs: cache more dentry pages

2024-11-10 Thread zangyangyang1 via Linux-f2fs-devel
f2fs_find_data_page is used to find dentry pages, I think we should cache more dentry pages. Signed-off-by: zangyangyang1 --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 402e00d54c0b..71ca987fe7cd 100644 --- a/fs/f2fs/d