Re: [f2fs-dev] [PATCH] f2fs: do not set STATX_DIOALIGN if dio is not supported

2024-09-23 Thread Eric Biggers via Linux-f2fs-devel
On Mon, Sep 23, 2024 at 12:37:32AM -0600, Wu Bo via Linux-f2fs-devel wrote: > Therefore, if the filesystem does not support DIO, it should not set > the STATX_DIOALIGN flag. No, that's incorrect. STATX_DIOALIGN supports reporting that DIO is unsupported, via the alignments being 0. See the statx

[f2fs-dev] [PATCH] f2fs: do not set STATX_DIOALIGN if dio is not supported

2024-09-22 Thread Wu Bo via Linux-f2fs-devel
According to the definition of statx.stx_mask: It simply informs the caller which values are supported by the kernel and filesystem via the statx.stx_mask field. (quote from the "Linux Programmer's Manual"). Therefore, if the filesystem does not support DIO, it should not set the STATX_DIOALIGN fl