Re: [f2fs-dev] [PATCH] f2fs: fix deadlock in f2f2_add_dentry

2023-09-06 Thread Tetsuo Handa
On 2023/08/25 14:37, Lizhi Xu wrote: > @@ -736,12 +736,12 @@ int f2fs_add_regular_entry(struct inode *dir, const > struct f2fs_filename *fname, > f2fs_wait_on_page_writeback(dentry_page, DATA, true, true); > > if (inode) { > - f2fs_down_write(&F2FS_I(inode)->i_sem); >

Re: [f2fs-dev] [PATCH] f2fs: fix deadlock in f2f2_add_dentry

2023-08-25 Thread Lizhi Xu via Linux-f2fs-devel
On Fri, 25 Aug 2023 18:41:38, c...@kernel.org wrote: > Can you please check below patch? it has fixed reported issue. > > https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev&id=5c13e2388bf3426fd69a89eb46e50469e9624e56 > > Feedback from syzbot: > > https://lore.kernel.or

Re: [f2fs-dev] [PATCH] f2fs: fix deadlock in f2f2_add_dentry

2023-08-25 Thread Chao Yu
On 2023/8/25 13:37, Lizhi Xu wrote: There are two paths: 1. f2fs_add_dentry->f2fs_down_read->f2fs_add_inline_entry->down_write-> up_write->f2fs_up_read 2. f2fs_add_dentry->f2fs_add_regular_entry->down_write-> f2fs_init_inode_metadata->f2fs_down_read->f2fs_up_read->up_write Force order lo

[f2fs-dev] [PATCH] f2fs: fix deadlock in f2f2_add_dentry

2023-08-24 Thread Lizhi Xu via Linux-f2fs-devel
There are two paths: 1. f2fs_add_dentry->f2fs_down_read->f2fs_add_inline_entry->down_write-> up_write->f2fs_up_read 2. f2fs_add_dentry->f2fs_add_regular_entry->down_write-> f2fs_init_inode_metadata->f2fs_down_read->f2fs_up_read->up_write Force order lock to read->write. Signed-off-by: Lizhi