Re: [f2fs-dev] [PATCH] f2fs: set zstd default compression level to 3

2023-06-12 Thread Jaegeuk Kim
On 06/12, Chao Yu wrote: > On 2023/6/8 0:29, Jaegeuk Kim wrote: > > ZSTD does not support compress_level=0. > > IIUC, it looks the range is [0, ZSTD_MAX_CLEVEL], 0 equals to default > (ZSTD_CLEVEL_DEFAULT). Ok, that seems a quick workaround of zstd, since it'd be quite hard to know level=0 will b

Re: [f2fs-dev] [PATCH] f2fs: set zstd default compression level to 3

2023-06-12 Thread Chao Yu
On 2023/6/8 0:29, Jaegeuk Kim wrote: ZSTD does not support compress_level=0. IIUC, it looks the range is [0, ZSTD_MAX_CLEVEL], 0 equals to default (ZSTD_CLEVEL_DEFAULT). zstd_compress.c /* row */ if (compressionLevel == 0) row = ZSTD_CLEVEL_DEFAULT; /* 0 == default */ else if (c

[f2fs-dev] [PATCH] f2fs: set zstd default compression level to 3

2023-06-07 Thread Jaegeuk Kim
ZSTD does not support compress_level=0. The commit d7ffafc99c42 ("f2fs: add sanity compress level check for compressed file") revealed the issue. Signed-off-by: Jaegeuk Kim --- fs/f2fs/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c